[PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message

[PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message

[Lambrecht Jürgen]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

Hi,

I found a bug and fixed it, so I don't know if I need to use bugzilla 
for that?
In attach the patch.

file: net/common/current/src/dhcp_prot.c

According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The 
DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same 
transaction ID should be used ('xid' in C code).
We never had problems with that, but now we have a strict customer..

Kind regards,
Jürgen

-- 
Jürgen Lambrecht
R&D Associate
Mobile: +32 499 644 531
Tel: +32 (0)51 303045    Fax: +32 (0)51 310670
http://www.televic-rail.com
Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
Company number 0825.539.581 - RPR Kortrijk


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dhcp_prot.patch --]
[-- Type: text/x-patch; name="dhcp_prot.patch", Size: 1192 bytes --]

Index: net/common/current/src/dhcp_prot.c
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/common/current/src/dhcp_prot.c,v
retrieving revision 1.23
diff -u -5 -p -r1.23 dhcp_prot.c
--- net/common/current/src/dhcp_prot.c	11 Mar 2011 20:00:20 -0000	1.23
+++ net/common/current/src/dhcp_prot.c	12 Feb 2014 12:26:46 -0000
@@ -926,11 +926,12 @@ do_dhcp(const char *intf, struct bootp *
                     // Save the good packet in *xmit
                     bcopy( received, xmit, dhcp_size(received) );
                     // we like the packet, so reset the timeout for next time
                     reset_timeout( &tv, &timeout_scratch );
                     *pstate = DHCPSTATE_REQUESTING;
-                    NEW_XID( xid ); // Happy to advance, so new XID
+		    // *no* new XID: The DHCPREQUEST message contains the same
+		    // 'xid' as the DHCPOFFER message (http://www.faqs.org/rfcs/rfc2131.html). 
                 }
             }
             else // No TAG_DHCP_MESS_TYPE entry so it's a bootp reply
                 seen_bootp_reply = 1; // (keep the bootp packet in received)
                 

Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message

[Michael Jones]

Jurgen,

I typically put these in bugzilla with an explanation. That is where people look for patches before they are part of the source tree. As far as I can tell, it is the only way patches become part of the code base.

Mike

On Feb 12, 2014, at 6:08 AM, Lambrecht Jürgen <J.Lambrecht@TELEVIC.com> wrote:

> Hi,
> 
> I found a bug and fixed it, so I don't know if I need to use bugzilla 
> for that?
> In attach the patch.
> 
> file: net/common/current/src/dhcp_prot.c
> 
> According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The 
> DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
> So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same 
> transaction ID should be used ('xid' in C code).
> We never had problems with that, but now we have a strict customer..
> 
> Kind regards,
> Jürgen
> 
> -- 
> Jürgen Lambrecht
> R&D Associate
> Mobile: +32 499 644 531
> Tel: +32 (0)51 303045    Fax: +32 (0)51 310670
> http://www.televic-rail.com
> Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
> Company number 0825.539.581 - RPR Kortrijk
> 
> <dhcp_prot.patch>

Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message

["Ilija Kocho [Илија Кочо]"]

On 12.02.2014 15:32, Michael Jones wrote:
> Jurgen,
>
> I typically put these in bugzilla with an explanation. That is where people look for patches before they are part of the source tree. As far as I can tell, it is the only way patches become part of the code base.

Indeed, Bugzilla is the preferred place for patch submission. Besides
discussion/collaboration forum, Bugzilla provides searchable database.
Patches and contributions is still available for but is depreciated.
Ref: http://ecos.sourceware.org/ecos/intouch.html . eCos Bugzilla shall
also forward the bug to patches mailing list if you select /Patches and
contributions/ component.

Ilija

> Mike
>
> On Feb 12, 2014, at 6:08 AM, Lambrecht Jürgen <J.Lambrecht@TELEVIC.com> wrote:
>
>> Hi,
>>
>> I found a bug and fixed it, so I don't know if I need to use bugzilla 
>> for that?
>> In attach the patch.
>>
>> file: net/common/current/src/dhcp_prot.c
>>
>> According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The 
>> DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
>> So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same 
>> transaction ID should be used ('xid' in C code).
>> We never had problems with that, but now we have a strict customer..
>>
>> Kind regards,
>> Jürgen
>>
>> -- 
>> Jürgen Lambrecht
>> R&D Associate
>> Mobile: +32 499 644 531
>> Tel: +32 (0)51 303045    Fax: +32 (0)51 310670
>> http://www.televic-rail.com
>> Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
>> Company number 0825.539.581 - RPR Kortrijk
>>
>> <dhcp_prot.patch>