From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7758 invoked by alias); 15 Feb 2014 00:03:19 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 7748 invoked by uid 89); 15 Feb 2014 00:03:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL autolearn=no version=3.3.2 X-HELO: gateway14.websitewelcome.com Received: from gateway14.websitewelcome.com (HELO gateway14.websitewelcome.com) (69.56.195.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Feb 2014 00:03:17 +0000 Received: by gateway14.websitewelcome.com (Postfix, from userid 5007) id B822C670843B7; Fri, 14 Feb 2014 18:03:15 -0600 (CST) Received: from ham04.websitewelcome.com (unknown [184.173.232.33]) by gateway14.websitewelcome.com (Postfix) with ESMTP id 9DAB367084380 for ; Fri, 14 Feb 2014 18:03:15 -0600 (CST) Received: by ham04.websitewelcome.com (Postfix, from userid 500) id 97ACCA9E9D1B3; Fri, 14 Feb 2014 18:03:15 -0600 (CST) X-Spam-Flag2999: NO X-Spam-Level2999: X-Spam-Status2999: "No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU autolearn=unavailable version=3.3.1 Received: from montecarlo.websitewelcome.com (montecarlo.websitewelcome.com [192.185.12.42]) by ham04.websitewelcome.com (Postfix) with ESMTP id 55209A9E9CF2C for ; Fri, 14 Feb 2014 18:03:14 -0600 (CST) Received: from [85.225.29.229] (port=43632 helo=[192.168.0.112]) by montecarlo.websitewelcome.com with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.80.1) (envelope-from ) id 1WESiv-0003Wb-Ou; Fri, 14 Feb 2014 18:03:13 -0600 Message-ID: <52FEAEBF.6010400@siva.com.mk> Date: Sat, 15 Feb 2014 00:03:00 -0000 From: =?UTF-8?B?IklsaWphIEtvY2hvIFvQmNC70LjRmNCwINCa0L7Rh9C+XSI=?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Michael Jones , =?UTF-8?B?TGFtYnJlY2h0IErDvHJnZW4=?= CC: "ecos-patches@ecos.sourceware.org" Subject: Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message References: <52FB723E.2080900@televic.com> <45BF36F1-2D74-464D-AAC6-D69F5D7D663B@linear.com> In-Reply-To: <45BF36F1-2D74-464D-AAC6-D69F5D7D663B@linear.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BWhitelist: no X-Source-Sender: ([192.168.0.112]) [85.225.29.229]:43632 X-Source-Auth: ilijak+siva.mk X-Email-Count: 1 X-Source-Cap: c2l2YW1rO2JpYmltYW47bW9udGVjYXJsby53ZWJzaXRld2VsY29tZS5jb20= X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00007.txt.bz2 On 12.02.2014 15:32, Michael Jones wrote: > Jurgen, > > I typically put these in bugzilla with an explanation. That is where people look for patches before they are part of the source tree. As far as I can tell, it is the only way patches become part of the code base. Indeed, Bugzilla is the preferred place for patch submission. Besides discussion/collaboration forum, Bugzilla provides searchable database. Patches and contributions is still available for but is depreciated. Ref: http://ecos.sourceware.org/ecos/intouch.html . eCos Bugzilla shall also forward the bug to patches mailing list if you select /Patches and contributions/ component. Ilija > Mike > > On Feb 12, 2014, at 6:08 AM, Lambrecht Jürgen wrote: > >> Hi, >> >> I found a bug and fixed it, so I don't know if I need to use bugzilla >> for that? >> In attach the patch. >> >> file: net/common/current/src/dhcp_prot.c >> >> According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The >> DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message." >> So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same >> transaction ID should be used ('xid' in C code). >> We never had problems with that, but now we have a strict customer.. >> >> Kind regards, >> Jürgen >> >> -- >> Jürgen Lambrecht >> R&D Associate >> Mobile: +32 499 644 531 >> Tel: +32 (0)51 303045 Fax: +32 (0)51 310670 >> http://www.televic-rail.com >> Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium >> Company number 0825.539.581 - RPR Kortrijk >> >>