From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28652 invoked by alias); 8 Jun 2010 12:14:29 -0000 Received: (qmail 28636 invoked by uid 22791); 8 Jun 2010 12:14:28 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.stmi.com (HELO mail.stmi.com) (70.169.254.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Jun 2010 12:14:23 +0000 X-Ninja-PIM: Scanned by Ninja X-Ninja-AttachmentFiltering: (no action) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: PHY update Date: Tue, 08 Jun 2010 12:14:00 -0000 Message-ID: In-Reply-To: <4C0E2336.5010003@dallaway.org.uk> References: <4BEA8135.6040402@dallaway.org.uk> <4C0E2336.5010003@dallaway.org.uk> From: "Christophe Coutand" To: "John Dallaway" , "Sachin Sushil Chaddha" , "Edgar Grimberg" Cc: , X-IsSubscribed: yes Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-06/txt/msg00008.txt.bz2 Hi John, The reason for having external definitions was to keep all registers definition in the same place. Some HW may have to configure special PHY registers (to adjust clock delay etc..) to be able to work properly. This work is left to the user since it is HW specific. Currently no package rely on these header files. Let me know what you prefer and I can submit a new patch. Regards, Christophe =20 -----Original Message----- From: John Dallaway [mailto:john@dallaway.org.uk]=20 Sent: 8. juni 2010 13:02 To: Sachin Sushil Chaddha; Christophe Coutand; Edgar Grimberg Cc: ecos-patches@ecos.sourceware.org; chadhas@ymail.com Subject: Re: PHY update Hi Sachin, Chrristophe and Edgar Sachin Sushil Chaddha wrote: > I have received my Copyright Assignment form, which is attached for your > reference. That's great. Thank you. > Christophe Coutand wrote: >=20 >> Attached are some new PHY support to HAL. Vitesse VSC8244 is part of a >> port to Freescale 8572 evaluation board. Rest of the HAL for this >> processor will follow. >> >> Let me know if the patch is correctly generated. IP101A is submitted on >> behalf of Edgar Grimberg @ Zylin.com and VSC864 is submitted on behalf >> of Sachin Sushil Chaddha @ stmi.com Is there a reason why you have placed the PHY register definitions into an external header file? Might they be required by other eCos packages? If there _is_ a good reason, then we should add the standard copyright banner to these header files and adhere to eCos file naming conventions. Otherwise, I would suggest placing these definitions in the relevant .c source files directly similar to the support for other PHY parts (INLXT972.c and KSZ8041.c for example). John Dallaway eCos maintainer