Re: Update to CYGPKG_IO_ADC

[Sergei Gavrikov <sergei.gavrikov@gmail.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1254 bytes --]

On Sat, 22 May 2010, Christophe Coutand wrote:
> Added option to flush the ADC sample buffer.
>
> Christophe

Hi Christophe,

First, thank you for your contribution! Some things so far (first look
on both patches)

1) I could not compile the driver, if cdl_option
CYGPKG_DEVS_ADC_ARM_AT91_DEBUG_LEVEL != 0: (test target to build the
driver was sam7ex256):

ecos/packages/devs/adc/arm/at91/current/src/adc_at91.c: In function Β‘at91_adc_enableΒ’:
ecos/packages/devs/adc/arm/at91/current/src/adc_at91.c:342: error: Β‘at91_adc_infoΒ’ has no member named Β‘zero_timeΒ’

Could you fix this, please?

2) Minor

Could you please, clean-up the first patch (src), i.e. remove CRs, expand
TABs, fix some indents there; format (wrap on) a few long lines in CDL.

It seemed for me those direct requirements of a range ([10; 12]) for
CYGNUM_IO_ADC_SAMPLE_SIZE on top your CDL can be placed in a separate
CDL component.

About new I/O key for config_key.h (your second patch), I would prefer
rename your CYG_IO_SET_CONFIG_ADC_FLUSH_DATABUF, because all *flush* key
names end itself on _FLUSH. What would you say about:
CYG_IO_SET_CONFIG_ADC_DATA_FLUSH?

Note: In the next patches do not diff ecos.db, please. Send new
db-entries as a separate file.

Thank you,
Sergei