From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1841 invoked by alias); 25 May 2010 20:21:04 -0000 Received: (qmail 1713 invoked by uid 22791); 25 May 2010 20:20:49 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_BL_SPAMCOP_NET X-Spam-Check-By: sourceware.org Received: from mail-fx0-f49.google.com (HELO mail-fx0-f49.google.com) (209.85.161.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 May 2010 20:20:44 +0000 Received: by fxm15 with SMTP id 15so3931265fxm.36 for ; Tue, 25 May 2010 13:20:39 -0700 (PDT) Received: by 10.204.73.149 with SMTP id q21mr3058401bkj.57.1274818839139; Tue, 25 May 2010 13:20:39 -0700 (PDT) Received: from 93.85.55.209.belpak.gomel.by ([93.85.55.209]) by mx.google.com with ESMTPS id q36sm2900219bkf.10.2010.05.25.13.20.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 25 May 2010 13:20:38 -0700 (PDT) Date: Tue, 25 May 2010 20:21:00 -0000 From: Sergei Gavrikov To: Christophe Coutand cc: eCos Patches Subject: RE: Update to CYGPKG_IO_ADC In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-2021223034-1274818838=:12280" X-IsSubscribed: yes Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-05/txt/msg00039.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2021223034-1274818838=:12280 Content-Type: TEXT/PLAIN; charset=iso-8859-7; format=flowed Content-Transfer-Encoding: 8BIT Content-length: 3242 On Tue, 25 May 2010, Christophe Coutand wrote: > Hi Sergei, > > I have generated a new patch using CYG_IO_SET_CONFIG_ADC_DATA_FLUSH > instead. Hi Christophe, Thank you, I will take a look. > The second patch is pending. I have fixed the compilation error due to > CYGPKG_DEVS_ADC_ARM_AT91_DEBUG_LEVEL == 0, remove the CRs and cleanup > the CDL file. Okay, no issue. > I am however not sure what you mean by placing > CYGNUM_IO_ADC_SAMPLE_SIZE inside a CDL component. > CYGNUM_IO_ADC_SAMPLE_SIZE is defined from the IO/ADC package, am I > allowed to redefine it inside a CDL component in the DEVS/ADC? There are 2 lines on top-level the package: requires {CYGNUM_IO_ADC_SAMPLE_SIZE <= 12} requires {CYGNUM_IO_ADC_SAMPLE_SIZE >= 10} And I had a thought about some CDL wrapping the limit, e.g. cdl_component CYGSEM_DEVS_ADC_ARM_AT91_SAMPLE_SIZE_LIMIT { display "Sample size limit" flavor bool calculated 1 requires {CYGNUM_IO_ADC_SAMPLE_SIZE >= 10} requires {CYGNUM_IO_ADC_SAMPLE_SIZE <= 12} description " Tell user about the limitation." } > Also I never use tabulation so if you can pin-point where you have > find one, I will investigate. I believe that you don't, but your $EDITOR does. I attach those lines if you ask. It exists many ways to catch TABs/CRs, the simplest CLI way (on Linux I think): grep '[press ^V][press TAB]' input ;# to catch TABs grep '[press ^V][press RETURN]' input ;# to catch CRs Sometimes you can see in a pager [more|less] a wrong indenting lines (my editor can highlight TABS too if I want). Regards, Sergei > Regards, > Christophe > > -----Original Message----- > From: Sergei Gavrikov [mailto:sergei.gavrikov@gmail.com] > Sent: 25. mai 2010 12:50 > To: Christophe Coutand > Cc: ecos-patches@ecos.sourceware.org > Subject: Re: Update to CYGPKG_IO_ADC > > On Sat, 22 May 2010, Christophe Coutand wrote: >> Added option to flush the ADC sample buffer. >> >> Christophe > > Hi Christophe, > > First, thank you for your contribution! Some things so far (first look > on both patches) > > 1) I could not compile the driver, if cdl_option > CYGPKG_DEVS_ADC_ARM_AT91_DEBUG_LEVEL != 0: (test target to build the > driver was sam7ex256): > > ecos/packages/devs/adc/arm/at91/current/src/adc_at91.c: In function ¡at91_adc_enable¢: > ecos/packages/devs/adc/arm/at91/current/src/adc_at91.c:342: error: ¡at91_adc_info¢ has no member named ¡zero_time¢ > > Could you fix this, please? > > 2) Minor > > Could you please, clean-up the first patch (src), i.e. remove CRs, expand > TABs, fix some indents there; format (wrap on) a few long lines in CDL. > > It seemed for me those direct requirements of a range ([10; 12]) for > CYGNUM_IO_ADC_SAMPLE_SIZE on top your CDL can be placed in a separate > CDL component. > > About new I/O key for config_key.h (your second patch), I would prefer > rename your CYG_IO_SET_CONFIG_ADC_FLUSH_DATABUF, because all *flush* key > names end itself on _FLUSH. What would you say about: > CYG_IO_SET_CONFIG_ADC_DATA_FLUSH? > > Note: In the next patches do not diff ecos.db, please. Send new > db-entries as a separate file. > > Thank you, > Sergei > --8323329-2021223034-1274818838=:12280 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=lines_with_tabs.cut Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: tabs Content-Disposition: attachment; filename=lines_with_tabs.cut Content-length: 1420 KyAgICBjeWdfdWludDggICAgICAgICAgICAgICB0aW1lcl9jbGs7CSAgICAg ICAvLyBUaW1lciBjbG9jayBzZXR0aW5nDQ0KKyAgICAJCSAgKChBVDkxX1BN Q19QQ0VSX1RDMCkgPDwgQ1lHTlVNX0RFVlNfQURDX0FSTV9BVDkxX1NFTEVD VF9USU1FUikpOw0NCisJICAgCSAgICAoICggQ1lHTlVNX0RFVlNfQURDX0FS TV9BVDkxX1BSRVNDQUwgPDwgQVQ5MV9BRENfTVJfUFJFU0NBTF9TSElGVCAp ICYgXA0NCisJICAgCSAgICAJCUFUOTFfQURDX01SX1BSRVNDQUxfTUFTSyAp IHwgXA0NCisJICAgCSAgICAoICggQ1lHTlVNX0RFVlNfQURDX0FSTV9BVDkx X1NUQVJUVVBfVElNRSAgPDwgQVQ5MV9BRENfTVJfU1RBUlRVUF9TSElGVCAp ICYgXA0NCisJICAgCQkgICAJICAgIEFUOTFfQURDX01SX1NUQVJUVVBfTUFT SyApIHwgXA0NCisJICAgCSAgICAoICggQ1lHTlVNX0RFVlNfQURDX0FSTV9B VDkxX1NIVElNIDw8IEFUOTFfQURDX01SX1NIVElNX1NISUZUICkgJiBcDQ0K KwkgICAJCSAgIAkJQVQ5MV9BRENfTVJfU0hUSU1fTUFTSyApIHwgXA0NCisJ ICAgCSAgICBBVDkxX0FEQ19NUl9UUkdTRUxfVElPQTAgIHwgXA0NCisJICAg CSAgICBpbmZvLT5yZXNvbHV0aW9uKTsNDQorICAgIAl0bXJfcGVyaW9kID0g Q1lHTlVNX0hBTF9BUk1fQVQ5MV9DTE9DS19TUEVFRCAvICggcmF0ZSA8PCA1 KTsNDQorICAgIAl0bXJfcGVyaW9kID0gQ1lHTlVNX0hBTF9BUk1fQVQ5MV9D TE9DS19TUEVFRCAvICggcmF0ZSA8PCA3KTsNDQorICAgIAl0aW1lcl9jbGsg ID0gQVQ5MV9UQ19DTVJfQ0xLU19NQ0sxMjg7DQ0KKyAgICAJdG1yX3Blcmlv ZCA9IENZR05VTV9IQUxfQVJNX0FUOTFfQ0xPQ0tfU1BFRUQgLyAoIHJhdGUg PDwgMTApOw0NCisgICAgCXRpbWVyX2NsayAgPSBBVDkxX1RDX0NNUl9DTEtT X01DSzEwMjQ7DQ0KKyAgICAJdG1yX3BlcmlvZCA9IDB4ZmZmZjsNDQorICAg IAl0aW1lcl9jbGsgID0gQVQ5MV9UQ19DTVJfQ0xLU19NQ0sxMDI0Ow0NCisg ICAgCWF0OTFfYWRjX3ByaW50ZigiQVQ5MSBBREMgdGltZXIsIHJhdGUgdG9v IGhpZ2ghIik7DQ0K --8323329-2021223034-1274818838=:12280--