public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sergei Gavrikov <sergei.gavrikov@gmail.com>
To: Christophe Coutand <ccoutand@stmi.com>
Cc: eCos Patches <ecos-patches@ecos.sourceware.org>
Subject: RE: Update to CYGPKG_IO_ADC
Date: Wed, 26 May 2010 07:20:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1005260953440.644@sg-desktop.local> (raw)
In-Reply-To: <D6050C555CC56940A7AF32652283027602EAC5A4@mail2.STMIRV01.COM>

On Tue, 25 May 2010, Christophe Coutand wrote:
> On Tue, 25 May 2010, Sergei Gavrikov wrote:
> Hi Sergei,
>
> Thanks for your inputs. Attached is the updated patch. Let me know if
> more changes are required.
>
> Christophe

Hi Christophe,

I retested this one. The compiler's error went away, thank you. And now
your patch looks great for me.

[snip]

> And I had a thought about some CDL wrapping the limit, e.g.
>
>     cdl_component CYGSEM_DEVS_ADC_ARM_AT91_SAMPLE_SIZE_LIMIT {
>         display       "Sample size limit"
>         flavor        bool
>         calculated    1
>         requires      {CYGNUM_IO_ADC_SAMPLE_SIZE >= 10}
>         requires      {CYGNUM_IO_ADC_SAMPLE_SIZE <= 12}
>         description   "
>             Tell user about the limitation."
>     }

[snip]

The last thing. When I typed in an example above "Tell user about..." I
thought that you put there (in description) some paraphrase from AT91
datasheet and there is almost mine in CDL :-) Well, you can sent me just
a few descriptive sentences. As you understand it will be then displayed
in `configtool` (the component's description). I will fix it.

Thanks,
Sergei

  reply	other threads:[~2010-05-26  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22  9:43 Christophe Coutand
2010-05-25 10:51 ` Sergei Gavrikov
2010-05-25 19:06   ` Christophe Coutand
2010-05-25 20:21     ` Sergei Gavrikov
2010-05-25 21:32       ` Christophe Coutand
2010-05-26  7:20         ` Sergei Gavrikov [this message]
2010-05-26  6:53       ` Sergei Gavrikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1005260953440.644@sg-desktop.local \
    --to=sergei.gavrikov@gmail.com \
    --cc=ccoutand@stmi.com \
    --cc=ecos-patches@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).