From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9605 invoked by alias); 26 May 2010 07:20:57 -0000 Received: (qmail 9593 invoked by uid 22791); 26 May 2010 07:20:56 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 May 2010 07:20:52 +0000 Received: by fg-out-1718.google.com with SMTP id e12so565505fga.12 for ; Wed, 26 May 2010 00:20:49 -0700 (PDT) Received: by 10.87.58.22 with SMTP id l22mr12087789fgk.56.1274858448950; Wed, 26 May 2010 00:20:48 -0700 (PDT) Received: from sg-desktop.local ([86.57.137.251]) by mx.google.com with ESMTPS id 19sm8692445fkr.9.2010.05.26.00.20.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 May 2010 00:20:48 -0700 (PDT) Date: Wed, 26 May 2010 07:20:00 -0000 From: Sergei Gavrikov To: Christophe Coutand cc: eCos Patches Subject: RE: Update to CYGPKG_IO_ADC In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-05/txt/msg00042.txt.bz2 On Tue, 25 May 2010, Christophe Coutand wrote: > On Tue, 25 May 2010, Sergei Gavrikov wrote: > Hi Sergei, > > Thanks for your inputs. Attached is the updated patch. Let me know if > more changes are required. > > Christophe Hi Christophe, I retested this one. The compiler's error went away, thank you. And now your patch looks great for me. [snip] > And I had a thought about some CDL wrapping the limit, e.g. > > cdl_component CYGSEM_DEVS_ADC_ARM_AT91_SAMPLE_SIZE_LIMIT { > display "Sample size limit" > flavor bool > calculated 1 > requires {CYGNUM_IO_ADC_SAMPLE_SIZE >= 10} > requires {CYGNUM_IO_ADC_SAMPLE_SIZE <= 12} > description " > Tell user about the limitation." > } [snip] The last thing. When I typed in an example above "Tell user about..." I thought that you put there (in description) some paraphrase from AT91 datasheet and there is almost mine in CDL :-) Well, you can sent me just a few descriptive sentences. As you understand it will be then displayed in `configtool` (the component's description). I will fix it. Thanks, Sergei