From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17377 invoked by alias); 27 May 2010 21:44:09 -0000 Received: (qmail 17360 invoked by uid 22791); 27 May 2010 21:44:09 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-wy0-f177.google.com (HELO mail-wy0-f177.google.com) (74.125.82.177) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 May 2010 21:44:03 +0000 Received: by wyb33 with SMTP id 33so393406wyb.36 for ; Thu, 27 May 2010 14:44:01 -0700 (PDT) Received: by 10.227.137.21 with SMTP id u21mr10485399wbt.68.1274996640895; Thu, 27 May 2010 14:44:00 -0700 (PDT) Received: from 93.84.55.228.belpak.gomel.by ([93.84.55.228]) by mx.google.com with ESMTPS id h22sm5320586wbh.21.2010.05.27.14.43.59 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 27 May 2010 14:44:00 -0700 (PDT) Date: Thu, 27 May 2010 21:44:00 -0000 From: Sergei Gavrikov To: Christophe Coutand cc: John Dallaway , eCos Patches Subject: RE: AT91 ADC support In-Reply-To: Message-ID: References: <4BFE76A4.1010702@dallaway.org.uk> <4BFE860D.3060702@dallaway.org.uk> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-05/txt/msg00053.txt.bz2 On Thu, 27 May 2010, Christophe Coutand wrote: > Hi Sergei, > > I have attached an updated var_io.h that includes ADC support for the > AT91M55800A. I took the opportunity to define the number of channels > per ADC in this file. It can be overwritten per platform basis since > AT91SAM7L64 for instance has 4 channels only. Hi Christophe, Thanks for your time. I will take a look this morning. > The definition of AT91_MAX_ADC_CHAN must be removed from > devs/adc/arm/at91/current/src/adc_at91.c. I have not joined any patch > for it since I will hopefully submit a new driver that support both > ADCs. Excellent! I did want to ask you about and it seems fetchamil is retrieving it just now. Sergei > Christophe > > -----Original Message----- > From: Sergei Gavrikov [mailto:sergei.gavrikov@gmail.com] > Sent: 27. mai 2010 18:38 > To: Christophe Coutand > Cc: John Dallaway; eCos Patches > Subject: RE: AT91 ADC support > > On Thu, 27 May 2010, Christophe Coutand wrote: >> Hi John, >> >> It's pretty easy to add the required definition for the AT91M55800A >> targets. The only thing I see now is that this device contains 2 ADCs >> which I have not considered before. I guess there are several ways out >> of this: >> >> 1- Update the actual AT91 ADC driver to make full use of the >> AT91M55800A targets. I guess should be done by loading a second ADC >> instance (one for each ADC. I have not been through all the thinking >> here...). >> >> 2- or limit the AT91 driver to use only ADC0 of the AT91M55800A target >> for the time being. >> >> 3- or exclude AT91M55800A targets for the time being. >> >> IMO #1 is best but I cannot give any time frame for completing it. > > Hi Christophe, John > > I would prefer #1, if you want I can add that in AT91/ADC CDL/sources. > One thing: I won't be able to test it on real hardware (only build > process can be tested me). > > John, what do you think: Can we add the second ADC instance without a > testing? > >> One additional weakness of the driver is that it is made for up to 8 >> channels. It is defined nowhere what the targeted CPU can actually >> handle, this is left to the user when configuring eCos. I believe this >> is pretty fine since the user must anyway know which signal he wants > to >> sample but you might disagree on that one. > > I know only one target which would use all 8 channels :-) That's eCos > i386/Linux synthetic target. > > Thanks for collaboration. > > Sergei > >> Regards, >> Christophe >