From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 399 invoked by alias); 22 Jan 2014 07:46:31 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 381 invoked by uid 89); 22 Jan 2014 07:46:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail.ecoscentric.com Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 22 Jan 2014 07:46:26 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id D1CF94680009 for ; Wed, 22 Jan 2014 07:46:22 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qzELAzL91f24; Wed, 22 Jan 2014 07:46:14 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001656] FreeBSD: add AF_PACKET socket familiy Date: Wed, 22 Jan 2014 07:46:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: bernd.edlinger@hotmail.de X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: high X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-01/txt/msg00003.txt.bz2 Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001656 --- Comment #16 from Bernd Edlinger --- (In reply to comment #15) > First, thanks for taking the time to find/fix all these bugs. > > I'd like to start working on getting these committed. After a > preliminary look through the patches I have a few suggestions on how > to more quickly get things committed. > > The patches contain hundreds diffs where nothing has changed but > whitespace (usually at the end of the line): > OK, separating the white-space changes is easy I will do that. > Splitting the changes up into smaller patches would also make it much > easier. A separate patch for the AF_PACKET support and for each of > the 10 bugs you listed would be ideal. That way somebody reviewing > the code doesn't have to try to figure out which bug a particular > change is addressing. It also means that the work of reviewing and > committing the changes can be divided up among multiple maintainers. > Well, maybe I should start with writing a change-log. I am not sure how to test each part of that patch separately. But I will try to isolate obviously independent parts and separate that where possible. > Next is the question of copyright assignment. I'm not sure where the > threshold is for "trivial" changes above which a copyright assignment > is needed, and hopefully some other maintainers to comment on > that. There's probably a good chance that for a contribution this > large a copyright assignment will be needed. > The copyright-assignment was signed by my company (softing.com) on 2012-10-25 and counter-signed by FSF on 2012-12-17 Bernd. > -- > Grant -- You are receiving this mail because: You are on the CC list for the bug.