[Bug 1001752] New: fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[Bug 1001752] New: fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

            Bug ID: 1001752
           Summary: fixed endianness issues with Freescale eDMA and DSPI
                    driver to also support PowerPC MPC5xxx in addition to
                    Kinetis
           Product: eCos
           Version: unknown
          Hardware: All
  Architecture/Host All
                OS:
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
          Assignee: unassigned@bugs.ecos.sourceware.org
          Reporter: Stefan.Singer@freescale.com
                CC: ecos-patches@ecos.sourceware.org

Created attachment 2056
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2056&action=edit
eDMA patches

The drivers developed for Kinetis did only support ARM little endian. Small
changes are required to also support PowerPC Big endian.
First attachement are the patches to the eDMA
second attachement are the patches to the DSPI

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #1 from Stefan Singer <Stefan.Singer@freescale.com> ---
Created attachment 2057
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2057&action=edit
patches for the DSPI

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Stefan Singer <Stefan.Singer@freescale.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|low                         |normal

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |ilijak@siva.com.mk
           Assignee|unassigned@bugs.ecos.source |ilijak@siva.com.mk
                   |ware.org                    |
     Ever confirmed|0                           |1

--- Comment #2 from Ilija Kocho <ilijak@siva.com.mk> ---
Hi Stefan

Thank you for the contribution.
I will test the patches with Kinetis for backward compatibility and come back.

Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> ---
Created attachment 2064
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2064&action=edit
eDMA priority endian fix. Incremental patch to 2056

Stefan

I have testede and it works on Kinetis. However, there is another endian issues
- eDMA channel priorities. The attached patch should fix it for bug endian.
Please test.
Note the patch is incremental to attachment 2056.

In addition to testing the submitted patches please update the ChangeLogs for
both eDMA and DSPI packages and check for proper formatting (trailing
whitespace, line length, etc.)

Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #4 from Ilija Kocho <ilijak@siva.com.mk> ---
Created attachment 2065
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2065&action=edit
Some auxiliary macros for DSPI instantiation. Incremental to 2057.

Stefan

The bus instances 3 to 8 were missing (but you might have added them somewhere
else). In order to facilitate addition of new instances I created some aux
macros. Then I took the liberty to add new DSPI instances.
Please test.

Note: The patch is incrementat to attachment 2057.

Upon testing please update ChangeLog and copyright banners and submit integral
patches vs current CVS.

Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #5 from Stefan Singer <Stefan.Singer@freescale.com> ---
Created attachment 2072
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2072&action=edit
updated changelog for eDMA, incremental patch

attached the updated changelog for the eDMA

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #6 from Stefan Singer <Stefan.Singer@freescale.com> ---
Created attachment 2073
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2073&action=edit
changelog patch for DSPI

updates changelog for the DSPI driver

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #7 from Stefan Singer <Stefan.Singer@freescale.com> ---
Hi Ilija,
I have tested your additions and they seem to work on MPC5668G. I have updated
the changelog for the two modules and took the liberty to add both of us as
authors for that. Regarding the cleanup of formating I guess I must have some
strange setting in Eclipse, since it looks fine on my end, but I have heard
before, that files from my side might have some issues here. Unfortunately I do
not know, how to correct this.

Thanks
Stefan

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> ---
Hi Stefan

I take it STS stands for Stefan Singer. However it would be better to put
complete name in ChangeLog. Your e-mail address would indicate that this is
Freescale contribution which is important because we have Freescale's copyright
assignment.

Also the attachment for "DSPI ChaneLog" seem to contain wrong file :).

If it doesn't make harder for you, it would make easier for me if you post
integral patches against current CVS.

I can take care about formatting.

Ilija

(In reply to comment #7)
> Hi Ilija,
> I have tested your additions and they seem to work on MPC5668G. I have
> updated the changelog for the two modules and took the liberty to add both
> of us as authors for that. Regarding the cleanup of formating I guess I must
> have some strange setting in Eclipse, since it looks fine on my end, but I
> have heard before, that files from my side might have some issues here.
> Unfortunately I do not know, how to correct this.
> 
> Thanks
> Stefan

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #9 from Stefan Singer <Stefan.Singer@freescale.com> ---
Hi Ilija,
please find attached updated cummulative patches for eDMA and DSPI. I have also
updated the changelogs to include my full name with email address.

Best regards
Stefan

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Stefan Singer <Stefan.Singer@freescale.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2057|0                           |1
        is obsolete|                            |
   Attachment #2073|0                           |1
        is obsolete|                            |

--- Comment #10 from Stefan Singer <Stefan.Singer@freescale.com> ---
Created attachment 2086
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2086&action=edit
cummulative DSPI patches

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Stefan Singer <Stefan.Singer@freescale.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2056|0                           |1
        is obsolete|                            |
   Attachment #2072|0                           |1
        is obsolete|                            |

--- Comment #11 from Stefan Singer <Stefan.Singer@freescale.com> ---
Created attachment 2087
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2087&action=edit
cummulative eDMA patches

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2064|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2065|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #12 from Ilija Kocho <ilijak@siva.com.mk> ---
Created attachment 2091
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2091&action=edit
Force inlining of some eDMA header functions

Stefan

This is a small patch that synchronizes eDMA with bug 1001759 (checked in
yesterday). Can you please test if it works for you? If it works without
further modifications there is no need to submit cumulative patch.

Note: The purpose of this patch is to enable compilation of eDMA with
optimization level -O0 (though the build or runtime might be obstructed with
low memory on single chip configurations).

For simple test it is enough to test with default compiler flags (i.e. -O2),
but it would be better if you try it with both -O2 and -O0.

Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

--- Comment #13 from Ilija Kocho <ilijak@siva.com.mk> ---
(In reply to comment #12)
> Created attachment 2091 [details]
> Force inlining of some eDMA header functions
> 
> Stefan
> 
> This is a small patch that synchronizes eDMA with bug 1001759 (checked in
> yesterday). Can you please test if it works for you? If it works without
> further modifications there is no need to submit cumulative patch.

I forgot to mention (for the record), you need to update eCos to latest CVS
prior to patching. The patch is inremental to attachment 2087.

> 
> Note: The purpose of this patch is to enable compilation of eDMA with
> optimization level -O0 (though the build or runtime might be obstructed with
> low memory on single chip configurations).
> 
> For simple test it is enough to test with default compiler flags (i.e. -O2),
> but it would be better if you try it with both -O2 and -O0.
> 
> Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |CURRENTRELEASE

--- Comment #14 from Ilija Kocho <ilijak@siva.com.mk> ---
Checked in.
Thanks to Freescale and Stefan Singer for the contribution.
Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001752] fixed endianness issues with Freescale eDMA and DSPI driver to also support PowerPC MPC5xxx in addition to Kinetis

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001752

Ilija Kocho [Илија Кочо] <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are on the CC list for the bug.