[Bug 1001845] New: Add CAN support for Olimex olpce2294 board

[Bug 1001845] New: Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

            Bug ID: 1001845
           Summary: Add CAN support for Olimex olpce2294 board
           Product: eCos
           Version: CVS
            Target: Other (please specify)
  Architecture/Host HostOS: Win XP/7
                OS:
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
          Assignee: unassigned@bugs.ecos.sourceware.org
          Reporter: uwe_kindler@web.de
                CC: ecos-patches@ecos.sourceware.org

Created attachment 2230
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2230&action=edit
olpce2294 CAN support patch

The attached patch adds CAN support to Olimex olpce2294 board

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2230|0                           |1
        is obsolete|                            |

--- Comment #1 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Created attachment 2231
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2231&action=edit
declare implementation the CAN interfaces for olpce2294 target

Cleaned-up version the attachment 2230 (chomp CRs, minor edits the ChangeLog
entries).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Uwe, thank you for issuing this. I have tried to test your patch and as I could
see the macro HAL_LPC2XXX_GET_CAN_BR() is not provided for olpce2294 target:

SYNOPSIS

  ecosconfig new olpce2294
  ecosconfig add can
  ecosconfig tree
  make -s
  headers finished
  ... can_lpc2xxx.c:85:2: error: #error "Macro HAL_LPC2XXX_GET_CAN_BR()
missing"
  ... can_lpc2xxx.c: In function 'lpc2xxx_can_set_baud':

Could you, please, also define the missing macro for the target? However, I
could miss some configure options, if it so, please, tell me how you configure
and build the CAN driver for olpce2294 target?

Thank you,
Sergei

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

--- Comment #3 from Uwe Kindler <uwe_kindler@web.de> ---
Hi Sergei,

you need to build the library with a processor clock that is supported in
can_lpc2xxx_baudrates.h. So you can try a clock of 60Mhz - this is the clock I
used for building (CYGNUM_HAL_ARM_LPC2XXX_XTAL_FREQ 15000000)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
(In reply to comment #3)
> Hi Sergei,
> 
> you need to build the library with a processor clock that is supported in
> can_lpc2xxx_baudrates.h. So you can try a clock of 60Mhz - this is the clock
> I used for building (CYGNUM_HAL_ARM_LPC2XXX_XTAL_FREQ 15000000)

Hi Uwe,

I know this "trick" (I thought that you sent not all diff and you have more
changes under devs/can/arm/lpc2xxx). Thus, user has to replace 14.7456 MHz
oscillator on the board. I recall that such a "repairing" is not issue (the
original oscillator is set on a socket and can be replaced by new one with no
soldering). Well, if nobody has no objections I would apply your patch.

Thanks,
Sergei

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

--- Comment #5 from Uwe Kindler <uwe_kindler@web.de> ---
Hi Sergei,

i will provide a second patch with a baudrate table for the default clock
later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Now in CVS. Thanks for contributing to eCos!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001845] Add CAN support for Olimex olpce2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001845

--- Comment #7 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
(In reply to comment #5)
> i will provide a second patch with a baudrate table for the default clock
> later.

Good to know, thank you! Then I do not change the bug's status.

-- 
You are receiving this mail because:
You are on the CC list for the bug.