From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27587 invoked by alias); 5 Jun 2013 21:24:39 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 27568 invoked by uid 89); 5 Jun 2013 21:24:39 -0000 X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 05 Jun 2013 21:24:38 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id AE2FD468000F for ; Wed, 5 Jun 2013 22:24:36 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aFx5lmKNYAqV; Wed, 5 Jun 2013 22:24:32 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001858] CAN driver return code patch Date: Wed, 05 Jun 2013 21:24:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-06/txt/msg00010.txt.bz2 Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858 --- Comment #2 from Sergei Gavrikov --- (In reply to comment #0) ... > The function shall return -ENOSPC to indicate that there are no filters > available. At the moment the only implementation that uses these keys > (LPC2xxx CAN driver) returns -EPERM. But -EPERM is also returned if it is > not possible to configure filters because message filterings is deactivated > (CYGNUM_CAN_MSGBUF_RX_FILTER_ALL). So with the new return code it is > possible for the application to identify the exact reason why message filter > configuration failed. I share your view. Thanks for the patch. FYI: there were 2 jade errors on VARNAME usage: ... document type does not allow element "VARNAME" here; missing one of "COMMENT", "SYNOPSIS", "LITERALLAYOUT", "PROGRAMLISTING", "SCREEN", "PARA", "SIMPARA", "BRIDGEHEAD" start-tag So, I put your doc-strings in separate PARA blocks (see attachment #2249). If no one has any objections I plan to commit the changes. -- You are receiving this mail because: You are on the CC list for the bug.