From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31592 invoked by alias); 3 Sep 2013 06:18:32 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 31580 invoked by uid 89); 3 Sep 2013 06:18:31 -0000 Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Sep 2013 06:18:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.2 X-HELO: mail.ecoscentric.com Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 1178C468000E for ; Tue, 3 Sep 2013 07:18:27 +0100 (BST) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83OoR+Xc64Kx; Tue, 3 Sep 2013 07:18:22 +0100 (BST) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001897] lpc2xxx CAN driver improvements / enhancements Date: Tue, 03 Sep 2013 06:18:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: uwe_kindler@web.de X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-09/txt/msg00002.txt.bz2 Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001897 --- Comment #5 from Uwe Kindler --- > SYNOPSIS > > http://www.nxp.com/documents/application_note/AN10674.pdf | Fig. 14 > > May we presume that description from AN is not true for some LPC2294 > revisions? It seems so. I only have one single LPC2294 here and it definitely don't works like written on page 16 of the application note. The RM bit is not set, so controller dont't go into reset mode and also the TX RX counters are not changed. I would not have put so much time into this patch if the CAN controller would have worked the way it should. > Perhaps, http://www.nxp.com/documents/errata_sheet/2294.pdf > See CAN.5 (pp. 11,12) "Normal operation cannot be resumed after reset". > May we presume that they did not raise "Reset Mode" for "Bus Off" error > as an early "workaround"? Though, I found no such reassurances on Net. I think CAN.5 has nothing to do with the problem I see - this is something different. > > On the other hand the driver uses lpc2xxx_enter_reset_mode() in a few > places without (?) issue. Manually entering reset mode via lpc2xxx_enter_reset_mode() is not a problem. The problem is, that the controller does not automatically enters reset mode in case of a bus off condition (bus error). lpc2xxx_enter_reset_mode() works fine and controller properly enters reset mode. > Uwe, did you noticed any strange behaviors > after this call? If you did not, then my guess is wrong. And if CAN.5 > issue can be the reason then we can use your workaround by a condition > is set according some CDL option. Sorry, I cannot help in testing any > more due lack a CAN adapter. Ok. Shall I change the patch and make the code conditional via a CDL option? That would be o.k. for me as long as no one confirmed that this problem exists for other LPCxxxx devices? -- You are receiving this mail because: You are on the CC list for the bug.