From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21976 invoked by alias); 28 Jan 2014 01:46:01 -0000 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org Received: (qmail 21947 invoked by uid 89); 28 Jan 2014 01:46:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.4 required=5.0 tests=AWL,BAYES_00,BODY_8BITS,GARBLED_BODY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail.ecoscentric.com Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 28 Jan 2014 01:45:59 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id B376B4680014 for ; Tue, 28 Jan 2014 01:45:55 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9VKtiuQqUSrN; Tue, 28 Jan 2014 01:45:48 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001933] New HAL for the M4 core of Freescale Vybrid targets Date: Tue, 28 Jan 2014 01:46:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: ilijak@siva.com.mk X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: dependson Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-01/txt/msg00007.txt.bz2 Please do not reply to this email, use the link below. http://bugs.ecos.sourceware.org/show_bug.cgi?id=3D1001933 Ilija Kocho [=D0=98=D0=BB=D0=B8=D1=98=D0=B0 =D0=9A=D0=BE=D1=87=D0=BE] changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1001397 --- Comment #4 from Ilija Kocho [=D0=98=D0=BB=D0=B8=D1=98=D0=B0 =D0=9A=D0= =BE=D1=87=D0=BE] --- Stefan / Jochen Thank you for your contribution. It would be nice to have Vybrid in our repository. I applied your patches to current eCos CVS and got some warnings and confli= cts: - Wallclock seems to be missing. - Some conflicts pointing to I2C and SPI drivers. It seems that your ear= lier patch Attachment 2350 from BUG 1001397 fixes I2C conflicts. Question - Is Attachment 2350 up to date or yiu have newer I2C driver version? - What about SPI? There should be some patch. - What about drivers that show no conflicts: UART, ENET, eDMA, etc? I wou= ld be very happy and proud if they work with Vybrid unmodified but it seeem too good to be true. Looking the code: - There are a lot of "reg*.h" files in HAL include directory. Devices in eCos are decoupled from HAL in order to enable usage of device drivers with different architectures. I know that this philosophy is not perfectly implemented, but I aim to do best for new packages. It is especially benefit for Freescale's chips that re-use peripherals on different architectures. - Also there are some type-case problems Vybrid_irq_scheme vs vybrid_irq_scheme that may work under windows but cause errors on case sensitive Linux - I'm glad to see SGML docs, but they seem incomplete and their compilati= on raises errors. The attached diff contains modifications that I did against current CVS. Th= is removes conflicts but there are still compilation errors. Summary: -Please prepare new patches that shall work against current CVS. Also pro= vide patches to device drivers where needed. It would be good to split variant a= nf platform patches in separate files. - Also for devices - separate patches. - Update year in copyright messages (2013 or 2014). - Cross-check SGML docs. - Remove "reg*.h" headers. - I have noticed CDL for Compiler selection. It is unnecessary because user can specify compiler prefix and flags in "Global Build Options". Please rem= ove it. Ilija --=20 You are receiving this mail because: You are on the CC list for the bug.