[Bug 1001949] New: ConfigTool - Patch to resolve 'set but usused' variable warnings

[Bug 1001949] New: ConfigTool - Patch to resolve 'set but usused' variable warnings

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001949

            Bug ID: 1001949
           Summary: ConfigTool - Patch to resolve 'set but usused'
                    variable warnings
           Product: eCos
           Version: CVS
            Target: All
  Architecture/Host HostOS: Win XP/7
                OS:
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
          Assignee: unassigned@bugs.ecos.sourceware.org
          Reporter: andy@xylanta.com
                CC: ecos-patches@ecos.sourceware.org

Created attachment 2460
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2460&action=edit
Patch to resolve 'set but usused' variable warnings

This patch resolves a number of  'set but usused' variable warnings when
ConfigTool is built using gcc 4.8 and -Wall. Tested on Windows but should apply
to all platforms.


This follows on from the patch in 1001948.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001949] ConfigTool - Patch to resolve 'set but usused' variable warnings

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001949

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |john@dallaway.org.uk
         Depends on|                            |1001948
           Assignee|unassigned@bugs.ecos.source |john@dallaway.org.uk
                   |ware.org                    |
     Ever confirmed|0                           |1

--- Comment #1 from John Dallaway <john@dallaway.org.uk> ---
Andy, can you modify this patch to use the CYG_UNUSED_PARAM macro defined in
<cyg/infra/cyg_type.h> please? There's an existing usage example immediately
above your proposed change in libcdl/expr.cxx.

If CYG_UNUSED_PARAM is no-longer effective in silencing the warnings with GCC
4.8 then we will have to think again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001949] ConfigTool - Patch to resolve 'set but usused' variable warnings

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001949

Andy Jackson <andy@xylanta.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2460|0                           |1
        is obsolete|                            |

--- Comment #2 from Andy Jackson <andy@xylanta.com> ---
Created attachment 2476
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2476&action=edit
Revised patch to resolve 'set but usused' variable warnings

Updated patch which uses CYG_UNUSED_PARAM

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001949] ConfigTool - Patch to resolve 'set but usused' variable warnings

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001949

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |CURRENTRELEASE

--- Comment #3 from John Dallaway <john@dallaway.org.uk> ---
Thank you for the revised patch. Now checked in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.