From: Nick Garnett <nickg@ecoscentric.com>
To: Edgar Grimberg <edgar.grimberg@zylin.com>
Cc: ecos-patches@ecos.sourceware.org
Subject: Re: IO FLASH and caches
Date: Fri, 16 Oct 2009 12:58:00 -0000 [thread overview]
Message-ID: <m3my3r4hs6.fsf@xl5.calivar.com> (raw)
In-Reply-To: <d0f570ed0910160530u4d0400dbh6a15fab32609cc82@mail.gmail.com>
Edgar Grimberg <edgar.grimberg@zylin.com> writes:
> The only place where the uncached address is used is inside the area guarded by:
>
> HAL_FLASH_CACHES_OFF(d_cache, i_cache);
> ...
> HAL_FLASH_CACHES_ON(d_cache, i_cache);
>
> So the patch is not supposed to modify the intended access type.
OK. My quick look at the patch and the code missed that.
However, I'm stll not sure that it is necessary to change this code.
The call to the device flash_program() routine will still evict the
caches and this verification will just refill the cache with the new
flash contents. Functionally, it should remain the same. We have never
needed to make this change for other targets that have similar cache
behavior, so I'm still unclear what the issue here is.
--
Nick Garnett eCos Kernel Architect
eCosCentric Limited http://www.eCosCentric.com The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No: 4422071
next prev parent reply other threads:[~2009-10-16 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 7:41 Edgar Grimberg
2009-10-16 11:04 ` Nick Garnett
2009-10-16 12:30 ` Edgar Grimberg
2009-10-16 12:58 ` Nick Garnett [this message]
2009-10-16 13:23 ` Edgar Grimberg
2009-10-16 13:15 ` Bart Veer
2009-10-16 13:37 ` Edgar Grimberg
2009-10-16 14:41 ` Bart Veer
2009-10-16 14:57 ` Edgar Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3my3r4hs6.fsf@xl5.calivar.com \
--to=nickg@ecoscentric.com \
--cc=ecos-patches@ecos.sourceware.org \
--cc=edgar.grimberg@zylin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).