From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22631 invoked by alias); 16 Oct 2009 12:58:42 -0000 Received: (qmail 22623 invoked by uid 22791); 16 Oct 2009 12:58:41 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from anchor-post-1.mail.demon.net (HELO anchor-post-1.mail.demon.net) (195.173.77.132) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Oct 2009 12:58:36 +0000 Received: from calivar.demon.co.uk ([83.104.54.243] helo=xl5.calivar.com) by anchor-post-1.mail.demon.net with esmtp (Exim 4.69) id 1MymOA-0001qb-iu; Fri, 16 Oct 2009 12:58:34 +0000 Received: from xl5.calivar.com (localhost [127.0.0.1]) by xl5.calivar.com (Postfix) with ESMTP id 3E3B4138776; Fri, 16 Oct 2009 13:58:34 +0100 (BST) To: Edgar Grimberg Cc: ecos-patches@ecos.sourceware.org Subject: Re: IO FLASH and caches References: From: Nick Garnett Original-Sender: nickg@ecoscentric.com Date: Fri, 16 Oct 2009 12:58:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2009-10/txt/msg00014.txt.bz2 Edgar Grimberg writes: > The only place where the uncached address is used is inside the area guarded by: > > HAL_FLASH_CACHES_OFF(d_cache, i_cache); > ... > HAL_FLASH_CACHES_ON(d_cache, i_cache); > > So the patch is not supposed to modify the intended access type. OK. My quick look at the patch and the code missed that. However, I'm stll not sure that it is necessary to change this code. The call to the device flash_program() routine will still evict the caches and this verification will just refill the cache with the new flash contents. Functionally, it should remain the same. We have never needed to make this change for other targets that have similar cache behavior, so I'm still unclear what the issue here is. -- Nick Garnett eCos Kernel Architect eCosCentric Limited http://www.eCosCentric.com The eCos experts Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No: 4422071