From: Nick Garnett <nickg@ecoscentric.com>
To: "Spencer Oliver" <spen@spen-soft.co.uk>
Cc: "'John Dallaway'" <john@dallaway.org.uk>,
<ecos-patches@ecos.sourceware.org>
Subject: Re: patch feedback
Date: Wed, 10 Dec 2008 10:13:00 -0000 [thread overview]
Message-ID: <m3y6yobaos.fsf@xl5.calivar.com> (raw)
In-Reply-To: <20081210100005.C0767138766@xl5.calivar.com>
"Spencer Oliver" <spen@spen-soft.co.uk> writes:
> > >> While i understand everyone is busy, feedback is always
> > appreciated.
> > >>
> > >> http://ecos.sourceware.org/ml/ecos-patches/2008-11/msg00117.html
> > >
> > > I will look at this one shortly. Thank you for the patch...
> >
> > Now checked in. I renamed the event handler function for consistency.
> >
>
> Many Thanks.
>
> Any chance you could get the other one looked at aswell:
> http://ecos.sourceware.org/ml/ecos-patches/2008-11/msg00109.html
> It fixes a selection bug with the stm32 memory layout when using the
> configtool.
Spencer,
I've taken a look at this. The change is fine. However, there can be
issues around switching major aspects of a confguration like this. The
libraries and other things don't always get rebuilt properly. For this
reason I never do it and prefer to reconfigure from scratch.
I was waiting until there were more Cortex-M patches to check in and
do them in a block. Unfortunately no more have turned up. So I'll
check it in sometime today.
--
Nick Garnett eCos Kernel Architect
eCosCentric Limited http://www.eCosCentric.com The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No: 4422071
next parent reply other threads:[~2008-12-10 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081210100005.C0767138766@xl5.calivar.com>
2008-12-10 10:13 ` Nick Garnett [this message]
[not found] <43500.7030996077$1228338217@news.gmane.org>
2008-12-04 8:39 ` John Dallaway
2008-12-09 19:09 ` John Dallaway
2008-12-10 9:59 ` Spencer Oliver
2008-12-03 21:02 Spencer Oliver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6yobaos.fsf@xl5.calivar.com \
--to=nickg@ecoscentric.com \
--cc=ecos-patches@ecos.sourceware.org \
--cc=john@dallaway.org.uk \
--cc=spen@spen-soft.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).