From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11180 invoked by alias); 10 Dec 2008 10:13:56 -0000 Received: (qmail 11171 invoked by uid 22791); 10 Dec 2008 10:13:55 -0000 X-Spam-Level: * X-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from lon1-post-3.mail.demon.net (HELO lon1-post-3.mail.demon.net) (195.173.77.150) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Dec 2008 10:12:55 +0000 Received: from calivar.demon.co.uk ([83.104.54.243] helo=xl5.calivar.com) by lon1-post-3.mail.demon.net with esmtp (Exim 4.69) id 1LAM3p-0004CL-ct; Wed, 10 Dec 2008 10:12:53 +0000 Received: from xl5.calivar.com (localhost [127.0.0.1]) by xl5.calivar.com (Postfix) with ESMTP id EEE4F138762; Wed, 10 Dec 2008 10:12:51 +0000 (GMT) To: "Spencer Oliver" Cc: "'John Dallaway'" , Subject: Re: patch feedback References: <20081210100005.C0767138766@xl5.calivar.com> From: Nick Garnett Original-Sender: nickg@ecoscentric.com Date: Wed, 10 Dec 2008 10:13:00 -0000 In-Reply-To: <20081210100005.C0767138766@xl5.calivar.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2008-12/txt/msg00026.txt.bz2 "Spencer Oliver" writes: > > >> While i understand everyone is busy, feedback is always > > appreciated. > > >> > > >> http://ecos.sourceware.org/ml/ecos-patches/2008-11/msg00117.html > > > > > > I will look at this one shortly. Thank you for the patch... > > > > Now checked in. I renamed the event handler function for consistency. > > > > Many Thanks. > > Any chance you could get the other one looked at aswell: > http://ecos.sourceware.org/ml/ecos-patches/2008-11/msg00109.html > It fixes a selection bug with the stm32 memory layout when using the > configtool. Spencer, I've taken a look at this. The change is fine. However, there can be issues around switching major aspects of a confguration like this. The libraries and other things don't always get rebuilt properly. For this reason I never do it and prefer to reconfigure from scratch. I was waiting until there were more Cortex-M patches to check in and do them in a block. Unfortunately no more have turned up. So I'll check it in sometime today. -- Nick Garnett eCos Kernel Architect eCosCentric Limited http://www.eCosCentric.com The eCos experts Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No: 4422071