From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15821 invoked by alias); 22 Aug 2007 18:31:02 -0000 Received: (qmail 15693 invoked by uid 22791); 22 Aug 2007 18:31:01 -0000 X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from snape.ecoscentric.com (HELO snape.ecoscentric.com) (212.13.207.199) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Aug 2007 18:30:59 +0000 Received: from localhost (snape.ecoscentric.com [127.0.0.1]) by snape.ecoscentric.com (Postfix) with ESMTP id B3E60DC807E; Wed, 22 Aug 2007 19:30:56 +0100 (BST) X-Virus-Scanned: amavisd-new at ecoscentric.com Received: from snape.ecoscentric.com ([127.0.0.1]) by localhost (snape.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tIzWUMIhOGQg; Wed, 22 Aug 2007 19:30:55 +0100 (BST) Received: from delenn.bartv.net (unknown [212.13.207.199]) by snape.ecoscentric.com (Postfix) with ESMTP id 86C27DC8061; Wed, 22 Aug 2007 19:30:55 +0100 (BST) Date: Wed, 22 Aug 2007 18:31:00 -0000 Message-Id: From: Bart Veer To: andrew@lunn.ch CC: rosenfeld@grumpf.hope-2000.org, ecos-patches@ecos.sourceware.org In-reply-to: <20070822175515.GA15974@grumpf.hope-2000.org> (message from Hans Rosenfeld on Wed, 22 Aug 2007 19:55:15 +0200) Subject: Re: [ECOS] Re: LPC2xxx patch for support of vectored interrupt controller References: <20070820151336.GA1125@grumpf.hope-2000.org> <20070822082451.GF31057@lunn.ch> <20070822084026.GA2126@grumpf.hope-2000.org> <20070822091803.GH31057@lunn.ch> <20070822095228.GD2126@grumpf.hope-2000.org> <20070822100626.GJ31057@lunn.ch> <20070822105132.GF2126@grumpf.hope-2000.org> <20070822111216.GL31057@lunn.ch> <20070822134646.GA16442@grumpf.hope-2000.org> <20070822151524.GN31057@lunn.ch> <20070822175515.GA15974@grumpf.hope-2000.org> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2007-08/txt/msg00048.txt.bz2 Hang on a sec - turning these interrupt priorities into CDL options seems overkill. It would be simpler for the interrupt tests to contain something like: #ifdef HAL_INTR_TEST_PRIO_A # define PRIO_A HAL_INTR_TEST_PRIO_A #else # define PRIO_A 1 #endif #ifdef HAL_INTR_TEST_PRIO_B # define PRIO_B HAL_INTR_TEST_PRIO_B #else # define PRIO_B 1 #endif cyg_interrupt_create(lvl1, PRIO_A, ...); cyg_interrupt_create(lvl1, PRIO_B, ...); and for the targets of interest arrange for HAL_INTR_TEST_PRIO_A and HAL_INTR_TEST_PRIO_B to be defined when #include'ing , e.g. via var_intr.h or proc_intr.h Allowing HALs to override defaults in testcases sometimes makes sense. However I cannot think of any circumstances where end users would want to mess about with these settings, so exposing them in the config tool would be inappropriate. Bart -- Bart Veer eCos Configuration Architect eCosCentric Limited The eCos experts http://www.ecoscentric.com/ Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No 4422071.