public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bart Veer <bartv@ecoscentric.com>
To: John Dallaway <john@dallaway.org.uk>
Cc: ecos-patches@ecos.sourceware.org
Subject: Re: Suppress -fprofile-arcs in extras.o rule
Date: Sat, 20 Nov 2010 21:58:00 -0000	[thread overview]
Message-ID: <pnd3pzves5.fsf@delenn.bartv.net> (raw)
In-Reply-To: <4CE833F4.2040601@dallaway.org.uk> (message from John Dallaway on	Sat, 20 Nov 2010 20:47:48 +0000)

>>>>> "John" == John Dallaway <john@dallaway.org.uk> writes:

    John> This patch eliminates the possibility of passing
    John> -fprofile-arcs from the global CFLAGS to the linker when
    John> generating extras.o. -fprofile-arcs would imply -lgcov and
    John> interfere with subsequent application linking.

    John> Checked-in.

This makes no sense to me. AFAIK gcc -Wl,--whole-archive should only
invoke the linker, not the compiler, and the option -fprofile-arcs
only affects the compiler (a grep through a binutils checkout for
profile-arcs shows no hits). The presence or absence of
-fprofile-arcs/-fno-profile-arcs in this custom build step should have
no effect whatsoever on the build.

If any of eCos is built with -profile-arcs in the global CFLAGS then
the compiler will generate extra code which will have a dependency,
either on a gcov support library or on some other profiling library
interested in run-time behaviour at the arc level. The linker is not
going to eliminate that extra code just because you add
-fno-profile-arcs to the linker command line, so the dependency
remains.

Hence all this patch achieves is to add some unnecessary and confusing
noise to the build process.

Bart

-- 
Bart Veer                                   eCos Configuration Architect
eCosCentric Limited    The eCos experts      http://www.ecoscentric.com/
Barnwell House, Barnwell Drive, Cambridge, UK.      Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.

      reply	other threads:[~2010-11-20 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20 20:48 John Dallaway
2010-11-20 21:58 ` Bart Veer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pnd3pzves5.fsf@delenn.bartv.net \
    --to=bartv@ecoscentric.com \
    --cc=ecos-patches@ecos.sourceware.org \
    --cc=john@dallaway.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).