From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67087 invoked by alias); 21 Dec 2017 13:48:40 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 66916 invoked by uid 89); 21 Dec 2017 13:48:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0102.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 13:48:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MRfqGvUWKHeACepGKBHm4gt+t/vyEMV6mR4sxXSyUaY=; b=Csy8HI4uye3o2zu0WaO0Nbm3tKlnSLysDolZ7UNLzuGApStVTzjvNhOCA+XyE3ssF55SBihyskVytKupMsSaaqpcuf63n1IoKdOVWkZ+uOG5OOm2HuHtvDw0i1gBb0tSIo9Zod+Oi2H/Umq/DGX8N0XuGJ0jtdNeeuVsHxfm6cg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ulf.hermann@qt.io; Received: from [10.9.78.45] (62.220.2.194) by DB5PR0201MB1831.eurprd02.prod.outlook.com (2603:10a6:0:32::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Thu, 21 Dec 2017 13:48:09 +0000 Subject: Re: [PATCH 2/2 v2] Generalize cu_sec_idx To: Mark Wielaard , elfutils-devel@sourceware.org References: <1513259491.15696.82.camel@klomp.org> <7ba4e217-ebd7-1fea-31c7-5c2ff6ba166b@qt.io> <1513793336.3236.23.camel@klomp.org> From: Ulf Hermann Message-ID: <01ed1fca-c9de-c819-df7b-813c25b1da7c@qt.io> Date: Thu, 21 Dec 2017 13:48:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1513793336.3236.23.camel@klomp.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: AM6PR0102CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:209:14::26) To DB5PR0201MB1831.eurprd02.prod.outlook.com (2603:10a6:0:32::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22b9cec0-a41b-4f45-fc8b-08d5487978c7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307)(7153060);SRVR:DB5PR0201MB1831; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1831;3:EA50zrgp3s7BSRppKvMpa7NfennSL/Xe1QGyeHGTUKa9WF0J+p2N8qbNvWqNolex7KpBi1L/cFY8+KlQVzuvpbO6ZX9C/VPxqf6xL/dOfqElz/HFzq2q9sDrn6TjSX4Vdp2pRXcdZ9OVLN/8GscmPZKjKC8JvYoqjoWnNCla40IghPfa9Y3+7jEWBIwW3wmqmf1/YJZFUEf2Nm3GLxh1iNRmbGvDk40qJnPP6/QDA15FPOVxme81K12SZfnLJJDW;25:/BdmU72Y/Qs+tdEfCTV4QGvQPuTzdpYOc8kCIydioBGjKK2Flu7qKtw1iqpT2+x6Ygo5LBr5CO1BiJA6j0QdH8hyL8yLsKtkDZaVVujRZXxrAADNF/30/GdtHQQBaNj98QdjI83TRMqs8YaInjKLyvHNQ/yo14uip1GNV5rf+ZQ4tJfxBaXoRzJXoMAkhM65rR9OWisWgdB8dD/ZJ7rmwuCnzRHzMCRGcZu7x6bNTP8hSUj9L8T+ZQjIjX1wdc5RUCYqcL8UYHnLSLzTdw06zYmgt8PWu+6GCmP8MpwUyf6BgMs+YJDbIY1tGcfnJ+0drNjFsiiWe9/3BrwiFouj6A==;31:dHDIAp0bVHaL9pMJHki0baXfpREJWKH67y7Y0UME67TgWRym9QCKIP1KIMlPEvGV7JRlJVPxE6gdqt5NrupwQ3LxDQfYfO/M1RXtKANnSS37E87C9MkD40TdLW9g13b7qiktE82qmhQiNxQz9IKhWOU1eJFePfOdpy7t6L7MAndY31AXrBCqiKlWjHQPVsJAzSwNvDGjrS26C3lE/HFiNYuvYcFTrdXevngLkPlTBaE= X-MS-TrafficTypeDiagnostic: DB5PR0201MB1831: X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1831;20:iSSwuT2L9InYdvkhOtxldM6hIOdH3SlZ/msJ0a+05/fZEpKhz1W9Q1+L6es49vixS9kMYbvkcPzu48zSJn9lynkN6iwZJLXEint3WnIVjNFB3bXi6F8X4PkarOYGIXrpU0PygfRbhqsqrddMbT2Q9dj/a9GYa8ioZw47CVZlhohJyMafPIE90O5l5KPFd8iG2MAkxvFkuawQnWnQgAP2kWYKSTFMW/ryioSuP8n9iokmM2HKvrgfH2vk11Xvq9yTfGA2pEeScipLyoz0ciOdIXZjq+oPP4VKf3/mAvC8PFNxVMVt/qOGgJKo4c9UyRIjV+ENtsgPfc3c1Ya3H/mVHfArhsEn3Pp/ltXs+42rsTVOjlKWo+5dyaoyCGo1YTFNQx9+fyMbz7G1MmosjZ9NJvd/HySu/V7rSTD4vg9WYWEuMDryF6fBSbzPkQczkw1m7RfJksjCAp4XY72XlVVjGxh74WvvObD28MTzfIuppuECLrY5paYLp2mGb3HoXt/Q;4:7RQg9mhT+EVCtz+vH5m8LX+kpOnhxvlDPIQuSd17NMbp4eXWrTEod+vjSAhsf7gJlN6PSqOoW0eePindgfY4thUpZIMWQdQfqsRrDCzb0gaLN1XplYpPlLjqe8FarUL5a0sAkji8Zk8kVrwcIyCLgKLJ19R+3Ae59e70fXBp+dbv5poJxThcVge8FWOV3K4BGJavFxxAEkcNSSeGKm489wUoWTBykS8hJuvFDHvhFyjjvykHw9FCSUToBegxgla53JxRsfyr2S5qUORvCmCTqQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(10201501046)(93006095)(93001095)(3002001)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:DB5PR0201MB1831;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB5PR0201MB1831; X-Forefront-PRVS: 0528942FD8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(396003)(376002)(39850400004)(39380400002)(346002)(366004)(189003)(199004)(25786009)(6666003)(3260700006)(105586002)(5890100001)(81166006)(230700001)(6246003)(3846002)(478600001)(31686004)(16526018)(6486002)(229853002)(2486003)(8936002)(106356001)(6116002)(5660300001)(77096006)(305945005)(65826007)(53936002)(2950100002)(33896004)(83506002)(74482002)(2906002)(316002)(67846002)(16576012)(52146003)(52116002)(7736002)(58126008)(81156014)(68736007)(86362001)(47776003)(8676002)(76176011)(31696002)(93886005)(36756003)(65806001)(64126003)(23676004)(386003)(97736004)(65956001)(66066001)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR0201MB1831;H:[10.9.78.45];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: qt.io does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjAyMDFNQjE4MzE7MjM6WkdTNjJJRUJ1Wk1WYTRmbG0zdHBJVzkz?= =?utf-8?B?VENxTy91S08vdkdnZ3pFcmp2dDV3MlQ3MnI3cUJCTU0zakNPRGdHaGhGYnZP?= =?utf-8?B?aUJ0dS9LWFlXN3c5amJEbXhrdzQyUWI3MXh4T1ROanhLWGZsZFJmQnRsNDU2?= =?utf-8?B?eDNSRjd2Q09hYlJLd0k2MWtNRVpXbnE5ZWxpYzg3dEZMQVpXRmhwQkJOUVMx?= =?utf-8?B?Umh5UzJ2L2tPQzZiMFNkc1pBVW9HNEtQL041K1hWQnBlNWRiZ3RaMDA4akhG?= =?utf-8?B?cE9pd0xPQks2aXAzL05ma1FZZndmSERlYVQzRTVtWUtheHdtdkVSMXJRZDdO?= =?utf-8?B?R1dyT0lmQi8xS1diR01kVTRKelZKTU5VSW1pMmJTYnRYOW4yNUdwT1Bic2tI?= =?utf-8?B?RzVvWWU2WUx0NkxDQW83WnRnUGRBR2NYeVpXekdWZ0tiTlZpbzY1VDB6NEhM?= =?utf-8?B?ZjUyUGVSekRuWmdkNkd1Misyd2crcGtCNTV5MWJ4aS9mdEV1cHgyNFRCMWs5?= =?utf-8?B?VFlmRnpxN0Q2RUU2eXorQjVOTEpSOEhJbUZjWWF1ZkM5SDk0cnpoSGQyZDZ1?= =?utf-8?B?NmN0U0lkdUNPNnZZUnlGV281aFkrUmg3NEpralc4bUFsNnpJN25nRS9PQmUx?= =?utf-8?B?aG1FNzZWb2ZqVytaVDV6N3F6U0RMNTNRclgrWU1ubDg5U3ppeXlIbWFtSXNN?= =?utf-8?B?eW12YmhIRkYxeEgvWTNuaEs2MWNEQTZEZHMyd2xheDFMeDZ0RW0zVkllbnI3?= =?utf-8?B?ZHB0bEVLVy83OEc1cXNVd1l4ZGNncStaRk1VcXpmKzlnTlhuOFA5dzBuQTNT?= =?utf-8?B?Z0ZqUmdXVExzeGplRkJKSG5EZ2VjdHV5L0UreHh5TjJRMWdJamJpNTlqZTIw?= =?utf-8?B?djhaWTlDV1hnd29aUktRZXpSZjJHdFM5RDM5b2N2TXBIc1UwYktOSStNRldV?= =?utf-8?B?RWJhWkFYTFhBNTFSeGwwdFFienVEYVpneHp1T2tlalRYVzU1WEhNUlNQaEU5?= =?utf-8?B?T1JCTHczai8rdThqOTY1YWhpNFJxZytMcWhCY1EvMG1LVXdzVm9VZ2EyWkxy?= =?utf-8?B?RU5waDZuMTlKZTBwNHZVbTR6ajBqMFMrUDhIVDZRU1RKRk9GTWdCaW0vbGtP?= =?utf-8?B?ZDlqU3pCcmtPL1VTdjB4L2J2MWQ2OXJneitaMFZ4QktHdWl3QVJCL25wQ1JT?= =?utf-8?B?dVdIa1FkUnl4M2MwRTIzdEt6VU5QaDJtNkZ0QlFSaHFBQmpOYzJvUDNQcndL?= =?utf-8?B?T2hXSGk1dUJBeVFMcmhWNnlWZElFUy95a2tGVktDWkJMcHZkeS93eWdOTDBT?= =?utf-8?B?eVIvamhBMGR6Q3JjQVI5SndXOWZRY2tpTDlCWDMxeUFUNEpTaFJJNWxLZTJz?= =?utf-8?B?OElXdmwvcVdPZytuc0ZoTDQzeVQyWXJkSVplMHRkQ1BxcllsN0ZGL1FtalRF?= =?utf-8?B?TTV3UUdEa1lBMUxkOG9VSy9VYnlUR3htbDV6WUFUMU10NUNYcnY4NU0vTWx5?= =?utf-8?B?MHBTSzNYVmxNbHBJckRFYit5a2gyR1lGMXpuYUxIVDNCeHM3U3dRWWJhOXRL?= =?utf-8?B?aWtOVlY3ZGJHMEo5NTV6K1RpVlFiRm1pVGRNeVQyV2RpVUFLV0c5SEtBNTRF?= =?utf-8?B?UlgxbTFHQkxHN2FqNkh5c2pjazdveGdPQVpqeHArV0RlOER2cVBDQVR2clkw?= =?utf-8?B?M3F1azJtdFAzOGEvUVFyNHlUaXNRK21EQ0Q4QUw4eDduVzREdWtJUUpIRURu?= =?utf-8?B?bklCemZJeGUwOG5NYWV3cnBPd1V2dUM0TVBiUDNvYlRNVDFnQ1dNZ0pOOU8z?= =?utf-8?B?WDh1dGw4dVo5enhUV21sL1BPaUxKdGloSDE0L0gyUS9CV2N5dG1UQytmTVBR?= =?utf-8?Q?aI2NxwQV7d0CrRzgeJctpxcWBw3vvJjw1/?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1831;6:ne6xS7m6JkbCalFYUZZHgAPa0DYdUFH+FeOLBamOFmAlyhyu/UqH9OXDi8chvt/pq5wzt4fd+IRQBWPcbmEFlExq2A2V0AxNOXvPBfp5JWJYkGGdNINdB4V9DEwtm23k3ulT8kbScRYYrqIIWka8At/PzY0SMk90fWQIy+Jy7CNiz21OEIBsWLRV1zqeZiRjK6nzQqeWS+l6ME7R67N2lFt6EnMMYagFOyjRCYdlQpwzOELJyST6P1FNLcAA5AZqB/7EhArmRSdkLWwY3sttMCqY5ts374bjjUFzT3mX+H+lEfaE3k5720TgzCuJYsV87BealG86lJWl0e2QaEPCHD5rslhYvG9SUB6sOGcvJ04=;5:So1kbmB3DjFFFknLlargOQ/oaMVx9sTCWPJ+Tx+uUR2piWjbswVfiL4YDeeIRCAmzslHZvSBay/Bkq/+loOndhpsTOQoQCWxXwaIuewyECrr1uTsY1HeTHrBKWsuF5qfukAio9/QbkeKpOkECmX3p0tvHl+LL9Jj1zk9ttLtkpA=;24:lt7sSTxG9za6WlsXosGQVlX+ycNm0Yf4n3gJPnZYBdkkD2YS8dHjcY02LJsMHsZcOD5gOLbJ9SUJCfaLsjPAXVus1UXCJR1ybHlrWgt4XvA=;7:p3KT2lYCt0ch6g9OsoaxUBwz0Ba5SNK4YqYjvIGIbC7tQKundDPL4rDV7y0yAGIaxZJ616OKYXDq5eiozV06GsXqjD55bBK6rxZuZQsDsoyWvrjPS9Lf1zk8tEd6FeHqp3/FDvCC7cedWFxAaAAD6V8Z+x7wkwo2c3Dx//r3KXhQvCRvVkCQRernm8HKT/ZMZLzaI1uXUSpDm7yfU6OIr1oxYUju/1u69V8bYDwvli3KZXZIeJXmwd/8oUKJ+AWa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 13:48:09.5533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22b9cec0-a41b-4f45-fc8b-08d5487978c7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 20d0b167-794d-448a-9d01-aaeccc1124ac X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0201MB1831 X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00118.txt.bz2 > yes, but the original code really was not correct. The attached patch > fixes it by adding an explicit sec_idx field to the Dwarf_CU struct > that is set whenever a struct Dwarf_CU is created, so that we never > have to guess. > > This patch combined with the overflow fix makes all testcases PASS. Looks good to me. Ulf