From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id B442B3858D1E for ; Thu, 22 Dec 2022 18:17:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B442B3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 6DB93300071A; Thu, 22 Dec 2022 19:17:36 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 13777413CD0E; Thu, 22 Dec 2022 19:17:35 +0100 (CET) Message-ID: <020b98b2e8b5b4e8d1c2cb9e44cf6edd5edfb94f.camel@klomp.org> Subject: Re: =?UTF-8?Q?=E2=98=A0?= Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2) From: Mark Wielaard To: Martin =?UTF-8?Q?Li=C5=A1ka?= Cc: elfutils-devel@sourceware.org Date: Thu, 22 Dec 2022 19:17:34 +0100 In-Reply-To: <57b03cfc-a50a-026d-bbaf-fd05b85fa1f8@suse.cz> References: <20221221111547.74C4C385B50B@sourceware.org> <3bfe6caf-c08e-583e-a98c-4acdb47530f9@suse.cz> <20e14ca61f27119efca8e1e38292d82ac3048ec8.camel@klomp.org> <5e9cb312-2d45-1094-a106-0431c7c24219@suse.cz> <57b03cfc-a50a-026d-bbaf-fd05b85fa1f8@suse.cz> Content-Type: multipart/mixed; boundary="=-zki82zIkG0zYVk5hbC/K" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3038.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-zki82zIkG0zYVk5hbC/K Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2022-12-22 at 10:09 +0100, Martin Li=C5=A1ka wrote: > On 12/22/22 00:38, Mark Wielaard wrote: > > Hi Martin, > >=20 > > On Wed, Dec 21, 2022 at 07:29:19PM +0100, Martin Li=C5=A1ka wrote: > > > > What goes wrong is that this debian old stable arm setup has > > > > libzstd > > > > containing a ZSTD_compressStream2 symbol... > > > >=20 > > > > 40: 0000d349 264 FUNC GLOBAL DEFAULT 11 > > > > ZSTD_compressStream2 > > > >=20 > > > > But the zstd.h header doesn't expose it... > > >=20 > > > Yeah, that's their way of how to move an API from "staging" into > > > a stable state. > > > It was changed in: > > > https://github.com/facebook/zstd/commit/d7d89513d6a21 > > >=20 > > > and so it's present in zstd since 1.4.0. Can we somehow specify > > > library version > > > in configure.ac? >=20 > Hi Mark. >=20 > > It isn't as nice, but since there seems to be a pkgconfig > > libzstd.pc > > you could use PKG_CHECK_MODULES. See for example how we check for > > libcurl. >=20 > I can see it, however, it not easily addable to eu_ZIPLIB function :/ > I must confess, > this autoconf machinery is always something that makes me crazy :) >=20 > Do you have an elegant way how to handle it? Maybe we should simply split it from the "decompress" support. Trying to make eu_ZIPLIB handle it means we also suddenly require a newer libzstd for the simpler dwfl zstd file decompression support. So lets keep the "normal" zstd detection in place and add something like the attached (on top of your latest patch). Cheers, Mark --=-zki82zIkG0zYVk5hbC/K Content-Description: Content-Disposition: inline; filename="zstd.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="zstd.patch"; charset="UTF-8" ZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBlZjE2Zjc5ZS4u YjI1OTdmOGIgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAg LTQxNyw3ICs0MTcsNyBAQCBBQ19TVUJTVChbQloyX0xJQl0pCiBldV9aSVBMSUIobHptYSxMWk1B LGx6bWEsbHptYV9hdXRvX2RlY29kZXIsW0xaTUEgKHh6KV0pCiBBU19JRihbdGVzdCAieCR3aXRo X2x6bWEiID0geHllc10sIFtMSUJMWk1BPSJsaWJsem1hIl0sIFtMSUJMWk1BPSIiXSkKIEFDX1NV QlNUKFtMSUJMWk1BXSkKLWV1X1pJUExJQih6c3RkLFpTVEQsenN0ZCxaU1REX2NvbXByZXNzU3Ry ZWFtMixbWlNURCAoenN0KV0pCitldV9aSVBMSUIoenN0ZCxaU1RELHpzdGQsWlNURF9kZWNvbXBy ZXNzLFtaU1REICh6c3QpXSkKIEFTX0lGKFt0ZXN0ICJ4JHdpdGhfenN0ZCIgPSB4eWVzXSwgW0xJ QlpTVEQ9ImxpYnpzdGQiXSwgW0xJQkxaU1REPSIiXSkKIEFDX1NVQlNUKFtMSUJaU1REXSkKIHpz dGRfTElCUz0iJExJQlMiCkBAIC00MjYsNiArNDI2LDE2IEBAIHppcF9MSUJTPSIkTElCUyIKIExJ QlM9IiRzYXZlX0xJQlMiCiBBQ19TVUJTVChbemlwX0xJQlNdKQogCitkbmwgenN0ZCBjb21wcmVz c2lvbiBzdXBwb3J0IHJlcXVpcmVzIGxpYnpzdGQgMS40LjArCitBU19JRihbdGVzdCAieCR3aXRo X3pzdGQiID0geHllc10sIFsKKyAgICAgIFBLR19QUk9HX1BLR19DT05GSUcKKyAgICAgIFBLR19D SEVDS19NT0RVTEVTKFtaU1REX0NPTVBSRVNTXSxbbGlienN0ZCA+PSAxLjQuMF0sCisgICAgICAg ICAgICAgICAgICAgICAgICBbd2l0aF96c3RkX2NvbXByZXNzPSJ5ZXMiXSxbd2l0aF96c3RkX2Nv bXByZXNzPSJubyJdKV0sCisgICAgICBbd2l0aF96c3RkX2NvbXByZXNzPSJubyJdKQorQU1fQ09O RElUSU9OQUwoVVNFX1pTVERfQ09NUFJFU1MsIHRlc3QgIngkd2l0aF96c3RkX2NvbXByZXNzIiA9 ICJ4eWVzIikKK0FTX0lGKFt0ZXN0ICJ4JHdpdGhfenN0ZF9jb21wcmVzcyIgPSAieHllcyJdLAor ICAgICAgW0FDX0RFRklORShbVVNFX1pTVERfQ09NUFJFU1NdLCBbMV0sIFt6c3RkIGNvbXByZXNz aW9uIHN1cHBvcnRdKV0pCisKIEFDX0NIRUNLX0RFQ0xTKFttZW1yY2hyLCByYXdtZW1jaHJdLFtd LFtdLAogICAgICAgICAgICAgICAgWyNkZWZpbmUgX0dOVV9TT1VSQ0UKICAgICAgICAgICAgICAg ICAjaW5jbHVkZSA8c3RyaW5nLmg+XSkKQEAgLTgzMSw2ICs4NDEsNyBAQCBBQ19NU0dfTk9USUNF KFsKICAgICBiemlwMiBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgIDogJHt3aXRoX2J6bGli fQogICAgIGx6bWEveHogc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgOiAke3dpdGhfbHptYX0K ICAgICB6c3RkIHN1cHBvcnQgICAgICAgICAgICAgICAgICAgICAgIDogJHt3aXRoX3pzdGR9Cisg ICAgenN0ZCBjb21wcmVzc2lvbiBzdXBwb3J0ICAgICAgICAgICA6ICR7d2l0aF96c3RkX2NvbXBy ZXNzfQogICAgIGxpYnN0ZGMrKyBkZW1hbmdsZSBzdXBwb3J0ICAgICAgICAgOiAke2VuYWJsZV9k ZW1hbmdsZXJ9CiAgICAgRmlsZSB0ZXh0cmVsIGNoZWNrICAgICAgICAgICAgICAgICA6ICR7ZW5h YmxlX3RleHRyZWxjaGVja30KICAgICBTeW1ib2wgdmVyc2lvbmluZyAgICAgICAgICAgICAgICAg IDogJHtlbmFibGVfc3ltYm9sX3ZlcnNpb25pbmd9CmRpZmYgLS1naXQgYS9saWJlbGYvZWxmX2Nv bXByZXNzLmMgYi9saWJlbGYvZWxmX2NvbXByZXNzLmMKaW5kZXggZGViNTg1YjcuLjVhOWQzZGEx IDEwMDY0NAotLS0gYS9saWJlbGYvZWxmX2NvbXByZXNzLmMKKysrIGIvbGliZWxmL2VsZl9jb21w cmVzcy5jCkBAIC0xNzAsNyArMTcwLDcgQEAgX19saWJlbGZfY29tcHJlc3NfemxpYiAoRWxmX1Nj biAqc2NuLCBzaXplX3QgaHNpemUsIGludCBlaV9kYXRhLAogICByZXR1cm4gb3V0X2J1ZjsKIH0K IAotI2lmZGVmIFVTRV9aU1RECisjaWZkZWYgVVNFX1pTVERfQ09NUFJFU1MKIC8qIENsZWFudXAg YW5kIHJldHVybiByZXN1bHQuICBEb24ndCBsZWFrIG1lbW9yeS4gICovCiBzdGF0aWMgdm9pZCAq CiBkb196c3RkX2NsZWFudXAgKHZvaWQgKnJlc3VsdCwgWlNURF9DQ3R4ICogY29uc3QgY2N0eCwg dm9pZCAqb3V0X2J1ZiwKQEAgLTMzMyw3ICszMzMsNyBAQCBfX2xpYmVsZl9jb21wcmVzcyAoRWxm X1NjbiAqc2NuLCBzaXplX3QgaHNpemUsIGludCBlaV9kYXRhLAogCiAgIGlmICh1c2VfenN0ZCkK ICAgICB7Ci0jaWZkZWYgVVNFX1pTVEQKKyNpZmRlZiBVU0VfWlNURF9DT01QUkVTUwogICAgICAg cmV0dXJuIF9fbGliZWxmX2NvbXByZXNzX3pzdGQgKHNjbiwgaHNpemUsIGVpX2RhdGEsIG9yaWdf c2l6ZSwKIAkJCQkgICBvcmlnX2FkZHJhbGlnbiwgbmV3X3NpemUsIGZvcmNlLAogCQkJCSAgIGRh dGEsIG5leHRfZGF0YSwgb3V0X2J1Ziwgb3V0X3NpemUsCkBAIC00MDYsOCArNDA2LDcgQEAgX19s aWJlbGZfZGVjb21wcmVzc196bGliICh2b2lkICpidWZfaW4sIHNpemVfdCBzaXplX2luLCBzaXpl X3Qgc2l6ZV9vdXQpCiB9CiAKICNpZmRlZiBVU0VfWlNURAotdm9pZCAqCi1pbnRlcm5hbF9mdW5j dGlvbgorc3RhdGljIHZvaWQgKgogX19saWJlbGZfZGVjb21wcmVzc196c3RkICh2b2lkICpidWZf aW4sIHNpemVfdCBzaXplX2luLCBzaXplX3Qgc2l6ZV9vdXQpCiB7CiAgIC8qIE1hbGxvYyBtaWdo dCByZXR1cm4gTlVMTCB3aGVuIHJlcXVlc3RpbmcgemVybyBzaXplLiAgVGhpcyBpcyBoaWdobHkK QEAgLTQyNSw3ICs0MjQsNyBAQCBfX2xpYmVsZl9kZWNvbXByZXNzX3pzdGQgKHZvaWQgKmJ1Zl9p biwgc2l6ZV90IHNpemVfaW4sIHNpemVfdCBzaXplX291dCkKICAgaWYgKFpTVERfaXNFcnJvciAo cmV0KSkKICAgICB7CiAgICAgICBmcmVlIChidWZfb3V0KTsKLSAgICAgIF9fbGliZWxmX3NldGVy cm5vIChFTEZfRV9VTktOT1dOX0NPTVBSRVNTSU9OX1RZUEUpOworICAgICAgX19saWJlbGZfc2V0 ZXJybm8gKEVMRl9FX0RFQ09NUFJFU1NfRVJST1IpOwogICAgICAgcmV0dXJuIE5VTEw7CiAgICAg fQogICBlbHNlCkBAIC00NDQsNyArNDQzLDcgQEAgX19saWJlbGZfZGVjb21wcmVzcyAoaW50IGNo dHlwZSwgdm9pZCAqYnVmX2luLCBzaXplX3Qgc2l6ZV9pbiwgc2l6ZV90IHNpemVfb3V0KQogI2lm ZGVmIFVTRV9aU1RECiAgICAgcmV0dXJuIF9fbGliZWxmX2RlY29tcHJlc3NfenN0ZCAoYnVmX2lu LCBzaXplX2luLCBzaXplX291dCk7CiAjZWxzZQotICAgIF9fbGliZWxmX3NldGVycm5vIChFTEZf RV9ERUNPTVBSRVNTX0VSUk9SKTsKKyAgICBfX2xpYmVsZl9zZXRlcnJubyAoRUxGX0VfVU5LTk9X Tl9DT01QUkVTU0lPTl9UWVBFKTsKICAgICByZXR1cm4gTlVMTDsKICNlbmRpZgogICAgIH0KZGlm ZiAtLWdpdCBhL3NyYy9lbGZjb21wcmVzcy5jIGIvc3JjL2VsZmNvbXByZXNzLmMKaW5kZXggYmZk YWMyYjQuLjFmMzIzMzFjIDEwMDY0NAotLS0gYS9zcmMvZWxmY29tcHJlc3MuYworKysgYi9zcmMv ZWxmY29tcHJlc3MuYwpAQCAtMjMwLDcgKzIzMCw4IEBAIGNvbXByZXNzX3NlY3Rpb24gKEVsZl9T Y24gKnNjbiwgc2l6ZV90IG9yaWdfc2l6ZSwgY29uc3QgY2hhciAqbmFtZSwKICAgICByZXMgPSBl bGZfY29tcHJlc3MgKHNjbiwgZGNodHlwZSwgZmxhZ3MpOwogCiAgIGlmIChyZXMgPCAwKQotICAg IGVycm9yICgwLCAwLCAiQ291bGRuJ3QgZGVjb21wcmVzcyBzZWN0aW9uIFslemRdICVzOiAlcyIs CisgICAgZXJyb3IgKDAsIDAsICJDb3VsZG4ndCAlcyBzZWN0aW9uIFslemRdICVzOiAlcyIsCisJ ICAgY29tcHJlc3MgPyAiY29tcHJlc3MiIDogImRlY29tcHJlc3MiLAogCSAgIG5keCwgbmFtZSwg ZWxmX2Vycm1zZyAoLTEpKTsKICAgZWxzZQogICAgIHsKZGlmZiAtLWdpdCBhL3Rlc3RzL01ha2Vm aWxlLmFtIGIvdGVzdHMvTWFrZWZpbGUuYW0KaW5kZXggY2I3MDIyOWUuLjcxYjE5NjAxIDEwMDY0 NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQorKysgYi90ZXN0cy9NYWtlZmlsZS5hbQpAQCAtMjE4 LDYgKzIxOCw5IEBAIGVuZGlmCiAKIGlmIEhBVkVfWlNURAogVEVTVFMgKz0gcnVuLXJlYWRlbGYt Y29tcHJlc3NlZC16c3RkLnNoCitlbmRpZgorCitpZiBVU0VfWlNURF9DT01QUkVTUwogZXhwb3J0 IEVMRlVUSUxTX1pTVEQgPSAxCiBlbmRpZgogCg== --=-zki82zIkG0zYVk5hbC/K--