From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 6B8AD3858D3C
 for <elfutils-devel@sourceware.org>; Thu, 16 Sep 2021 10:35:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B8AD3858D3C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 5A8DA3000648;
 Thu, 16 Sep 2021 12:35:23 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 6D6B6413CE02; Thu, 16 Sep 2021 12:35:23 +0200 (CEST)
Message-ID: <028e941c85db8e644eaef01d5882fe2fe1972959.camel@klomp.org>
Subject: Re: [Bug debuginfod/28034] client-side %-escape url characters
From: Mark Wielaard <mark@klomp.org>
To: Noah Sanci <nsanci@redhat.com>, elfutils-devel@sourceware.org
Date: Thu, 16 Sep 2021 12:35:23 +0200
In-Reply-To: <CAJXA7qhkGVAPOB=4-6XcW7oNTPOySf0v5_EpTSH37dOjZrfJ4w@mail.gmail.com>
References: <CAJXA7qjt7-ZwThr0do3pGFg5i+bfa-fvDSOkq=w8Q8euNAG12g@mail.gmail.com>
 <20210826210213.GM416@redhat.com>
 <CAJXA7qiQDGQN8f76aJtVagutoyNv6SXBAfUffgctFR9CgqJ1NA@mail.gmail.com>
 <CAJXA7qiQTWKQ7_d4X0MSkV8r3PO+0E6h89mZsc64LxvtbiOm5w@mail.gmail.com>
 <CAJXA7qjp0nXoZb9QS+rGbpEQK4HR9TyQBi5YaFtNYVr++goFmw@mail.gmail.com>
 <e785e77b620f34cbcaf5f6b32b7912f429a89785.camel@klomp.org>
 <CAJXA7qj_=SSH4co_b34vN6N0yTdxuWyZkm1J6bb4A08-h1=M-A@mail.gmail.com>
 <YT433jt593F8OUjx@wildebeest.org>
 <CAJXA7qgb1Z9BoKVbE-Tc8BaGm8wEDd9_Ot6tCF7aU_JQQev4uQ@mail.gmail.com>
 <CAJXA7qhkGVAPOB=4-6XcW7oNTPOySf0v5_EpTSH37dOjZrfJ4w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Sep 2021 10:35:27 -0000

Hi Noah,

On Mon, 2021-09-13 at 14:11 -0400, Noah Sanci via Elfutils-devel wrote:
> Quick arithmetic change to the original patch with an updated commit
> message.

Thanks for commenting this, it is easy to make an off-by-one (or two)
error.

> Previously, urls containing '/', so most urls, would escape '/' to %2F,
> which is undesirable for use in other libraries which may escape
> differently. This patch escapes the '/' and replaces all of them
> ensuring there are no %2Fs sent.
> Some inefficiencies within the code were fixed, such as changing constant
> operations of a while loop within a for loop to a while loop outside of
> a for loop. Also strlen is no longer used within the loop, simplifying
> the interior operations to mere arithmetic.
>=20
> https://sourceware.org/bugzilla/show_bug.cgi?id=3D28034

Looks good.
Could you push it to the master branch?
(Please do rebase first, so we keep a linear history)

Thanks,

Mark