From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74337 invoked by alias); 4 May 2017 15:08:33 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 74308 invoked by uid 89); 4 May 2017 15:08:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30127.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.127) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 May 2017 15:08:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MQi48+dYoF5+2NHwzhlRo9vBi5pZL1k3d8UDSGNY0hY=; b=jkamJ0vlM8WVJpumQRBndzI6M04AiGHGW+/Wc2vQre9C0mqHeJcfoetVUmphR0MkOW6e2+xhxJozVxn3wgGtfJAO6h2gUGoJ2tXEXs+DzjWn1dJN4HZJixaPdtig3KUs16xCnnu5MizlYETKs81aEWvMpyCpSN685Liw0VTxsdM= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; Received: from [10.9.78.56] (62.220.2.194) by DB3PR02MB234.eurprd02.prod.outlook.com (2a01:111:e400:9410::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Thu, 4 May 2017 15:08:29 +0000 From: Ulf Hermann Subject: [PATCH] Cast pid_t to int when printing it with %d To: Message-ID: <052ee213-69e2-370e-523a-d3a06b5c7f74@qt.io> Date: Thu, 04 May 2017 16:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: AM5PR0101CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:203:2d::12) To DB3PR02MB234.eurprd02.prod.outlook.com (2a01:111:e400:9410::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba42449d-006c-4efd-5e1a-08d492ff6c36 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:DB3PR02MB234; X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB234;3:YfRubl3cnO+IAWFiG/2nhJIc9iGEPgf4M5hXZvjfiWQXq93fwTkWnRdDExM3Ys4ToRviM0cw0N33PYGfk1aesdnrKzvHjg/YkCtzrn8HWAn03o7yCIxuL4e8XcQflThaFFZMhfauUxfSkhKC/QqV9ahgN8KJ8Ga79PLCYkvQEMGvHaQWiXSkpwGfY30ClFKJOUFAkIkTPFclGG2kqDf4hXsc71Fnuqc+UaywsdK2BPZiDSVvVSYOGVm3fgyKa+6x4KxYI/+Cbn7r9v1aNnJTkuokqP3Q9rXeOet3Kk+P/01I59YGstHSNoqn/Vr5dC56;25:c261BSCWR9hVlDbF6dDpwnUOGtpSMmglCF/7Xa4Wbayb6bmi4UyaAcnQ5ebY/KoZ0RfBuZfXDEk4+ex5OAkhdWEltDpEgIXlJ5IUkxLhMuglWEdttyJamnKPm3oh+jTO2GhzF0gT7AAZyiYtBiE3EWw2kswiVAeimJ3SUIcRBJMTl3CBxnykxIT8JDeEejl8YTy3dJVeHuSFAf0WN7Mcrc6BQefghnskR97Hxpawri3/qrIEH3zwiWZh9UJ6yvFMwXtWwc4VWgYFwATwgT9KuZdSz/98dAf4rl6hzOYA4fuQISmY2n2Azl+GoxoE4FmJ1I2oxyZMDFyqnN7l1V/Buq0umnjYUUTuKEzbYrOsVmyCAX8s27wWaPSjv2AbCg7BjxDGM3th28OIAQe2SGRmFY9L39WPC+EEuNafJj0Af8H9a9uHSZfUCuk1FuRa1WkWqMKHlDkTqXf1JTB7s07YOC4ZAi/5PnCLbwRz4Z0a72g= X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB234;31:qyB6FxjbSNQdGsT59f+VJ8f5C2mHNAjLtrOc5XMRTI7WdUmZrluxHcoQIO4M15+6h7ILi4UamDpUg2XFgF8stV21MfU0jTqBJvRpwJBsWuNSxVf3Rqr5UrQItl9lWl8Dy0tGVu6I4JMgjlbiTlEkBXYgeqQmcif7EJIr4hUnJegBrxYzev2mBrOLYZ9KbT8vES8fGyOD9sfEGx5+zURDtaGb3ZsnBw6P8TdhEG4GuWz9yBKdcQT3Lf14PmPehPV0hJNSFRWanZvOLyr8lm9C4tf+zqsXBF8Cg7M5TjzpMas=;20:0antMiBVIuOoqN+C6/UlSRQv42Eny5SbafpGEHVTygdh7TNgV3qHwGRFTOn8cL42gYQBmG0HXW3yl8XJ+3d7gWIHnnY8go5WFxlItIC6U8No80XMbDW+buAc6M/RindHUiPr/MlgQsvbXOqeVfSSOQ4KUYr5OuUP5OxHGZET6SoCOAoapUj3uM6/0CsmSV3gzDJBj/a3U8GBJ+nTV2mb7bK0RF9ZvwBONYA7ZEbdm0dGZAN8jwzTJqbW3mLlEuRb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123558100)(2016111802025)(6043046)(6072148);SRVR:DB3PR02MB234;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB234; X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB234;4:Q0ZgnIHhxa1MnyMEDZBCbUVlcByHd9hVk0mzKEK73ccYOK4aCvQAZGHsvUO9U23n+QT5SOvr6Xjrtv5BRITeFUYJdqAZ8mTMugrPyFj0bN0qUaXI8Q0+MGYdl+10sezqNeOCKG6vpWNzesfEIADI5sQ7hjVCcskfHVv4xLVoSEaM+gcMinNClwcJwJ4duiCySGDkpPpe+pDhl/ZRhdfQX2HGrigbYOjWTx9vehhR3E4hs+00tOkp7vEOkXNnAAK4qL1WqdCEUY3c1SMMCVwTWXF2CYSQablcULd9qyeB1bhy0iFMxgClQKOVP2AGA/lscwsxOCrhvTnWvNCTyWJFupw170NpVs+q2s6Ixj4xekMtflYIf3bmxAC/etntWJRZ4FrfcggGpasvuBpPmGl6JTcUh43rg8HifHqOV6t4/w/n4EnHYhJtyCRT/XZx0GVrKoK245xeF/1/MD5o9DYPig3/OB/K74gYiKrlxMgwoYhsJxB24E171mIX1JsacsVT1SL875I7m66cc+xx16vT9cOE7Im3RRD44chvqAbWWXLauTLZOa99CSz7OlE6i2T7cQEqRZYKLAanen8hwETR6YVQ8RGOzxCHL9tCZpg1p7lxH9p04mQKsodNzwBRuHdjWaoxzvuyT1IQceRPNX5LKm9V4CwoqsWUTC0bMWI0exaoiDO4afkV1qEZxkSCT7KOGGt0oqMrjK45Jsy7JwOJ5pTSjmsCnPp0tIxzyJruml99rCa0nzcDegfaPrmxj2nIRBeLvQLf30C1GyZd2C3ShK/zGKtfTAo9UnYZno62dD1dc7puNkIuaCufjmNHFfEpo32Haj3NyW0y8EuAzW8fyA== X-Forefront-PRVS: 02973C87BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39450400003)(39840400002)(39410400002)(39400400002)(377424004)(305945005)(8676002)(81166006)(54356999)(7736002)(5890100001)(64126003)(50986999)(36756003)(478600001)(2351001)(189998001)(65826007)(33646002)(2906002)(31686004)(53936002)(74482002)(47776003)(42186005)(77096006)(3846002)(23676002)(66066001)(6486002)(5660300001)(6916009)(6666003)(31696002)(25786009)(6116002)(83506001)(86362001)(4001350100001)(230700001)(110136004)(50466002)(38730400002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB3PR02MB234;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjNQUjAyTUIyMzQ7MjM6dW5vSTQ1dGxvTmczS1czd3Q0SjAvTzF2OFJw?= =?utf-8?B?NUk1bStaaVpxa1NzTzFnWEI4UmlGYW9icWt1dXZkZjBKNnZLd2hwSTQwK01C?= =?utf-8?B?ak9oazR6TC9sUXNsaUlWZnlKMHVOcUVXR2ZGS082SzU0TDF4S0IraFoxeTN1?= =?utf-8?B?bkN4T25DMjNsb3Y1b01UeDFmcVZablVXRUZ6MWt6UUZOTFlRUVg3K3k5b0pK?= =?utf-8?B?M0p4Y0VyS296cWhUZGpRQjdIOXVMeXZ4cHJ2U2RwQysvK1RsYmpONGFqOGgv?= =?utf-8?B?Tkp3eDVtNHVsZERudVlraWNUY1J3WGswUVRlakdTVzljTGFmNG5aSFJ2WENW?= =?utf-8?B?Nk8rYW01d3ZJRDdTSlFsSXpmbFJ1aG1INFljalRjR2t5SFZUS3crcWlLcDNl?= =?utf-8?B?cW9OWkxML2RDYkNVb0VRc1RJSDR3Z2gwWE1tODh5Zi9DeUp3djJ3eEI2QzJ1?= =?utf-8?B?YjdiZFVHVGNuK2hzREJ0ZGxrbmEyODIycXA1Tk45dGl4NStrOHFXdjQ3RUVP?= =?utf-8?B?czkveGl5Q0taaXRxQ1pMdlFQZ2tBdTlST0p4MHRDSm9ka29uU2R5NDZmYkZR?= =?utf-8?B?VW52Rm5GMWgwZ3hJQWNKSiswL3ZHY25EOGtQbUtPTFZkNEozQzB6bWRKVFMy?= =?utf-8?B?bi9EMWswOHFyTXFzU1lQT1doY0VQSmROaE14R0FVbFJRM3I0M0RaYnZNamxY?= =?utf-8?B?ZitvSXZtQmxiQVRXd2xyUUFZMm5vVlRybkdCWURtZEtWdTBJWW1lSXZkUWto?= =?utf-8?B?a3VDL3ZSQ3hRRWVKNTdreDdSQXcvK2NwWmhqRG5FdThwV2s5Vks3U0pTQnhJ?= =?utf-8?B?eVpwRW5BNHRiYVdyRjlXWXVrOFhLbHkzZmZzQnVMVU1TQWRxSWNYUU1mY09K?= =?utf-8?B?SWN5MjZzSE8xd2ZiSlRNNWlqY3M4TEhtbWpUYUlMTTlPemVobW5ydFdMcU1u?= =?utf-8?B?LzR4QWoxWUZhUFhsd0U5UkkxSG0xamxOd01IeXB0NGtDQllHbUh1Rm1uZDQ2?= =?utf-8?B?T0F5YTB6ZEhHUXFQUjJNbERIZTM1VHFDRG9CTVVKYkdPZjVSQXMrNDI5cURL?= =?utf-8?B?aFFNWHA1VFNGMVZMd1VIbXlmaENXWUtaR3RYUHNOUWpqSWZTNEJseGpJVnJG?= =?utf-8?B?WVBFWXZzM1NKSVd6K25ENk1xUWJ1MjZYUEk2NjZqY2Y4Z2RWL2Jmbm5SRmkr?= =?utf-8?B?NTI4ekN3clJYcGhYVlNtdExFYmw1RjZQUnV0Kzg1TnlQZkV1MEIvZlBsSG5Y?= =?utf-8?B?SXBMTHQ1eXN5b2FmMStUZzFVZjBrdFR2UG9vQi9JMUxvUU90UHRwaWRhWDJ4?= =?utf-8?B?N1hzNXNqcXh5T3cxcUpxdi8zREcyMGRXczZwdnRPQTNxQnVkalQ4ZDJhSDNR?= =?utf-8?B?THptQmc2VGVnYURrcWxHMWtiNHR2d1l4UDJlNk81NmN6NnY1MW16QjJUdG1J?= =?utf-8?B?emdjOENZdlhOVXFzc2g4WXNXREtpa0xzbXpWVmZid2JoODVCWU1mWEd4ZUhW?= =?utf-8?B?RUdwVzJoZDA3c2xHczkzWjgvWWpiVys4bk9FaitOSkJiZ0J6Zm1uR0hKc1M3?= =?utf-8?B?RjluMUtvczJidXN3T1dwVGdFQWNSQT09?= X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB234;6:MEyy+59bOZBaWaf9DoSjD2CKXWAv9o2fBUOqQzYnOQzKLXLG5aB09XsV5E6nJIY7xQaR8DN75TGIEDmOX6OR4TRwffSN24ZN8p+Mj+DAQsqgaxmDrbvZ/vIcHexNdIVJxWz6wBsrfporyv1WEa2Pogv2ErtBTnqMQKzVR4hpbpn7hzQMN/k84//B7gmHEuaufb493eVDz79BPoqBhYrHmbzQCawyySrHgX3Zriujgv+OyBtiF7OEQw78UAGxHAehUvFfX5ZKxs3kFKKIqgsF29GhTZoIyMYe8qs8JU7udaqCtgso6Dc1tLwPLUDItdUvk4lH6l5cE2PylOa6tmKiseVp9GCN6RYlQlXAkQEX6UW4cyCtUf12FGsORbVMqbIWm/MzAxC69GwZi617MJFJxm4IGCwYBudztCGsN3LK4i/2lDusQVu27EB2OUjbpRsDIbTXFOQa8mz9s0hJvOyhC+VMt2Tc5dyVz6JgK4loiQNa8BSt19VXEFq5nNTa7DN8mhC2Wp+Z2SkjL/Taw2UDNA==;5:a8F2hW1hh+8azYJmvKuQkG3y/rR5FtGtNU58oai80+qv5k+So3irx46Hr/YGCB1IEWSZmui77+DJMJkKkJiCzgTMqbAZPMJguPcu8SlKDHwxhddi+ZybReKH830jqMyMvYeqIXO7wby/2N6TSHYnAg==;24:ygkeaP1eSa64zdo5L97VGXc3CpXrfv+vx17ys1LtCJzaTCRws1lWtM1uHTgKlh5cXYNGMSO/L/K+0ZTFjlJMR6VBl19hJlLkozHTaTonUJM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB3PR02MB234;7:NcllaCekioG2Iv8TuR9W2ZgOQlNEOx+mqxZh180pvwzlCD9wTBHWdq06fu+lkZhQOcBgBMER8z78QN4ldLVcoW+q2vINyMBIVANndj+3l6U3XYWlazu+YnyfHCkwZmYvx8MjW/CuT9q1PnR8ktp51og6x9PUuyjiAoC7hpqc/gb0W0oAVq3k3cQdUqPqtEwiuovcva6mGjGTfcOszuwBVhJDoxywc1H/RLALcE9vbuHg6PZbhi6Q9trZxW+E1BFSG31HF2eTHhXwCAL9BEOwTaPvu2xR97/2o3ussuyaPIDNcyStmGQEmoirhNazckmNSjAMMjMuGoKu27xq6TLmOg== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 15:08:29.4610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR02MB234 X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00178.txt.bz2 On windows x86_64 pid_t is 64bit wide. We ignore the extra bits as those messages are only informational anyway. Signed-off-by: Ulf Hermann --- src/ChangeLog | 4 ++++ src/stack.c | 20 ++++++++++---------- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 0d1e57d..3c880b4 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,9 @@ 2017-05-04 Ulf Hermann + * stack.c: Cast pid_t to int when printing using %d. + +2017-05-04 Ulf Hermann + * addr2line.c: Don't assume unix file system conventions. * size.c: Likewise. * strip.c: Likewise. diff --git a/src/stack.c b/src/stack.c index 1f5a1c6..eb62b8a 100644 --- a/src/stack.c +++ b/src/stack.c @@ -362,7 +362,7 @@ print_frames (struct frames *frames, pid_t tid, int dwflerr, const char *what) if (frames->frames > 0) frames_shown = true; - printf ("TID %d:\n", tid); + printf ("TID %d:\n", (int)tid); int frame_nr = 0; for (int nr = 0; nr < frames->frames && (maxframes == 0 || frame_nr < maxframes); nr++) @@ -420,7 +420,7 @@ print_frames (struct frames *frames, pid_t tid, int dwflerr, const char *what) if (frames->frames > 0 && frame_nr == maxframes) error (0, 0, "tid %d: shown max number of frames " - "(%d, use -n 0 for unlimited)", tid, maxframes); + "(%d, use -n 0 for unlimited)", (int)tid, maxframes); else if (dwflerr != 0) { if (frames->frames > 0) @@ -440,11 +440,11 @@ print_frames (struct frames *frames, pid_t tid, int dwflerr, const char *what) else modname = ""; } - error (0, 0, "%s tid %d at 0x%" PRIx64 " in %s: %s", what, tid, + error (0, 0, "%s tid %d at 0x%" PRIx64 " in %s: %s", what, (int)tid, pc_adjusted, modname, dwfl_errmsg (dwflerr)); } else - error (0, 0, "%s tid %d: %s", what, tid, dwfl_errmsg (dwflerr)); + error (0, 0, "%s tid %d: %s", what, (int)tid, dwfl_errmsg (dwflerr)); } } @@ -575,10 +575,10 @@ parse_opt (int key, char *arg __attribute__ ((unused)), int err = dwfl_linux_proc_report (dwfl, pid); if (err < 0) - error (EXIT_BAD, 0, "dwfl_linux_proc_report pid %d: %s", pid, + error (EXIT_BAD, 0, "dwfl_linux_proc_report pid %d: %s", (int)pid, dwfl_errmsg (-1)); else if (err > 0) - error (EXIT_BAD, err, "dwfl_linux_proc_report pid %d", pid); + error (EXIT_BAD, err, "dwfl_linux_proc_report pid %d", (int)pid); } if (core != NULL) @@ -597,10 +597,10 @@ parse_opt (int key, char *arg __attribute__ ((unused)), { int err = dwfl_linux_proc_attach (dwfl, pid, false); if (err < 0) - error (EXIT_BAD, 0, "dwfl_linux_proc_attach pid %d: %s", pid, + error (EXIT_BAD, 0, "dwfl_linux_proc_attach pid %d: %s", (int)pid, dwfl_errmsg (-1)); else if (err > 0) - error (EXIT_BAD, err, "dwfl_linux_proc_attach pid %d", pid); + error (EXIT_BAD, err, "dwfl_linux_proc_attach pid %d", (int)pid); } if (core != NULL) @@ -688,7 +688,7 @@ invoked with bad or missing arguments it will exit with return code 64.") if (show_modules) { - printf ("PID %d - %s module memory map\n", dwfl_pid (dwfl), + printf ("PID %d - %s module memory map\n", (int)dwfl_pid (dwfl), pid != 0 ? "process" : "core"); if (dwfl_getmodules (dwfl, module_callback, NULL, 0) != 0) error (EXIT_BAD, 0, "dwfl_getmodules: %s", dwfl_errmsg (-1)); @@ -721,7 +721,7 @@ invoked with bad or missing arguments it will exit with return code 64.") } else { - printf ("PID %d - %s\n", dwfl_pid (dwfl), pid != 0 ? "process" : "core"); + printf ("PID %d - %s\n", (int)dwfl_pid (dwfl), pid != 0 ? "process" : "core"); switch (dwfl_getthreads (dwfl, thread_callback, &frames)) { case DWARF_CB_OK: -- 2.1.4