[PATCH] wrong backend definition?

[PATCH] wrong backend definition?

[Mao Han]

---
 backends/riscv_cfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backends/riscv_cfi.c b/backends/riscv_cfi.c
index 1a84a38..5d3e884 100644
--- a/backends/riscv_cfi.c
+++ b/backends/riscv_cfi.c
@@ -31,7 +31,7 @@
 
 #include <dwarf.h>
 
-#define BACKEND aarch64_
+#define BACKEND riscv_
 #include "libebl_CPU.h"
 
 
-- 
2.7.4

Re: [PATCH] wrong backend definition?

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Wed, 2019-04-10 at 16:05 +0800, Mao Han wrote:
> --- a/backends/riscv_cfi.c
> +++ b/backends/riscv_cfi.c
> @@ -31,7 +31,7 @@
>  
>  #include <dwarf.h>
>  
> -#define BACKEND aarch64_
> +#define BACKEND riscv_
>  #include "libebl_CPU.h"

Indeed, that was clearly wrong. Thanks for noticing.
We were lucky that none of the libebl_CPU.h definitions used in the
file depended on the BACKEND define. This should be fixed just in case
we start using the BACKEND define later.

Pushed to master as attached.

Thanks,

Mark

[-- Attachment #2: 0001-backends-riscv_cfi.c-had-a-bad-BACKEND-define.patch --]
[-- Type: text/x-patch, Size: 1088 bytes --]

From e6118f9720d42af6758a0a74b7324acd4aed383d Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Sun, 14 Apr 2019 22:40:53 +0200
Subject: [PATCH] backends: riscv_cfi.c had a bad BACKEND define.

BACKEND should have been defined as riscv_ (not aarch64_).

Reported-by: Mao Han <han_mao@c-sky.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 backends/ChangeLog   | 4 ++++
 backends/riscv_cfi.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/backends/ChangeLog b/backends/ChangeLog
index 0c61a0b..6c2b47a 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,7 @@
+2019-04-14  Mark Wielaard  <mark@klomp.org>
+
+	* riscv_cfi.c: Fix BACKEND define.
+
 2019-02-15  Mark Wielaard  <mark@klomp.org>
 
 	* s390_init.c (s390_init): Hook check_special_symbol.
diff --git a/backends/riscv_cfi.c b/backends/riscv_cfi.c
index 1a84a38..1c52ea8 100644
--- a/backends/riscv_cfi.c
+++ b/backends/riscv_cfi.c
@@ -31,7 +31,7 @@
 
 #include <dwarf.h>
 
-#define BACKEND aarch64_
+#define BACKEND riscv64_
 #include "libebl_CPU.h"
 
 
-- 
1.8.3.1