From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id CD6373982414
 for <elfutils-devel@sourceware.org>; Thu,  8 Jul 2021 09:37:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD6373982414
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 38A8E302FBA6;
 Thu,  8 Jul 2021 11:37:51 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 87D16401EDBE; Thu,  8 Jul 2021 11:37:50 +0200 (CEST)
Message-ID: <086caea17d4700ae2d6ead8d722906002bdcb475.camel@klomp.org>
Subject: Re: [PATCH] libelf: Fix unaligned d_off offsets for input sections
 with large alignments
From: Mark Wielaard <mark@klomp.org>
To: Andrei Homescu <ah@immunant.com>
Cc: elfutils-devel@sourceware.org
Date: Thu, 08 Jul 2021 11:37:50 +0200
In-Reply-To: <CAGynJTV5x0QDqP-kam5kzMPCbL-xt_d=P6Xq52EnyadKQJ=OmA@mail.gmail.com>
References: <20210629012653.2375942-1-ah@immunant.com>
 <9d78443192899df450e3f1128b7692c55e3e6bf6.camel@klomp.org>
 <CAGynJTV5x0QDqP-kam5kzMPCbL-xt_d=P6Xq52EnyadKQJ=OmA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jul 2021 09:37:55 -0000

Hi Andrei,

On Wed, 2021-07-07 at 13:24 -0700, Andrei Homescu wrote:
> I wrote this patch on behalf of someone else, so the copyright line
> should be:
> Copyright (C) 2021 Runsafe Security, Inc.

OK, changed.

> > The testcase already fails before the patch and succeeds after, but
> > it would be nice to double check the output with elflint just in
> > case. Shall we add:
> >=20
> > testrun ${abs_top_builddir}/src/elflint --gnu $outfile
>=20
> Sounds good, no objection from me.
> Should I submit an updated version of the patch, or can you add this
> on your end?

I made those two tweaks and pushed as:

https://sourceware.org/git/?p=3Delfutils.git;a=3Dcommit;h=3Db3601167d7a4c9f=
34eb65c3892c9ef25e3c1c66f

Thanks,

Mark