From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH] Arm Ehdr flag printing
Date: Mon, 06 Jun 2022 13:35:43 +0200 [thread overview]
Message-ID: <08d9442f61b46a0fe64449c7f613a253039797cf.camel@klomp.org> (raw)
In-Reply-To: <20220601143120.18204-1-mark@klomp.org>
On Wed, 2022-06-01 at 16:31 +0200, Mark Wielaard wrote:
> From: Ulrich Drepper <drepper@redhat.com>
>
> Arm needs to decode flags and I modeled it after the binutils code.
> The same messages are printed. Given the requirement of the
> interface
> and the ABIs the current version of the callback function isn't
> sufficient unless one wants to create a stateful interface. The
> problem is that most flags need to be interpreted in the context of
> the ABI version. So I changed the API to also pass the original flag
> value. This shouldn't be a problem because there are no users yet.
>
> There is also a bug in ebl_machine_flag_name. When copying the string
> provided by the callback cp is moved past the NUL byte. It should
> move to the NUL byte. Otherwise one cannot anything but the first
> added flag description. Finally some cosmetic changes (space after
> each comma in the output).
Pushed.
Cheers,
Mark
prev parent reply other threads:[~2022-06-06 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 14:31 Mark Wielaard
2022-06-06 11:35 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08d9442f61b46a0fe64449c7f613a253039797cf.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).