public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Cc: Jonathon Anderson <jma14@rice.edu>
Subject: Re: [PATCH 1/2] Add configure options for Valgrind annotations.
Date: Thu, 07 Nov 2019 17:19:00 -0000	[thread overview]
Message-ID: <0a847bd00d2334e189d876613ff08d32ca0f7f12.camel@klomp.org> (raw)
In-Reply-To: <20191029211437.3268-1-mark@klomp.org>

Hi Jonathon,

On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote:
> +2019-08-25  Jonathon Anderson <jma14@rice.edu>
> +
> +	* configure.ac: Add new --enable-valgrind-annotations
> +	* configure.ac: Add new --with-valgrind (headers only)

I think this looks fine. In theory we could also try to use pkg-config
checks, since valgrind does ship a valgrind.pc file. But various
distros don't actually ship that :{ So it is probably not worth it.

I must admit that I don't actually understand how the annotations
really work, see comments on the other patch.

Thanks,

Mark

      parent reply	other threads:[~2019-11-07 17:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 18:55 [PATCH 0/2] libdw: Rewrite the memory handler to be more robust Jonathon Anderson
2019-10-29 20:17 ` Mark Wielaard
2019-10-29 20:22   ` Jonathon Anderson
2019-10-29 21:15     ` [PATCH 1/2] Add configure options for Valgrind annotations Mark Wielaard
2019-10-29 21:15       ` [PATCH 2/2] libdw: Rewrite the memory handler to be more robust Mark Wielaard
2019-11-07 17:20         ` Mark Wielaard
2019-11-07 18:13           ` Jonathon Anderson
2019-11-08 16:22             ` Mark Wielaard
2019-11-07 18:40           ` Jonathon Anderson
2019-11-08 16:22             ` Mark Wielaard
2019-11-08 17:41               ` Jonathon Anderson
2019-11-07 17:19       ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a847bd00d2334e189d876613ff08d32ca0f7f12.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=jma14@rice.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).