From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84146 invoked by alias); 7 Nov 2019 17:19:31 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 84134 invoked by uid 89); 7 Nov 2019 17:19:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:638, valgrind, annotations X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2019 17:19:29 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 9F566300073F; Thu, 7 Nov 2019 18:19:26 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 57C074970340; Thu, 7 Nov 2019 18:19:26 +0100 (CET) Message-ID: <0a847bd00d2334e189d876613ff08d32ca0f7f12.camel@klomp.org> Subject: Re: [PATCH 1/2] Add configure options for Valgrind annotations. From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: Jonathon Anderson Date: Thu, 07 Nov 2019 17:19:00 -0000 In-Reply-To: <20191029211437.3268-1-mark@klomp.org> References: <1572380520.19948.0@rice.edu> <20191029211437.3268-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00109.txt.bz2 Hi Jonathon, On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote: > +2019-08-25 Jonathon Anderson > + > + * configure.ac: Add new --enable-valgrind-annotations > + * configure.ac: Add new --with-valgrind (headers only) I think this looks fine. In theory we could also try to use pkg-config checks, since valgrind does ship a valgrind.pc file. But various distros don't actually ship that :{ So it is probably not worth it. I must admit that I don't actually understand how the annotations really work, see comments on the other patch. Thanks, Mark