From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id E6B1B3985C37 for ; Tue, 3 Nov 2020 17:26:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E6B1B3985C37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id F006C30291AB; Tue, 3 Nov 2020 18:26:07 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id DE636420141B; Tue, 3 Nov 2020 18:26:07 +0100 (CET) Message-ID: <0cf2d2b046ab154c505d3c70deee613f809ea6df.camel@klomp.org> Subject: Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD From: Mark Wielaard To: "Frank Ch. Eigler" Cc: Vitaly Chikunov , elfutils-devel@sourceware.org Date: Tue, 03 Nov 2020 18:26:07 +0100 In-Reply-To: <20201103170739.GD22258@redhat.com> References: <20201102080000.GA22615@altlinux.org> <20201103170739.GD22258@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 17:26:10 -0000 Hi Frank, On Tue, 2020-11-03 at 12:07 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > > While packaging I noticed that we install the profiles.d files even > > when the DEBUGINFOD_URLS is empty. I think we should avoid that. >=20 > I think we should install them anyway. They give a sysadmin an easy > knob to set a systemwide default, even if the distro build didn't. That is a good point. But I think the default setting is wrong if it isn't actually used/setup. As the profile shell snippets are now they define the DEBUGINFOD_URLS environment variable as an non-empty string (although just containing spaces), which makes anything using libdw/libdebuginfod do extra work because we have to assume there is some server defined. Is there a way to make it so that even if the profiles are installed the DEBUGINFOD_URLS is not defined or is the empty string if --enable- debuginfod-urls isn't given? Thanks, Mark