* [PATCH v3] backends/ppc_initreg.c: include <asm/ptrace.h>.
@ 2021-02-05 17:52 Érico Nogueira
2021-02-05 18:00 ` Dmitry V. Levin
0 siblings, 1 reply; 3+ messages in thread
From: Érico Nogueira @ 2021-02-05 17:52 UTC (permalink / raw)
To: elfutils-devel; +Cc: Érico Rolim
From: Érico Rolim <erico.erc@gmail.com>
Necessary on musl for struct pt_regs definition, doesn't affect the
build on glibc, since <sys/user.h> includes the same header.
Signed-off-by: Érico Rolim <erico.erc@gmail.com>
---
backends/ChangeLog | 4 ++++
backends/ppc_initreg.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/backends/ChangeLog b/backends/ChangeLog
index f22cd57f..eb15c81d 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,7 @@
+2021-02-01 Érico Nogueira <ericonr@disroot.org>
+
+ * ppc_initreg.c: Also include <asm/ptrace.h>.
+
2020-12-12 Dmitry V. Levin <ldv@altlinux.org>
* aarch64_retval.c (aarch64_return_value_location): Fix spelling typo
diff --git a/backends/ppc_initreg.c b/backends/ppc_initreg.c
index 0e0d3599..e5cca7e1 100644
--- a/backends/ppc_initreg.c
+++ b/backends/ppc_initreg.c
@@ -33,6 +33,7 @@
#include <stdlib.h>
#if defined(__powerpc__) && defined(__linux__)
# include <sys/ptrace.h>
+# include <asm/ptrace.h>
# include <sys/user.h>
#endif
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] backends/ppc_initreg.c: include <asm/ptrace.h>.
2021-02-05 17:52 [PATCH v3] backends/ppc_initreg.c: include <asm/ptrace.h> Érico Nogueira
@ 2021-02-05 18:00 ` Dmitry V. Levin
2021-02-05 21:12 ` Mark Wielaard
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry V. Levin @ 2021-02-05 18:00 UTC (permalink / raw)
To: Érico Nogueira; +Cc: elfutils-devel, Érico Rolim
On Fri, Feb 05, 2021 at 02:52:06PM -0300, Érico Nogueira via Elfutils-devel wrote:
> From: Érico Rolim <erico.erc@gmail.com>
>
> Necessary on musl for struct pt_regs definition, doesn't affect the
> build on glibc, since <sys/user.h> includes the same header.
>
> Signed-off-by: Érico Rolim <erico.erc@gmail.com>
> ---
> backends/ChangeLog | 4 ++++
> backends/ppc_initreg.c | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/backends/ChangeLog b/backends/ChangeLog
> index f22cd57f..eb15c81d 100644
> --- a/backends/ChangeLog
> +++ b/backends/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-02-01 Érico Nogueira <ericonr@disroot.org>
> +
> + * ppc_initreg.c: Also include <asm/ptrace.h>.
> +
> 2020-12-12 Dmitry V. Levin <ldv@altlinux.org>
>
> * aarch64_retval.c (aarch64_return_value_location): Fix spelling typo
> diff --git a/backends/ppc_initreg.c b/backends/ppc_initreg.c
> index 0e0d3599..e5cca7e1 100644
> --- a/backends/ppc_initreg.c
> +++ b/backends/ppc_initreg.c
> @@ -33,6 +33,7 @@
> #include <stdlib.h>
> #if defined(__powerpc__) && defined(__linux__)
> # include <sys/ptrace.h>
> +# include <asm/ptrace.h>
> # include <sys/user.h>
> #endif
>
LGTM, thanks.
--
ldv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] backends/ppc_initreg.c: include <asm/ptrace.h>.
2021-02-05 18:00 ` Dmitry V. Levin
@ 2021-02-05 21:12 ` Mark Wielaard
0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2021-02-05 21:12 UTC (permalink / raw)
To: Dmitry V. Levin, Érico Nogueira; +Cc: Érico Rolim, elfutils-devel
On Fri, 2021-02-05 at 21:00 +0300, Dmitry V. Levin wrote:
> On Fri, Feb 05, 2021 at 02:52:06PM -0300, Érico Nogueira via
> Elfutils-devel wrote:
> >
> > diff --git a/backends/ppc_initreg.c b/backends/ppc_initreg.c
> > index 0e0d3599..e5cca7e1 100644
> > --- a/backends/ppc_initreg.c
> > +++ b/backends/ppc_initreg.c
> > @@ -33,6 +33,7 @@
> > #include <stdlib.h>
> > #if defined(__powerpc__) && defined(__linux__)
> > # include <sys/ptrace.h>
> > +# include <asm/ptrace.h>
> > # include <sys/user.h>
> > #endif
> >
>
> LGTM, thanks.
Actually tested against some older ppc, ppc64 and ppc64le setups and
things look fine. Pushed.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-05 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 17:52 [PATCH v3] backends/ppc_initreg.c: include <asm/ptrace.h> Érico Nogueira
2021-02-05 18:00 ` Dmitry V. Levin
2021-02-05 21:12 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).