From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id AC10C3858C5E for ; Thu, 23 Feb 2023 10:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC10C3858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 187C830067D6; Thu, 23 Feb 2023 11:44:45 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id D75EB340251; Thu, 23 Feb 2023 11:44:44 +0100 (CET) Message-ID: <0e511a59551aa3baa9321b3e80b70908b60051ad.camel@klomp.org> Subject: Re: [PATCH v2 02/16] move platform depended include into system.h of libebl From: Mark Wielaard To: Yonggang Luo , elfutils-devel@sourceware.org Date: Thu, 23 Feb 2023 11:44:44 +0100 In-Reply-To: <20221217165213.152-3-luoyonggang@gmail.com> References: <20221217165213.152-1-luoyonggang@gmail.com> <20221217165213.152-3-luoyonggang@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3029.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Sun, 2022-12-18 at 00:51 +0800, Yonggang Luo via Elfutils-devel wrote: > Because all source in libebl #include , so #include = in > libeblP.h is enough, there is multiple memory-access.h file, so use relat= ive path to > include it properly, See the discussion around v1 of this patch: https://inbox.sourceware.org/elfutils-devel/19dc6579ce183b63a8956b17611e4a2= 64d745b34.camel@klomp.org/ I have since pushed: commit 6ecd16410ce1fe5cb0ac5b7c3342c5cc330e3a04 Author: Mark Wielaard Date: Tue Dec 20 14:53:43 2022 +0100 Do not use relative include paths in library files. =20 Rely on include dirs being set up correctly. Setup libdw AM_CPPFLAGS to include libebl directory. In libdwfl note that debuginfod.h is a generated file in the builddir. Only include it in the one file debuginfod-client.c that really needs it. =20 Signed-off-by: Mark Wielaard Please adjust your patch accordingly. Thanks, Mark