From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6280 invoked by alias); 8 May 2017 10:42:16 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 6264 invoked by uid 89); 8 May 2017 10:42:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=*what, our X-Spam-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0096.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.96) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 May 2017 10:42:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m+a8ROuigAioan2wQ4CEhpL5pEBRZquK1xNJN6cT2ak=; b=AYr5Ky4Dy+Z1kL1uAQcVolnYNn9Cv/KmgzCE3oVq9cvDl+AK6R/0KmDm72kxBqX5EdnCotCMkoArbk/uNE0sdfgh7/lkOAB7VFhPxr5mLhp8sU1dEMeRYH47RrWhnAW822xJVaL0vqM6BWhxUDHINW1CghcHF6F2U3TzMjFL0F8= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; Received: from [10.9.78.56] (62.220.2.194) by DB4PR02MB238.eurprd02.prod.outlook.com (2a01:111:e400:289f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Mon, 8 May 2017 10:42:12 +0000 From: Ulf Hermann Subject: [PATCH v2] Cast pid_t to long long when printing To: Message-ID: <0e73b569-766f-62a3-a03d-533f46329aa0@qt.io> Date: Mon, 08 May 2017 13:05:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: DB6P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::34) To DB4PR02MB238.eurprd02.prod.outlook.com (2a01:111:e400:289f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 653f24fa-47fe-4a55-ed4d-08d495fee2d2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DB4PR02MB238; X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB238;3:Tcgyt08FNAP5mSQwwQT/R7B8AmfvfJYDgGD/Db91OVlKRs4VEWPQAuRb6wZB8hW2zGy2TxG4hkD5KXe4PrDF5cqxv781fRY0In5ucD5GaM/wgg4C1jc7R8LeGKaUL0pftNQDeWDtXwRqcWUlVMzdLWsCkgUfBoCX0MlumPxaN7xMPFW+zFya31G+E3J6JI4ESYL28mj1cQGjdhtsexv4aE4lxa/N7ZJKyZ/PmTqva86Z68FxSZgF9u0qywZUq3aemiItaSP2EtW+4oiX1oZkfhR/OuX1QBEyOMxBpAutDnBgoOjXP/2XFmr2NDHemDhdck1iFQJ0J/4BcOhCzSzqMA==;25:WWjPtxpm3WyVLfqd2QlVT2mGH1CzKnSjLMKyOc18jM69MX/rlASPvr0TPtt+iWwCR6TM7GKLePHenUYbw4IQl90ewRyhgvyUC5YGFO+pDuLCgwCAIb/ym2lymaWKeYh3IZ9/EweNGNCDXAiUE6onivoLk1tEaao5Crb2JYWXXbbQY1sZonpCIkBHzUvYBPR6aOlF4VGnFstiYvFBm627oMj35MrgZenOhl7z0ZpguPT7IDA/heCL6XV3uv3VnmnVoAigyaUDcnhZ+3O/B2TxGmjswDU5nrFTu8DA1ydlmhLiyz+tCWFcUxuuGgB2nXnInSEd6ix1al7XhxSX7armt7GzFlLCIMM6SqKYSeHsLh+IK7t4vshpp5yUJT3BfSChlyuCXjnMdoGft6zDTjvd6iXY21HwD2QQo1ndHWSxp3fZ9F5Q3tVuXFImbpzqkDe50T5BhacZSmj0eH7vcTnXYMWdJ23xLeCK3VM1Gr4mzUA= X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB238;31:wcPEECnl13KsJwqLd2UFJtQkcwdJ/dercPtGHprobN7Jqj4LHXG1mYZaFZsQHNMQaVLlc9IJgMyY1wlkPPt89XyY23j2D7vtXysX+jQAl6u42h+anMvAi3L3hz9oWyy80tsbTa9xzL0WAlqneoHQt8IBBb42QJy72m7Xwi2+2nBbTrUnHYUdBqpb0YIAW4G5AQOFBm4CPbH1c55JyiUXG7i1F/TUgRjk3Pfyr4UlUZud0m40acRORHNoaxh+f1eHO+tcZzIXb3bgITuBJLvqQG32F8Jzu6qHsLLxS9XZc0U=;20:wlaf8PmltPTm2B5uW1ivpFraYrJtsZBitBySAQntpHhpYelAabo/CpmGdnVQa1K/ow1lbAiahzIFbXBZEL2PaCTFDvRIr8/DhY6bWGg8lk2C/h7J4BSZ4cr0xcV1vpAwKr5X5xQFNhPyCLe+FVIDobsQdanf56RCzabDn4/U1RVlsVngr/AUexrGv2fgOfdPU5XZn3rf9mrenyGTtL1HMb2kU2pkLG+FLTQc+oUHa9aCCGeTcKophWwQEEZYAQVF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148);SRVR:DB4PR02MB238;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB238; X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB238;4:M/gE+mPME+MyzSIa1O/994L3q3PlWoFC02qjbKSfTRR19YNC6Rza0rLq0Vrbh0rsrImGQkgXPuAccX4ZXxWeP97BuEgFCUe0AzDaUH30OBI0B3MFpoNQZvUf9o024VvTPutyNwQuj1u+jCHq5zfU5mzZS8ZLqzEpCmBLHra/mGv5hOWqXSOA8x4KRyqRPHpCKttBsnGKy3IHnuSg4EcEAkNZpWdtAd1LMzTReik156Jjfg1VyAa6OsJKWpONVXB0c4G6Z86ikWPOE9ooHbSmr2PeFSFRrnqA7uzLfwotPCC3B5fbVPXj1mR31uvCZXRUBFat4w2naZPACeD13pOTtcMtfE+UBGbcaCnly0x45Hnvkf+9UyQhYuay8n5bt6l6XBijcJ8mspO2LyFewq73PkTpX9kPejTnOIIWrzz1ZjmC29jdO0EHup7x0/9pVQDlj3nQkP/ujNU9Hfbp4OAJgSWmwuf5CQuz2YU+pRIvN55XNn0vfzLV392ldtsIel0lbshv+bHbNlteQxAgaF5ic1RXLcGSqRn+UZj4MS8fXcbtQyZGYOQTOq93OjnVQLT6AoSLQVEJRX54Krt7KdPinrBvUcvjNNigwpgOyNIc1Gd1Dlwwqt+C4V9UNrAiEjWlme568nRMID3ZCl8gUvhvXkT2UkSQPOmqDDskVuPygpBdcCONl5fhZaoDERf8U/WZKEfn2czzbjBJpeOYoAOgc5dux66cWxn1sbBV1jtNSpwFRYxAHpIXOred398UQdQo4iXarfEghVeVCS9HmKRWzXlPqWyXEQaeZNik8apihx4= X-Forefront-PRVS: 0301360BF5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39830400002)(39400400002)(39410400002)(39450400003)(377424004)(110136004)(2351001)(77096006)(66066001)(65956001)(47776003)(86362001)(189998001)(5890100001)(6486002)(5660300001)(6116002)(36756003)(38730400002)(3846002)(81166006)(31696002)(31686004)(42186005)(50466002)(8676002)(230700001)(53936002)(2906002)(7736002)(4001350100001)(305945005)(3260700006)(25786009)(50986999)(54356999)(74482002)(83506001)(478600001)(23676002)(33646002)(6666003)(64126003)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:DB4PR02MB238;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjAyTUIyMzg7MjM6L09QcmNvTytpa29mZTNlZnFLR3JPUHpRZit0?= =?utf-8?B?MkNnNlpvc0c3OTVtVnE5c2IvQmVZZFZwRmwvcmVFSTNPNm53TStqcHBnTXRL?= =?utf-8?B?T0h6aE9zUnU2V21ia0dlZTI0UkdtK1Y5Z0JodVB1S2RWbVBYNlFWRTkxL3Rh?= =?utf-8?B?bmY3RVJFVEZhaFVBNUFLRjB4QWQ1RWxEMmpRaTJVMWNRKzhnOHBNQjgzbEk3?= =?utf-8?B?bGtRVFZCK3QxNzhRT2N4UGYvQ2xCcExMUjFwV0dUendPSDd1SE1lWHJvMEdI?= =?utf-8?B?R09ONUFHbEN6RmZrR2dUV25pcGR0RXFXbUFRV29meXpmeUw2K1VXSjhnMU1H?= =?utf-8?B?OEduVUFCV0JMUG8zc09OOGQxZTJiOUNqcXMxd2NhMXhxUUV2SnVxRDlaUjc3?= =?utf-8?B?NmFFN2oyQllkSzNVWmRYdklaSlV0MzF4WXhhUUUrRDVPUDFFODFUSnNaWDh6?= =?utf-8?B?YmpXYU4xdWJUUStZaXorSmJJZDVvUWN5TERJSE5ZS1ZHVUdGSkFrL0pQZlBa?= =?utf-8?B?Q2FETTNkcXlUUHc0M0VhWjFaVzZxRjF1cTdrUDd5djRzcnRZcm9mNnNhZ2hS?= =?utf-8?B?K1BLMGlDVUMrTXJPVklwSFhLNnRISnVQODFOMVc3TGZrZllQZEhyRmZoV21v?= =?utf-8?B?SEZCVW1UTXM4cjN5SXlZVjlIbmZiMldQak1NUUdRVGpjODM5eDRicENmMHpN?= =?utf-8?B?UlBSUVo5ci9uNFUvRVlXcDNXR0J2Snd2UjJWZ0JXR3IxUEk3RDQrTTUybFdI?= =?utf-8?B?elBFTDFVTHc1bmxYOXBVN2pCNDNuK3RwUWVXRTVQOENOcHJUZTMxVzEzaGhl?= =?utf-8?B?ZlhCUEVXRlYrdm5Sc3FNWC9OMTR3dVA4OVRoQlV1RWlaTy84Ri94azFIYlIw?= =?utf-8?B?b3RUdVlXb21VV3U4SklGUVcxQVhiMndEcTFnTEZCNTJJNDk1eW1xeEFRY2hl?= =?utf-8?B?eDZIaHhNSnFuTEg2cTlUNkh6dHBpM1h5MGt6QkhwRTFvTGlSR0xhZUpHcXc0?= =?utf-8?B?Q3ZzK1F2R2xudkVzcVlualFaV21takRnY2s1OHJ4Q0laQVRRdDREaU53S09F?= =?utf-8?B?d0plKzc1amNMS3dZK2JXNmJpSEprTEJRRVJ2SDBua1drYnNjSWRRZDh0Qlkx?= =?utf-8?B?N29XUTYyb2FhaG84UVI5OFMyS0JHa1FobzZ2SEtWQjFMTlRPTG1FWFlSSDFH?= =?utf-8?B?SnVDaG9yaWo5Q3Z1SEdINDBSQkVET3FYYXVCMCtxd3Q2em41VlNSODlSY1I0?= =?utf-8?B?ZE5MUkFxclB0WXUxcitkM3p1WGRBNmpxRTdvcTNZMHQ3YzExbVQ5UmJrS2FE?= =?utf-8?B?OUg1ekFzRFZiL3VzRzNXbDByazV1QmdzWkUrWkd0VXJWZit2WWVDdlVlMTFD?= =?utf-8?B?TjVyY0dvd0I3Sjl4ZllMc2pKMVpWT21ReG4vWDZmOG8xaFRWMndrUmcyNEcz?= =?utf-8?B?NlA5Y284dkFzd1h4ZWF5YmxIYWZONTRrU09sTUVIcFpqR015L01tSXlIcnFj?= =?utf-8?B?UzlaeERzSmZOWG5vR0tXZmFnbFdvc3ZSdndMQ0FKUkRZM01pYlhucnQzODdM?= =?utf-8?Q?sdPUY9w8aiLxnQdSJVS1WHfTA5bf+v1yTCdG8laJZZs=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB238;6:wSi/ij3rQfZhXvv+N5qc64BLnMv4Jlh7eqdQqR/FodvvG8s24ea22PdLDNzkvSSkGYD2fJmQAjQpkQhQmedY18re1SxVahWcyFaOMhb1UZhErX/K6oIb3E6djeTrKInbzPd+ZG/6cCsQ1UrjHmSZWBjYrTrnjv0qGy45Ddr1fDB+JEQdlkStKA0c8MhVTA2dHnppeegjvd+a2UHZzOKwS8KTo9+8WTcZAuryPhJvXey50wEllvccV1CGeCcj140KmZMPCC708oHJrZ1VsOGmIC4TF4kRZrHWhaiR3qpVeJuC2KdVQ/ORgP+2AosSISLaWTso+nStDt/xppGUVUBldkBJ7sWSr79VQu1k6ia+lPnZvkItx4n5F5EXKSb5Aoa84jx7RRkm/Y69nhGJRhRm3uVV8dJLcknFRNcOZPvSLDnreLbQVMiulw7sDqnmpeKUczZ9lGA+nksvUS5kESkQFZ9FA5yJsoed2RJJ197R2zYo8ei2Qn7ucG6CaKJUoh5NN4jBp/iTcIvD6c6tor3aFw==;5:wMq7OtJe3urh6Do5NTfD7ORwBj3Bw7ZAP9kjw22YMCzoT29brIZHVlZctnlqF7acrxHy4rDoDKiwQuVG3/N6hvKn5Sg8sBtL6YHe3Q1EFt5YDIqhYC4KNjypd2kQsa54dmwA1se+rjkoSpbRmpmDIFjjHO/KyamPZtNmfG+tfWI=;24:CCRBCb2h2B/Fxl3QGF/NaL2vm34l4eA8bRW7RzIqxcPR+9bvft3eNTMDZokhTQyGK76opajrM57/FWmLlIa+jSEg8SDkvVvQiO3p/KQheLU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB238;7:tAGOXhOo1uFjNRBjVWxKWB/ve18xZGCbPZSajBP2taMmckf7SOnpJIz/JvtQtyf9ikY3NRonuZQHCZvWXMO6A4petvDN1XL1hKKTyOQkj1DpNe6ZneUNzI6nEs1YDyiUS7lgOf8XDBTOPfdlqtr8unN0h2AFx+4ULm4/EhLIK51UGKpGIiWR83yAfcDFPPj4M1R8l1tVyXNtFbe5P5cUeQT3S6WMpMBVTYk/l2URyXHsVEPJ4MtO651qSjKyMYVPKaAL9PMk7VB6OQPt2vHie3JbJV4lsaN6MxgNXKPU2YJKnaSvhAow/n85JfJBwBySUBItsFNXqGn32EQ+4jkc1A== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2017 10:42:12.4694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB238 X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00201.txt.bz2 On windows x86_64 pid_t is 64bit wide. We need to adapt our printf format respectively. (We can actually print the extra bits in a portable way, so let's do it rather than casting to int and ignoring them.) Signed-off-by: Ulf Hermann --- src/ChangeLog | 4 ++++ src/stack.c | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index a474331..1c67b57 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,9 @@ 2017-05-04 Ulf Hermann + * stack.c: Cast pid_t to int when printing using %d. + +2017-05-04 Ulf Hermann + * strip.c: Close and reopen file when renaming. 2017-05-04 Ulf Hermann diff --git a/src/stack.c b/src/stack.c index 1f5a1c6..da912e5 100644 --- a/src/stack.c +++ b/src/stack.c @@ -362,7 +362,7 @@ print_frames (struct frames *frames, pid_t tid, int dwflerr, const char *what) if (frames->frames > 0) frames_shown = true; - printf ("TID %d:\n", tid); + printf ("TID %lld:\n", (long long)tid); int frame_nr = 0; for (int nr = 0; nr < frames->frames && (maxframes == 0 || frame_nr < maxframes); nr++) @@ -419,8 +419,8 @@ print_frames (struct frames *frames, pid_t tid, int dwflerr, const char *what) } if (frames->frames > 0 && frame_nr == maxframes) - error (0, 0, "tid %d: shown max number of frames " - "(%d, use -n 0 for unlimited)", tid, maxframes); + error (0, 0, "tid %lld: shown max number of frames " + "(%d, use -n 0 for unlimited)", (long long)tid, maxframes); else if (dwflerr != 0) { if (frames->frames > 0) @@ -440,11 +440,11 @@ print_frames (struct frames *frames, pid_t tid, int dwflerr, const char *what) else modname = ""; } - error (0, 0, "%s tid %d at 0x%" PRIx64 " in %s: %s", what, tid, + error (0, 0, "%s tid %lld at 0x%" PRIx64 " in %s: %s", what, (long long)tid, pc_adjusted, modname, dwfl_errmsg (dwflerr)); } else - error (0, 0, "%s tid %d: %s", what, tid, dwfl_errmsg (dwflerr)); + error (0, 0, "%s tid %lld: %s", what, (long long)tid, dwfl_errmsg (dwflerr)); } } @@ -575,10 +575,10 @@ parse_opt (int key, char *arg __attribute__ ((unused)), int err = dwfl_linux_proc_report (dwfl, pid); if (err < 0) - error (EXIT_BAD, 0, "dwfl_linux_proc_report pid %d: %s", pid, + error (EXIT_BAD, 0, "dwfl_linux_proc_report pid %lld: %s", (long long)pid, dwfl_errmsg (-1)); else if (err > 0) - error (EXIT_BAD, err, "dwfl_linux_proc_report pid %d", pid); + error (EXIT_BAD, err, "dwfl_linux_proc_report pid %lld", (long long)pid); } if (core != NULL) @@ -597,10 +597,10 @@ parse_opt (int key, char *arg __attribute__ ((unused)), { int err = dwfl_linux_proc_attach (dwfl, pid, false); if (err < 0) - error (EXIT_BAD, 0, "dwfl_linux_proc_attach pid %d: %s", pid, + error (EXIT_BAD, 0, "dwfl_linux_proc_attach pid %lld: %s", (long long)pid, dwfl_errmsg (-1)); else if (err > 0) - error (EXIT_BAD, err, "dwfl_linux_proc_attach pid %d", pid); + error (EXIT_BAD, err, "dwfl_linux_proc_attach pid %lld", (long long)pid); } if (core != NULL) @@ -688,7 +688,7 @@ invoked with bad or missing arguments it will exit with return code 64.") if (show_modules) { - printf ("PID %d - %s module memory map\n", dwfl_pid (dwfl), + printf ("PID %lld - %s module memory map\n", (long long)dwfl_pid (dwfl), pid != 0 ? "process" : "core"); if (dwfl_getmodules (dwfl, module_callback, NULL, 0) != 0) error (EXIT_BAD, 0, "dwfl_getmodules: %s", dwfl_errmsg (-1)); @@ -721,7 +721,7 @@ invoked with bad or missing arguments it will exit with return code 64.") } else { - printf ("PID %d - %s\n", dwfl_pid (dwfl), pid != 0 ? "process" : "core"); + printf ("PID %lld - %s\n", (long long)dwfl_pid (dwfl), pid != 0 ? "process" : "core"); switch (dwfl_getthreads (dwfl, thread_callback, &frames)) { case DWARF_CB_OK: -- 2.8.1.windows.1