From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91393 invoked by alias); 25 Apr 2017 13:04:08 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 91378 invoked by uid 89); 25 Apr 2017 13:04:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1X9iRJJP7Ho5dBNgT4/GYz8FyDom8rv1lNdz96DHbG4=; b=HGwfcSyhu/gmu3Ot+qIugrtJbfVZGNOd4rku+h3W3nHF8eUaT1kEdS4CPYffmvQXe2ZaUZ5fX10vzC22f45tEq+eFDzBXczrlfaTpuG65V5SpXhVT1WePHh3Ge3OZZx5SFJOl7TDVtTmauOF7lyh8TqTkarnJCKXzouhfbgl0go= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; Subject: Re: [PATCH 4/5] Add i386 frame pointer unwinder. To: Mark Wielaard , References: <1493124006.31726.33.camel@klomp.org> <1493124579-21017-1-git-send-email-mark@klomp.org> <1493124579-21017-4-git-send-email-mark@klomp.org> From: Ulf Hermann Message-ID: <0f6a4585-7b24-0d6a-7d4e-33473671169d@qt.io> Date: Tue, 25 Apr 2017 13:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493124579-21017-4-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: VI1PR08CA0010.eurprd08.prod.outlook.com (2a01:111:e400:597a::20) To DB4PR02MB237.eurprd02.prod.outlook.com (2a01:111:e400:289f::11) X-MS-Office365-Filtering-Correlation-Id: 6ae4ef97-2f7f-4e46-c98b-08d48bdb8d5a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DB4PR02MB237; X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB237;3:IBp6BnEmqEZtpPEM3OiPdq7tvAHOFq8aNoTjPLIaALnTPuXcB3qimLEUTLN9OFghPm+psAQzfubLR9PznzHp4+yWivyRX2Sz/m9naU7P1Mxn0WMP26KMd4CjKW4RRh6xcmJqloZm4mjzDdRs+sjc64HzWPMKCCgo3+DIYDBE/mFyPKVNlvXeUwWIsxTgQt+foq3Aed43os5IXpbumhy5A26kIx0uqpQ44Yt/MtAMTsMeFr5mwP1UisuHrpQLKUIplFotnxC6XvW5wDfR3zJdtvxmLuOlp6pmARDnXc42g7lQkxZV6ynY2bwLBkELrKw6IkcKHKj26OO0PG4dpFHnQA==;25:1NpjsuNZAxwkOAvknGdLhkv/D2CquF/NByv6tLy3cNrhERSeO46T85Gu/B14Bj+K4RLkrp1gzsSCnDGZsV++0YWPSrGfKLYbTqB+vLC40XHle0WJZbeVWnWMiEjLnciqxVMSdrjjzv2JS70biFksnVfSfvw7iF8TRxUMz4vZowatSZynHAfZ2JSOHydFF5vdF8spocNuktvWcqPUZ8PCRYxMA1lLD5EeX0LetgUazT+QAjaljD+Pr1R6op/UZi8yQt0UmrAUYfYkruG1zHWOtpoAE0VHkgSatEiW8sIxgvKYNc6rGuxfy1QGznOO/qBum5qA3HMmZrpBvB53z9IbPEuF5OHbBZBbWEnWOgCDiwp7R6ICtkulxa62gwQaCdoJexwECKNXI7cADx+a0wjR3oUmhVp2S+gH4XVtd3DnM4Dk+lS5gvuUnzFnS6sK6qrZuIjxyNr7+9qTv8IqbTlErQ== X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB237;31:gjx7XXPQRTxAGWdSmr6ORreotmPwPRNyCGNnhFEiUmQdUj8JXfAvLeb+kpdfpDRBk4uNf5YTUu5PuTKr69Y3bXxMRbNGIVf9rsv3vdNoKlGLvOeUdZ9NqYQqY4GS9mEipfGJM5fur3ctikzmtCzkPmRzuMh8RuQVMoRhPHxSHGhySvKF2/TzAenBEYK36+cbsqzpN6WAbzlY4U9D0CaNOvD7jB1odJVfb00ZYCnWpOLO+Z1jePT/K76jdJAEkn1Dp0tou3EV5OXLXsF8iNDTMJfU63hXMNS+ZjvFZnyQHtw=;20:XrbtvzdUrm94rxdYQxj2LVO88QsMqlXVv4DNPEXlt0uoJ9DA/CsgjTZLmf66XypfuNEGvIHgYufSn2Zuan67LbjI+Oa4RUi4uXxi/cM/QHiDTWq8BkpC6qfpqcNIzcKozBIDU7Mk8978+Dwfzpyev294AQMT2wYmG6WJxC7zBlTuRl0CbtMDx4RYMCqv5M5dTCZd0wdCzC4mdiewSxyuCZVEJp+7ADn/pijtFN4dj+5YJzh4Z43vSFcHATjGKtCs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:DB4PR02MB237;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB237; X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB237;4:xmZxfAJlIRe6We9xAfxQH8957YDOJkVyH18UD1cc8RH9Ysgli2oW7s8kkQQZJqrDVsbetp9Am4qy6xfO192YTgZyrYsElbAqPZLkISOVDCsZg4/dSmBo8E4NRNUe1Rnyq52xfGUUUDGjw9QD39DppHZQT3cTWbO1YinlVR3fOhxyyymGWiAYN9xmfV4Zhk6gOl2Kf5MKQAnzUfZVyznvVryIPsxbZLVXonXfY62gyKVnRToKsbksGHVJ5Cu0zq6gAwqh5VwzeZj5GqCAZ3mAMSP/gtx244hlUsgoFEAA7Euiu9M1OODhzcbS6TgAj2tJnpDNRUgGvdM4HMmBW0fffzUXkja/dVi2cu26u5wJ8KasHH7Wp4IFIvup+2a7KBovkWuhLz70ANGCn1NDMKDe/UJFM3O7kKWvqVrF8PiVemn/ABMoGNjp/QTmjbeLaZSzJsf0xs+w1KxjbnrE9IF6UHCgKfmoyU5YF/fpE5ZPrplNknoceXEAQFyVF/zCvL/CLJ9bKkYBQFnYitKoi5Hivx724ZF0kJmMYAzIzFtI3xV+7FYrE1m4LdPoT+VnNWW0L5Ty0xBhGBc/ZvkS6Su8zc/4XZRE6sPDoiGi4EqX92p4G5TYES5wo5qfFKof0BOn+biSnTPxzXpBE1GjKG06gIYS2aJYU5vF/YSHY1uF63663Cyw17O9LDDarI8FIezpvjjC2NaSyF7wz/rppQP0DA== X-Forefront-PRVS: 0288CD37D9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39410400002)(39450400003)(39400400002)(39830400002)(24454002)(377454003)(65806001)(86362001)(65956001)(33646002)(66066001)(36756003)(83506001)(2906002)(189998001)(3846002)(81166006)(7736002)(8676002)(6116002)(31696002)(47776003)(5660300001)(65826007)(4001350100001)(230700001)(305945005)(6246003)(23676002)(2950100002)(76176999)(64126003)(54356999)(50986999)(42186005)(50466002)(31686004)(53936002)(38730400002)(229853002)(53546009)(6486002)(74482002)(25786009)(77096006);DIR:OUT;SFP:1102;SCL:1;SRVR:DB4PR02MB237;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjAyTUIyMzc7MjM6ZnJESWVTNEkxaU03RW1MeHRkby9yYWErcjJV?= =?utf-8?B?NjJRamFyL2VBTGdUc2FxMUMrOXVuWHl6MGVNQ3hubGYyS3RZV0NzcEdFY1JT?= =?utf-8?B?NDQycS9KdnNubzNYdElxSlZKMHJSY2xKd2liSzdiMkpGYzc4bjd6Y2xqd2kw?= =?utf-8?B?alM0bzNHVDVzZ09jelJRMWNEZEI2NG1wUTRsWHE1MXdXeTBudllZbWFraHRy?= =?utf-8?B?WmJWeGplaFpVcURub2FoQ0R5bnpWQWxhSk5qeVdWYUNMWWt0dUtKRkVzL1hQ?= =?utf-8?B?cWxYeTFzMDY2TDZJbHE2MFJDdXZrSjVQZy9kYlZwL1EvamRMbFRTQkRKT0Yr?= =?utf-8?B?UmtsZ3FFM1RTdUEvaFVmT2MwQTFNWFZ4TUFIbk0ybmQzNWo5S3BETGJqbGRm?= =?utf-8?B?TE1KOVB4VVUrL3hyL00yZE4wK3k2T3dLODVkWU9IVk1WWjV4b2dkMFFlejdK?= =?utf-8?B?NjBJaGZxZU1saXc0ZlZiZGlPcDNuZ3RqeHA1VDl0NzVzVlBWckFvK3NmL1ZI?= =?utf-8?B?YWtZcUtoQVBBZUNwaTBoeG9wZ0F5Q1hHanlyQzhaaHdINjdva2g0U25VdmVx?= =?utf-8?B?RXZwc2thdzZkaGVRNE9HeSszYlM5RHhPZXcxaTh5ZmZNRS9iT1dGV2FjY2Iy?= =?utf-8?B?akpJcm9aNDc4MXhOb1RqWTBwQjJlYTllWSt2VXlGZnRIamFia25DQnluNFRa?= =?utf-8?B?azd0Wk9kYnprVU9yQzdjaHIwby9QZzBZLy9XeGpqWlIvMldWaFJEL1oyQldk?= =?utf-8?B?bEk1WFNMZnVrTUNyWGhjQ2NTMmFlMzI3MmlGWUxDQ3RyQVppb0VJcmxodzc5?= =?utf-8?B?OXhiRSt5bVFKRjVHdVRNOEJLU01KM21GL2hWNGhQSjE2NVlSRzkvV3JmL21U?= =?utf-8?B?UC9GR0Q3aHdXSUw4dTAxUE9kdmVHdzVKQ1dyVmpabUxac08vaE1hYlBXNElS?= =?utf-8?B?b01wMnl4RCtWbldMVDFabmdTRVBtek5xTVBQMWpmb0tHdUdlM1duQ2N4bUtG?= =?utf-8?B?VlRlWFdlYlBtSjdWaHZDZmN5RTArVU5CQnFmRUhpaGJGa0IvMWVkcGZ6YThy?= =?utf-8?B?czVldG5DeTJ1dUpkT0JmZlY2Q05pczlnbjlUT1Rkd2lUWUV4RnVrNmxhSzd3?= =?utf-8?B?VkRnbFFXdXp1S2VDZncwckhyUWV6eUR0MGZWL0FTMjdpUWR2OUpKaTg5YTNJ?= =?utf-8?B?eTVUOW9kQzlIRXcya0ZGQmNxbVRMcW1adUtYaURXZHZRc2liTzg5YWFIclpB?= =?utf-8?B?TldEVVdrZTR2STVITWc5WTFRZEVQQndqc3dmRDMwV1c2cHpvMDFWbkQ0ZUhl?= =?utf-8?B?eDdsdlVxOVRMWmpkQWFETW1GWm05MHpqbDNWSGU4SVMxYnRPblZjV1pBNlFu?= =?utf-8?B?UWswNm1wNWRSaHdYa2s4MjFLWlhkcUdYV09ieFVhSGc3RHdaN3hsMThIdk5L?= =?utf-8?B?SmxQV1J0ZDJuaktwb1pvTEhQbis2NWFrTVlRaUNtQnpMcmJWNVM3cldrTlRF?= =?utf-8?B?dlJvK0JSZkVYc09GNnlCNzRPcHJENDF5M2UxV0p1WU11NUl2UEhlNnppTjBQ?= =?utf-8?B?V2M1SE9IQW0xQ0JJVWdMcm9DUkc4MERpaG5na1JrcmFuWEtEbnp6Z0RMaExT?= =?utf-8?Q?qwMXCHHAdKgL19N3DH8?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB237;6:Ia5lSzEI3XijDd1ZJZ7EkiYyysr47hCQAoEABkMtohUWlQeFnt4+VlDhRiFiHSOwtsyhdwwcBcftjPQbJE0R+7dbXf0PNAV0HB8k3xAbSX6KdMPBUuPyuZRT22GjcQfq/ZnLwgKzracIPm+K+x6tS/dlK12NI+PM7AQHlSlS/cXeBfYQ14Hcsj3+rr8pySRv4dNmcipls7fJmlJ1WR6o3DnwUzKtuuUcycLOlWUjkhIATJqwIkeaEgm5mC9Idtr9Bza6wkFlXUsIAfHffFC1B46aWV2iDvFW9vaed3Pj0AWk4aHr2mjpe0FkWpKXkhLNR0VJxmVZwb6DC0vMkmzyKh4BTsghbkwgMfoNbbKHCmfPxyDR4M16D1F9yMWhPuWMxZeWL6QgPC1LJ+tMePOGDHa0u/Co8UAMOhdlj9G21rkeN4CxEWYq/rRb0Mh4nBXGm7/aa/Pe1nvKdLW0LkGeJF4atI6ZMX/wYoyH6+2NNwiFRFpwPzJDHl8F6/s2VITfY/CAI76Buh3DcsDkQ+y1VA==;5:fRxRXhFsyBjBra9sUf1A7FQc8RYoaAqihWcNTPcAcRlz9vPX7mMPvTkhLMpjzEdPcdWnfV6XVlgnh/gzYlgPSk8AiPeT+jjUBiLZIlpsT01AK4wskKx5YSuotgXDTMaPd3tF1i2p9tQo9zp2+6MsFw==;24:cXZQSPJuurgkDxXky9EFhbbTWPBvCWPVSJcPA+KF1z1eykE7VcCZUUw25aXe675Gr4IwdJT2XOQcgBTi6izDiYiKId3beLCvFfyIaJYRi3A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB4PR02MB237;7:+BZl/b4QRf6DR+URY3+P54SQ5Dxr040mVZAUjd5hJjmn6wznwM6Lm3WglDH0qVq664hWIhZHhmQpKw6SmuX5X7+uWx0sWerlDkI4iwwg7FJvuJW7tfasM8F5uzeIIWM1+FnynZDfkKkmSRMpPpHtzE7xlHv44XWY/GZHzhauJzexSroSYiHl4OLXdDwzSau229OG2uw5QeuidvIHB8jIaMEV2T7dEVASM/btQrhfStBMkdJuS1W6mHyHgUW0Oiex8pqrkY68coxQ83OmsLNYllF18ghsE0OSCBrxlv+uHosMS09x8ninW9BFoUW31PreEadibwoswh5GTEOm2C+UJw== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2017 13:04:04.9246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB237 X-SW-Source: 2017-q2/txt/msg00089.txt.bz2 On 04/25/2017 02:49 PM, Mark Wielaard wrote: > Add a simple i386_unwind.c frame pointer unwinder as fallback if DWARF/CFI > unwinding fails. Looks good to me. The logic could be relaxed a bit so that failure to e.g. write the new value for sp would not be fatal. Then we might be able to unwind even more frames. But refusing to unwind obviously broken frames is acceptable, too. Ulf