On Wed, 2014-04-23 at 00:54 +0200, Kurt Roeckx wrote: > On Wed, Apr 23, 2014 at 12:26:53AM +0200, Mark Wielaard wrote: > > On Tue, 2014-04-22 at 21:52 +0200, Kurt Roeckx wrote: > > > The attached patch seems to be working for me on kFreeBSD. > > > > Looks reasonable to me. The other arch backends that provide an initregs > > could probably use the same conditional (but that can wait till someone > > actually needs it/can test it). > > > > Would you mind looking at the CONTRIBUTING file and add a Signed-off-by > > line if you agree with what is said there? > > I forgot to add it, I only remembered after I mailed it. Thanks, I have added it to the commit and pushed it to master. I am afraid we will have to rely a little on you to make sure other stuff doesn't break on non-GNU/Linux setups. > > > PS: run-nm-self.sh fails for me for current master. > > > > How does it fail? Do you have a tests/run-nm-self.sh.log? Which arch? > > File is attached. This is on x86_64. Aha. I think this is because you are using a /bin/sh that isn't bash and has a 'test' that doesn't recognize '==' as string comparison. It should use a single '='. Does the attach fix it for you? Cheers, Mark