Re: [PATCH] readelf: Skip section if name is NULL in print_debug.

Re: [PATCH] readelf: Skip section if name is NULL in print_debug.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

On Tue, 2014-05-27 at 10:28 +0200, Mark Wielaard wrote:
> Don't crash and burn when a section doesn't have a name (possibly invalid
> ELF file string table). Just try the next section instead of calling
> strcmp on NULL. 

Pushed to master.

[PATCH] readelf: Skip section if name is NULL in print_debug.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

Don't crash and burn when a section doesn't have a name (possibly invalid
ELF file string table). Just try the next section instead of calling strcmp
on NULL.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 src/ChangeLog |    4 ++++
 src/readelf.c |    4 +++-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/src/ChangeLog b/src/ChangeLog
index 5535cff..7e68036 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2014-05-27  Mark Wielaard  <mjw@redhat.com>
+
+	* readelf.c (print_debug): Skip section if name is NULL.
+
 2014-05-26  Mark Wielaard  <mjw@redhat.com>
 
 	* readelf.c (handle_relocs_rela): Print header like handle_relocs_rel
diff --git a/src/readelf.c b/src/readelf.c
index ea14a09..6bbe436 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -7962,8 +7962,10 @@ print_debug (Dwfl_Module *dwflmod, Ebl *ebl, GElf_Ehdr *ehdr)
 				       / sizeof (debug_sections[0]));
 	  const char *name = elf_strptr (ebl->elf, shstrndx,
 					 shdr->sh_name);
-	  int n;
+	  if (name == NULL)
+	    continue;
 
+	  int n;
 	  for (n = 0; n < ndebug_sections; ++n)
 	    if (strcmp (name, debug_sections[n].name) == 0
 #if USE_ZLIB
-- 
1.7.1