From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] aarch64: use <sys/user.h> defined register structures
Date: Tue, 10 Jun 2014 11:51:48 +0200 [thread overview]
Message-ID: <1402393908.3940.41.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: 20140609190626.GF14956@toonder.wildebeest.org
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Mon, 2014-06-09 at 21:06 +0200, Kyle McMartin wrote:
> glibc now supplies these (compatible) structs instead of including the
> kernel's <asm/ptrace.h> header, so let's use them. Annoyingly this will
> cause new elfutils to FTBFS on old glibc, and vice versa, but that seems
> unavoidable in the growth of a new port, and the workaround of checking
> for header defines and defining one to the other seems unpleasant as
> well. Therefore, bite the bullet, and let packaging systems alter their
> build requires accordingly.
That is indeed annoying, but using the glibc defined structs seems to be
the right thing to do. Do you know which glibc version introduced them?
BTW. For this trivial patch it doesn't really matter, but in general we
like to have a Signed-off-by line for all patches to indicate
contributors know about and agree with our CONTRIBUTING guidelines.
Would you mind adding one?
https://git.fedorahosted.org/cgit/elfutils.git/tree/CONTRIBUTING
Thanks,
Mark
next reply other threads:[~2014-06-10 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 9:51 Mark Wielaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-01 12:38 Kyle McMartin
2014-08-01 10:42 Mark Wielaard
2014-07-18 13:53 Mark Wielaard
2014-06-12 12:37 Mark Wielaard
2014-06-10 13:37 Kyle McMartin
2014-06-09 19:06 Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402393908.3940.41.camel@bordewijk.wildebeest.org \
--to=mjw@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).