From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] libebl: Add ebl_unwind_ret_mask.
Date: Sun, 15 Jun 2014 20:42:12 +0200 [thread overview]
Message-ID: <1402857732.21102.12.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: 20140615181802.GA7176@roeckx.be
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Sun, 2014-06-15 at 20:18 +0200, Kurt Roeckx wrote:
> On Sun, Jun 15, 2014 at 12:30:02PM +0200, Mark Wielaard wrote:
> > + /* Mask to use to get the return address from an unwind in case the
> > + architecture adds some extra non-address bits to it. When not
> > + initialized (0) then ebl_unwind_ret_mask will return ~0, otherwise
> > + it should be the actual mask to use. */
> > + GElf_Addr unwind_ret_mask;
>
> Shouldn't that be an Elf64_Addr?
No. None of the unwinder uses Elf32 or Elf64 specific types. GElf_Addr
is used here so the unwinder code doesn't need to care about 32-vs-64
issues.
Cheers,
Mark
next reply other threads:[~2014-06-15 18:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 18:42 Mark Wielaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-17 14:50 Mark Wielaard
2014-06-17 6:56 Mark Wielaard
2014-06-16 22:23 Roland McGrath
2014-06-15 21:51 Kurt Roeckx
2014-06-15 20:21 Mark Wielaard
2014-06-15 19:59 Kurt Roeckx
2014-06-15 19:27 Kurt Roeckx
2014-06-15 18:56 Mark Wielaard
2014-06-15 18:47 Kurt Roeckx
2014-06-15 18:38 Mark Wielaard
2014-06-15 18:18 Kurt Roeckx
2014-06-15 18:08 Kurt Roeckx
2014-06-15 10:50 Mark Wielaard
2014-06-15 10:39 Kurt Roeckx
2014-06-15 10:30 Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402857732.21102.12.camel@bordewijk.wildebeest.org \
--to=mjw@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).