From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] readelf: Fix typo in a check in handle_relocs_rela
Date: Tue, 23 Sep 2014 14:25:48 +0200 [thread overview]
Message-ID: <1411475148.27706.32.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: ab422506e9a55bff3c7c34a41b570021c274596a.1410648838.git.pmachata@redhat.com
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
On Sun, 2014-09-14 at 01:03 +0200, Petr Machata wrote:
> - Testing shdr makes no sense, that pointer was dereferenced several
> times throughout the section. destshdr on the other hand is not
> tested at all.
>
> +2014-09-14 Petr Machata <pmachata@redhat.com>
> +
> + * readelf.c (handle_relocs_rela): Typo fix, test DESTSHDR properly.
Yes, seems obviously correct to me. The else branch would crash and burn
when trying to dereference destshdr->sh_name otherwise.
Thanks,
Mark
next reply other threads:[~2014-09-23 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 12:25 Mark Wielaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-23 13:07 Petr Machata
2014-09-22 22:15 Petr Machata
2014-09-13 23:03 Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411475148.27706.32.camel@bordewijk.wildebeest.org \
--to=mjw@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).