From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============3895107777476580691=="
MIME-Version: 1.0
From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] readelf: Fix typo in a check in handle_relocs_rela
Date: Tue, 23 Sep 2014 14:25:48 +0200
Message-ID: <1411475148.27706.32.camel@bordewijk.wildebeest.org>
In-Reply-To: ab422506e9a55bff3c7c34a41b570021c274596a.1410648838.git.pmachata@redhat.com

--===============3895107777476580691==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Sun, 2014-09-14 at 01:03 +0200, Petr Machata wrote:
> - Testing shdr makes no sense, that pointer was dereferenced several
>   times throughout the section.  destshdr on the other hand is not
>   tested at all.
>
> +2014-09-14  Petr Machata  <pmachata@redhat.com>
> +
> +	* readelf.c (handle_relocs_rela): Typo fix, test DESTSHDR properly.

Yes, seems obviously correct to me. The else branch would crash and burn
when trying to dereference destshdr->sh_name otherwise.

Thanks,

Mark

--===============3895107777476580691==--