From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2227839111988718226==" MIME-Version: 1.0 From: Mark Wielaard To: elfutils-devel@lists.fedorahosted.org Subject: Re: [PATCH] Add --core-pattern option to eu-stack Date: Mon, 03 Nov 2014 14:22:23 +0100 Message-ID: <1415020943.18323.67.camel@bordewijk.wildebeest.org> In-Reply-To: 1414706141.18323.39.camel@bordewijk.wildebeest.org --===============2227839111988718226== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, 2014-10-30 at 22:55 +0100, Mark Wielaard wrote: > I did have to lookup how to use this though. And I couldn't make it work > without adding an -o option to eu-stack to explicitly redirect output > since it seems you cannot use normal shell redirections > in /proc/sys/kernel/core_pattern. So I had to use something like > --output=3D/proc/%p/cwd/%i.stack. Where does the stdout of the > core_pattern end up otherwise? For reference. Attached is the cleaned up -o support patch I added. It is a little paranoid setting umask and using O_EXCL explicitly. But I think that is correct behavior when used in cases where normal shell redirection doesn't work. Cheers, Mark --===============2227839111988718226== Content-Type: text/x-patch MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-stack-Add-output-o-option.patch" RnJvbSA2ZTA2YzkxMWUxZDJhMGY5Y2JkMDdhNmJjYWE2Zjc2ZDZkNzY0OGI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTWFyayBXaWVsYWFyZCA8bWp3QHJlZGhhdC5jb20+DQpEYXRl OiBNb24sIDMgTm92IDIwMTQgMTQ6MTY6NTcgKzAxMDANClN1YmplY3Q6IFtQQVRDSF0gc3RhY2s6 IEFkZCAtLW91dHB1dCwgLW8gb3B0aW9uLg0KDQotbywgLS1vdXRwdXQ9RklMRSBQbGFjZSBvdXRw dXQgaW50byBGSUxFLiBGSUxFIHNob3VsZCBub3QgeWV0IGV4aXN0cyBhbmQNCiAgICAgICAgICAg ICAgICAgIHdpbGwgYmUgY3JlYXRlZC4NCg0KU2lnbmVkLW9mZi1ieTogTWFyayBXaWVsYWFyZCA8 bWp3QHJlZGhhdC5jb20+DQotLS0NCiBzcmMvQ2hhbmdlTG9nIHwgMTAgKysrKysrKysrKw0KIHNy Yy9zdGFjay5jICAgfCA1NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0tLS0tLS0tLQ0KIDIgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgMjAg ZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9zcmMvQ2hhbmdlTG9nIGIvc3JjL0NoYW5nZUxv Zw0KaW5kZXggYTI1MmNkYy4uNzBkNjMyNSAxMDA2NDQNCi0tLSBhL3NyYy9DaGFuZ2VMb2cNCisr KyBiL3NyYy9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTMgQEANCisyMDE0LTE5LTAzICBNYXJrIFdp ZWxhYXJkICA8bWp3QHJlZGhhdC5jb20+DQorDQorCSogc3RhY2suYyAoZm91dCk6IE5ldyBzdGF0 aWMgdmFyaWFibGUuDQorCShtb2R1bGVfY2FsbGJhY2spOiBmcHJpbnRmIHRvIGZvdXQuDQorCShw cmludF9mcmFtZSk6IExpa2V3aXNlLg0KKwkocHJpbnRfZnJhbWVzKTogTGlrZXdpc2UuDQorCShw YXJzZV9vcHQpOiBIYW5kbGUgJ28nLg0KKwkobWFpbik6IEFkZCAtLW91dHB1dCwgLW8gdG8gb3B0 aW9ucy4gU2V0IGZvdXQgdG8gc3Rkb3V0Lg0KKwlmcHJpbnRmIHRvIGZvdXQuDQorDQogMjAxNC0w OS0xNCAgUGV0ciBNYWNoYXRhICA8cG1hY2hhdGFAcmVkaGF0LmNvbT4NCiANCiAJKiByZWFkZWxm LmMgKGhhbmRsZV9yZWxvY3NfcmVsYSk6IFR5cG8gZml4LCB0ZXN0IERFU1RTSERSIHByb3Blcmx5 Lg0KZGlmZiAtLWdpdCBhL3NyYy9zdGFjay5jIGIvc3JjL3N0YWNrLmMNCmluZGV4IGMyNzdkZmQu LjBiMWQyMzUgMTAwNjQ0DQotLS0gYS9zcmMvc3RhY2suYw0KKysrIGIvc3JjL3N0YWNrLmMNCkBA IC0yNiw2ICsyNiw4IEBADQogI2luY2x1ZGUgPHN0cmluZy5oPg0KICNpbmNsdWRlIDxsb2NhbGUu aD4NCiAjaW5jbHVkZSA8ZmNudGwuaD4NCisjaW5jbHVkZSA8c3lzL3N0YXQuaD4NCisjaW5jbHVk ZSA8c3lzL3R5cGVzLmg+DQogI2luY2x1ZGUgRUxGVVRJTFNfSEVBREVSKGR3ZmwpDQogDQogI2lu Y2x1ZGUgPGR3YXJmLmg+DQpAQCAtOTcsNiArOTksOSBAQCBzdGF0aWMgY2hhciAqZGVtYW5nbGVf YnVmZmVyID0gTlVMTDsNCiAvKiBXaGV0aGVyIGFueSBmcmFtZXMgaGF2ZSBiZWVuIHNob3duIGF0 IGFsbC4gIERldGVybWluZXMgZXhpdCBzdGF0dXMuICAqLw0KIHN0YXRpYyBib29sIGZyYW1lc19z aG93biA9IGZhbHNlOw0KIA0KKy8qIFdoZXJlIC0tb3V0cHV0Ly1vIGdvZXMgdG8gKHN0ZG91dCBi eSBkZWZhdWx0KS4gICovDQorc3RhdGljIEZJTEUgKmZvdXQ7DQorDQogLyogUHJvZ3JhbSBleGl0 IGNvZGVzLiBBbGwgZnJhbWVzIHNob3duIHdpdGhvdXQgYW55IGVycm9ycyBpcyBHT09ELg0KICAg IFNvbWUgZnJhbWVzIHNob3duIHdpdGggc29tZSBub24tZmF0YWwgZXJyb3JzIGlzIGFuIEVSUk9S LiAgQSBmYXRhbA0KICAgIGVycm9yIG9yIG5vIGZyYW1lcyBzaG93biBhdCBhbGwgaXMgQkFELiAg QSBjb21tYW5kIGxpbmUgVVNBR0UgZXhpdA0KQEAgLTE0Nyw3ICsxNTIsNyBAQCBtb2R1bGVfY2Fs bGJhY2sgKER3ZmxfTW9kdWxlICptb2QsIHZvaWQgKip1c2VyZGF0YSBfX2F0dHJpYnV0ZV9fKCh1 bnVzZWQpKSwNCiAgIGFzc2VydCAoc3RyY21wIChtb2RuYW1lLCBuYW1lKSA9PSAwKTsNCiANCiAg IGludCB3aWR0aCA9IGdldF9hZGRyX3dpZHRoIChtb2QpOw0KLSAgcHJpbnRmICgiMHglMCoiIFBS SXg2NCAiLTB4JTAqIiBQUkl4NjQgIiAlc1xuIiwNCisgIGZwcmludGYgKGZvdXQsICIweCUwKiIg UFJJeDY0ICItMHglMCoiIFBSSXg2NCAiICVzXG4iLA0KIAkgIHdpZHRoLCBzdGFydCwgd2lkdGgs IGVuZCwgYmFzZW5hbWUgKG5hbWUpKTsNCiANCiAgIGNvbnN0IHVuc2lnbmVkIGNoYXIgKmlkOw0K QEAgLTE1NSwxNyArMTYwLDE3IEBAIG1vZHVsZV9jYWxsYmFjayAoRHdmbF9Nb2R1bGUgKm1vZCwg dm9pZCAqKnVzZXJkYXRhIF9fYXR0cmlidXRlX18oKHVudXNlZCkpLA0KICAgaW50IGlkX2xlbiA9 IGR3ZmxfbW9kdWxlX2J1aWxkX2lkIChtb2QsICZpZCwgJmlkX3ZhZGRyKTsNCiAgIGlmIChpZF9s ZW4gPiAwKQ0KICAgICB7DQotICAgICAgcHJpbnRmICgiICBbIik7DQorICAgICAgZnByaW50ZiAo Zm91dCwgIiAgWyIpOw0KICAgICAgIGRvDQotCXByaW50ZiAoIiUwMiIgUFJJeDgsICppZCsrKTsN CisJZnByaW50ZiAoZm91dCwgIiUwMiIgUFJJeDgsICppZCsrKTsNCiAgICAgICB3aGlsZSAoLS1p ZF9sZW4gPiAwKTsNCi0gICAgICBwcmludGYgKCJdXG4iKTsNCisgICAgICBmcHJpbnRmIChmb3V0 LCAiXVxuIik7DQogICAgIH0NCiANCiAgIGlmIChlbGYgIT0gTlVMTCkNCi0gICAgcHJpbnRmICgi ICAlc1xuIiwgbWFpbmZpbGUgIT0gTlVMTCA/IG1haW5maWxlIDogIi0iKTsNCisgICAgZnByaW50 ZiAoZm91dCwgIiAgJXNcbiIsIG1haW5maWxlICE9IE5VTEwgPyBtYWluZmlsZSA6ICItIik7DQog ICBpZiAoZHdhcmYgIT0gTlVMTCkNCi0gICAgcHJpbnRmICgiICAlc1xuIiwgZGVidWdmaWxlICE9 IE5VTEwgPyBkZWJ1Z2ZpbGUgOiAiLSIpOw0KKyAgICBmcHJpbnRmIChmb3V0LCAiICAlc1xuIiwg ZGVidWdmaWxlICE9IE5VTEwgPyBkZWJ1Z2ZpbGUgOiAiLSIpOw0KIA0KICAgcmV0dXJuIERXQVJG X0NCX09LOw0KIH0NCkBAIC0yMTksMTAgKzIyNCwxMCBAQCBwcmludF9mcmFtZSAoaW50IG5yLCBE d2FyZl9BZGRyIHBjLCBib29sIGlzYWN0aXZhdGlvbiwNCiAJICAgICBEd2FyZl9EaWUgKmRpZSkN CiB7DQogICBpbnQgd2lkdGggPSBnZXRfYWRkcl93aWR0aCAobW9kKTsNCi0gIHByaW50ZiAoIiMl LTJ1IDB4JTAqIiBQUkl4NjQsIG5yLCB3aWR0aCwgKHVpbnQ2NF90KSBwYyk7DQorICBmcHJpbnRm IChmb3V0LCAiIyUtMnUgMHglMCoiIFBSSXg2NCwgbnIsIHdpZHRoLCAodWludDY0X3QpIHBjKTsN CiANCiAgIGlmIChzaG93X2FjdGl2YXRpb24pDQotICAgIHByaW50ZiAoIiU0cyIsICEgaXNhY3Rp dmF0aW9uID8gIi0gMSIgOiAiIik7DQorICAgIGZwcmludGYgKGZvdXQsICIlNHMiLCAhIGlzYWN0 aXZhdGlvbiA/ICItIDEiIDogIiIpOw0KIA0KICAgaWYgKHN5bW5hbWUgIT0gTlVMTCkNCiAgICAg ew0KQEAgLTIzNyw3ICsyNDIsNyBAQCBwcmludF9mcmFtZSAoaW50IG5yLCBEd2FyZl9BZGRyIHBj LCBib29sIGlzYWN0aXZhdGlvbiwNCiAJICAgIHN5bW5hbWUgPSBkZW1hbmdsZV9idWZmZXIgPSBk c3ltbmFtZTsNCiAJfQ0KICNlbmRpZg0KLSAgICAgIHByaW50ZiAoIiAlcyIsIHN5bW5hbWUpOw0K KyAgICAgIGZwcmludGYgKGZvdXQsICIgJXMiLCBzeW1uYW1lKTsNCiAgICAgfQ0KIA0KICAgY29u c3QgY2hhciogZm5hbWU7DQpAQCAtMjQ3LDcgKzI1Miw3IEBAIHByaW50X2ZyYW1lIChpbnQgbnIs IER3YXJmX0FkZHIgcGMsIGJvb2wgaXNhY3RpdmF0aW9uLA0KICAgaWYgKHNob3dfbW9kdWxlKQ0K ICAgICB7DQogICAgICAgaWYgKGZuYW1lICE9IE5VTEwpDQotCXByaW50ZiAoIiAtICVzIiwgZm5h bWUpOw0KKwlmcHJpbnRmIChmb3V0LCAiIC0gJXMiLCBmbmFtZSk7DQogICAgIH0NCiANCiAgIGlm IChzaG93X2J1aWxkX2lkKQ0KQEAgLTI1NywxMSArMjYyLDExIEBAIHByaW50X2ZyYW1lIChpbnQg bnIsIER3YXJmX0FkZHIgcGMsIGJvb2wgaXNhY3RpdmF0aW9uLA0KICAgICAgIGludCBpZF9sZW4g PSBkd2ZsX21vZHVsZV9idWlsZF9pZCAobW9kLCAmaWQsICZpZF92YWRkcik7DQogICAgICAgaWYg KGlkX2xlbiA+IDApDQogCXsNCi0JICBwcmludGYgKCJcbiAgICBbIik7DQorCSAgZnByaW50ZiAo Zm91dCwgIlxuICAgIFsiKTsNCiAJICBkbw0KLQkgICAgcHJpbnRmICgiJTAyIiBQUkl4OCwgKmlk KyspOw0KKwkgICAgZnByaW50ZiAoZm91dCwgIiUwMiIgUFJJeDgsICppZCsrKTsNCiAJICB3aGls ZSAoLS1pZF9sZW4gPiAwKTsNCi0JICBwcmludGYgKCJdQDB4JTAiIFBSSXg2NCAiKzB4JSIgUFJJ eDY0LA0KKwkgIGZwcmludGYgKGZvdXQsICJdQDB4JTAiIFBSSXg2NCAiKzB4JSIgUFJJeDY0LA0K IAkJICBzdGFydCwgcGNfYWRqdXN0ZWQgLSBzdGFydCk7DQogCX0NCiAgICAgfQ0KQEAgLTMwMywx NiArMzA4LDE2IEBAIHByaW50X2ZyYW1lIChpbnQgbnIsIER3YXJmX0FkZHIgcGMsIGJvb2wgaXNh Y3RpdmF0aW9uLA0KIA0KICAgICAgIGlmIChzbmFtZSAhPSBOVUxMKQ0KIAl7DQotCSAgcHJpbnRm ICgiXG4gICAgJXMiLCBzbmFtZSk7DQorCSAgZnByaW50ZiAoZm91dCwgIlxuICAgICVzIiwgc25h bWUpOw0KIAkgIGlmIChsaW5lID4gMCkNCiAJICAgIHsNCi0JICAgICAgcHJpbnRmICgiOiVkIiwg bGluZSk7DQorCSAgICAgIGZwcmludGYgKGZvdXQsICI6JWQiLCBsaW5lKTsNCiAJICAgICAgaWYg KGNvbCA+IDApDQotCQlwcmludGYgKCI6JWQiLCBjb2wpOw0KKwkJZnByaW50ZiAoZm91dCwgIjol ZCIsIGNvbCk7DQogCSAgICB9DQogCX0NCiAgICAgfQ0KLSAgcHJpbnRmICgiXG4iKTsNCisgIGZw cmludGYgKGZvdXQsICJcbiIpOw0KIH0NCiANCiBzdGF0aWMgdm9pZA0KQEAgLTM2Miw3ICszNjcs NyBAQCBwcmludF9mcmFtZXMgKHN0cnVjdCBmcmFtZXMgKmZyYW1lcywgcGlkX3QgdGlkLCBpbnQg ZHdmbGVyciwgY29uc3QgY2hhciAqd2hhdCkNCiAgIGlmIChmcmFtZXMtPmZyYW1lcyA+IDApDQog ICAgIGZyYW1lc19zaG93biA9IHRydWU7DQogDQotICBwcmludGYgKCJUSUQgJWQ6XG4iLCB0aWQp Ow0KKyAgZnByaW50ZiAoZm91dCwgIlRJRCAlZDpcbiIsIHRpZCk7DQogICBpbnQgZnJhbWVfbnIg PSAwOw0KICAgZm9yIChpbnQgbnIgPSAwOyBuciA8IGZyYW1lcy0+ZnJhbWVzICYmIChtYXhmcmFt ZXMgPT0gMA0KIAkJCQkJICAgfHwgZnJhbWVfbnIgPCBtYXhmcmFtZXMpOyBucisrKQ0KQEAgLTU2 MCw2ICs1NjUsMTQgQEAgcGFyc2Vfb3B0IChpbnQga2V5LCBjaGFyICphcmcgX19hdHRyaWJ1dGVf XyAoKHVudXNlZCkpLA0KICAgICAgIHNob3dfbW9kdWxlcyA9IHRydWU7DQogICAgICAgYnJlYWs7 DQogDQorICAgIGNhc2UgJ28nOg0KKyAgICAgIHVtYXNrIChTX0lXR1JQIHwgU19JV09USCk7DQor ICAgICAgZm91dCA9IGZvcGVuIChhcmcsICJ3eCIpOw0KKyAgICAgIGlmIChmb3V0ID09IE5VTEwp DQorCWVycm9yIChFWElUX0JBRCwgZXJybm8sDQorCSAgICAgICBOXygiQ2Fubm90IGNyZWF0ZSBh bmQgZXhjbHVzaXZlbHkgb3BlbiBvdXRwdXQgZmlsZSAnJXMnIiksIGFyZyk7DQorICAgICAgYnJl YWs7DQorDQogICAgIGNhc2UgQVJHUF9LRVlfRU5EOg0KICAgICAgIGlmIChjb3JlID09IE5VTEwg JiYgZXhlYyAhPSBOVUxMKQ0KIAlhcmdwX2Vycm9yIChzdGF0ZSwNCkBAIC02NTgsNiArNjcxLDgg QEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQ0KIAlOXygiQWRkaXRpb25hbGx5IHNob3cg aW5saW5lZCBmdW5jdGlvbiBmcmFtZXMgdXNpbmcgRFdBUkYgZGVidWdpbmZvIGlmIGF2YWlsYWJs ZSAoaW1wbGllcyAtZCkiKSwgMCB9LA0KICAgICAgIHsgIm1vZHVsZSIsICAnbScsIE5VTEwsIDAs DQogCU5fKCJBZGRpdGlvbmFsbHkgc2hvdyBtb2R1bGUgZmlsZSBpbmZvcm1hdGlvbiIpLCAwIH0s DQorICAgICAgeyAib3V0cHV0IiwgICdvJywgIkZJTEUiLCAwLA0KKwlOXygiUGxhY2Ugb3V0cHV0 IGludG8gRklMRS4gRklMRSBzaG91bGQgbm90IHlldCBleGlzdHMgYW5kIHdpbGwgYmUgY3JlYXRl ZC4iKSwgMCB9LA0KICAgICAgIHsgInNvdXJjZSIsICAncycsIE5VTEwsIDAsDQogCU5fKCJBZGRp dGlvbmFsbHkgc2hvdyBzb3VyY2UgZmlsZSBpbmZvcm1hdGlvbiIpLCAwIH0sDQogICAgICAgeyAi dmVyYm9zZSIsICd2JywgTlVMTCwgMCwNCkBAIC02OTAsMTEgKzcwNSwxMiBAQCBvY2N1cmVkIHRo ZSBwcm9ncmFtIGV4aXRzIHdpdGggcmV0dXJuIGNvZGUgMi4gIElmIHRoZSBwcm9ncmFtIHdhcyBc DQogaW52b2tlZCB3aXRoIGJhZCBvciBtaXNzaW5nIGFyZ3VtZW50cyBpdCB3aWxsIGV4aXQgd2l0 aCByZXR1cm4gY29kZSA2NC4iKQ0KICAgICB9Ow0KIA0KKyAgZm91dCA9IHN0ZG91dDsNCiAgIGFy Z3BfcGFyc2UgKCZhcmdwLCBhcmdjLCBhcmd2LCAwLCBOVUxMLCBOVUxMKTsNCiANCiAgIGlmIChz aG93X21vZHVsZXMpDQogICAgIHsNCi0gICAgICBwcmludGYgKCJQSUQgJWQgLSAlcyBtb2R1bGUg bWVtb3J5IG1hcFxuIiwgZHdmbF9waWQgKGR3ZmwpLA0KKyAgICAgIGZwcmludGYgKGZvdXQsICJQ SUQgJWQgLSAlcyBtb2R1bGUgbWVtb3J5IG1hcFxuIiwgZHdmbF9waWQgKGR3ZmwpLA0KIAkgICAg ICBwaWQgIT0gMCA/ICJwcm9jZXNzIiA6ICJjb3JlIik7DQogICAgICAgaWYgKGR3ZmxfZ2V0bW9k dWxlcyAoZHdmbCwgbW9kdWxlX2NhbGxiYWNrLCBOVUxMLCAwKSAhPSAwKQ0KIAllcnJvciAoRVhJ VF9CQUQsIDAsICJkd2ZsX2dldG1vZHVsZXM6ICVzIiwgZHdmbF9lcnJtc2cgKC0xKSk7DQpAQCAt NzI3LDcgKzc0Myw3IEBAIGludm9rZWQgd2l0aCBiYWQgb3IgbWlzc2luZyBhcmd1bWVudHMgaXQg d2lsbCBleGl0IHdpdGggcmV0dXJuIGNvZGUgNjQuIikNCiAgICAgfQ0KICAgZWxzZQ0KICAgICB7 DQotICAgICAgcHJpbnRmICgiUElEICVkIC0gJXNcbiIsIGR3ZmxfcGlkIChkd2ZsKSwgcGlkICE9 IDAgPyAicHJvY2VzcyIgOiAiY29yZSIpOw0KKyAgICAgIGZwcmludGYgKGZvdXQsICJQSUQgJWQg LSAlc1xuIiwgZHdmbF9waWQgKGR3ZmwpLCBwaWQgIT0gMCA/ICJwcm9jZXNzIiA6ICJjb3JlIik7 DQogICAgICAgc3dpdGNoIChkd2ZsX2dldHRocmVhZHMgKGR3ZmwsIHRocmVhZF9jYWxsYmFjaywg JmZyYW1lcykpDQogCXsNCiAJY2FzZSBEV0FSRl9DQl9PSzoNCi0tIA0KMS44LjMuMQ0KDQo= --===============2227839111988718226==--