From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] Additional files for .debug_macro support
Date: Fri, 07 Nov 2014 15:54:45 +0100 [thread overview]
Message-ID: <1415372085.19702.32.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: 8a44e6c215edffae1ef66b9c43aeb730901d43a6.1415112324.git.pmachata@redhat.com
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Tue, 2014-11-04 at 15:49 +0100, Petr Machata wrote:
> I forgot to add these files to the main .debug_macro support patch. I
> present them separately here, as I think that will make review actually
> easier. But do tell me otherwise. I would of course squash them before
> pushing to master.
Looks fine. One nitpick.
> diff --git a/libdw/dwarf_macro_getsrcfiles.c b/libdw/dwarf_macro_getsrcfiles.c
> new file mode 100644
> index 0000000..2b8466b
> --- /dev/null
> +++ b/libdw/dwarf_macro_getsrcfiles.c
> @@ -0,0 +1,88 @@
> +/* Return a version of a macro.
Wrong comment for this file.
Thanks,
Mark
next reply other threads:[~2014-11-07 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 14:54 Mark Wielaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 14:49 Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415372085.19702.32.camel@bordewijk.wildebeest.org \
--to=mjw@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).