From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============0208806943007319263=="
MIME-Version: 1.0
From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] Additional files for .debug_macro support
Date: Fri, 07 Nov 2014 15:54:45 +0100
Message-ID: <1415372085.19702.32.camel@bordewijk.wildebeest.org>
In-Reply-To: 8a44e6c215edffae1ef66b9c43aeb730901d43a6.1415112324.git.pmachata@redhat.com

--===============0208806943007319263==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Tue, 2014-11-04 at 15:49 +0100, Petr Machata wrote:
> I forgot to add these files to the main .debug_macro support patch.  I
> present them separately here, as I think that will make review actually
> easier.  But do tell me otherwise.  I would of course squash them before
> pushing to master.

Looks fine. One nitpick.

> diff --git a/libdw/dwarf_macro_getsrcfiles.c b/libdw/dwarf_macro_getsrcfi=
les.c
> new file mode 100644
> index 0000000..2b8466b
> --- /dev/null
> +++ b/libdw/dwarf_macro_getsrcfiles.c
> @@ -0,0 +1,88 @@
> +/* Return a version of a macro.

Wrong comment for this file.

Thanks,

Mark

--===============0208806943007319263==--