From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2610427232520465070==" MIME-Version: 1.0 From: Mark Wielaard To: elfutils-devel@lists.fedorahosted.org Subject: Re: [PATCH] readelf: Fix cie_offset calculation comparison on 32bit. Date: Tue, 28 Apr 2015 14:15:08 +0200 Message-ID: <1430223308.1938.187.camel@bordewijk.wildebeest.org> In-Reply-To: 1429699846-2117-1-git-send-email-mjw@redhat.com --===============2610427232520465070== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, 2015-04-22 at 12:50 +0200, Mark Wielaard wrote: > gcc -fsanitize=3Dundefined pointed out that on 32bit systems the calculat= ion > to match the cie_offset to the cie_id could be undefined because a cie_id > could be an unsigned 64bit value while ptrdiff_t is only 32bits. Correct > the calculation to use 64bit values. > > 2015-03-22 Mark Wielaard > = > + * readelf.c (print_debug_frame_section): Cast start to Dwarf_Off > + before subtracting cie_id. That wasn't completely correct on 64bit. We also need to explicitly cast cie_offset to Dwarf_Off. Pushed with that fixed as attached. --===============2610427232520465070== Content-Type: text/x-patch MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-readelf-Fix-cie_offset-calculation-comparison-on-32b.patch" RnJvbSAzMmQ1YjZmNjFhOTBiM2MwYzc3N2I3M2VlZTk3M2Q2ODE2YTIxMjk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTWFyayBXaWVsYWFyZCA8bWp3QHJlZGhhdC5jb20+DQpEYXRl OiBXZWQsIDIyIEFwciAyMDE1IDEyOjQ3OjQ2ICswMjAwDQpTdWJqZWN0OiBbUEFUQ0hdIHJlYWRl bGY6IEZpeCBjaWVfb2Zmc2V0IGNhbGN1bGF0aW9uIGNvbXBhcmlzb24gb24gMzJiaXQuDQoNCmdj YyAtZnNhbml0aXplPXVuZGVmaW5lZCBwb2ludGVkIG91dCB0aGF0IG9uIDMyYml0IHN5c3RlbXMg dGhlIGNhbGN1bGF0aW9uDQp0byBtYXRjaCB0aGUgY2llX29mZnNldCB0byB0aGUgY2llX2lkIGNv dWxkIGJlIHVuZGVmaW5lZCBiZWNhdXNlIGEgY2llX2lkDQpjb3VsZCBiZSBhbiB1bnNpZ25lZCA2 NGJpdCB2YWx1ZSB3aGlsZSBwdHJkaWZmX3QgaXMgb25seSAzMmJpdHMuIENvcnJlY3QNCnRoZSBj YWxjdWxhdGlvbiB0byB1c2UgNjRiaXQgdmFsdWVzLg0KDQpTaWduZWQtb2ZmLWJ5OiBNYXJrIFdp ZWxhYXJkIDxtandAcmVkaGF0LmNvbT4NCi0tLQ0KIHNyYy9DaGFuZ2VMb2cgfCA2ICsrKysrKw0K IHNyYy9yZWFkZWxmLmMgfCA0ICsrLS0NCiAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL3NyYy9DaGFuZ2VMb2cgYi9zcmMvQ2hh bmdlTG9nDQppbmRleCA0MGEwZTZmLi5hNGFjNGU0IDEwMDY0NA0KLS0tIGEvc3JjL0NoYW5nZUxv Zw0KKysrIGIvc3JjL0NoYW5nZUxvZw0KQEAgLTEsNSArMSwxMSBAQA0KIDIwMTUtMDMtMjIgIE1h cmsgV2llbGFhcmQgIDxtandAcmVkaGF0LmNvbT4NCiANCisJKiByZWFkZWxmLmMgKHByaW50X2Rl YnVnX2ZyYW1lX3NlY3Rpb24pOiBDYXN0IHN0YXJ0IHRvIER3YXJmX09mZg0KKwliZWZvcmUgc3Vi dHJhY3RpbmcgY2llX2lkLiBBbmQgY2FzdCBjaWVfb2Zmc2V0IHRvIER3YXJmX09mZiBiZWZvcmUN CisJY29tcGFyaXNvbi4NCisNCisyMDE1LTAzLTIyICBNYXJrIFdpZWxhYXJkICA8bWp3QHJlZGhh dC5jb20+DQorDQogCSogcmVhZGVsZi5jIChwcmludF9nZGJfaW5kZXhfc2VjdGlvbik6IENoZWNr IGFsbCBvZmZzZXRzIHVzZWQNCiAJYWdhaW5zdCBzZWN0aW9uIGRfc2l6ZS4NCiANCmRpZmYgLS1n aXQgYS9zcmMvcmVhZGVsZi5jIGIvc3JjL3JlYWRlbGYuYw0KaW5kZXggMjZjN2VlZC4uYjRjYjNh OCAxMDA2NDQNCi0tLSBhL3NyYy9yZWFkZWxmLmMNCisrKyBiL3NyYy9yZWFkZWxmLmMNCkBAIC01 NjE5LDggKzU2MTksOCBAQCBwcmludF9kZWJ1Z19mcmFtZV9zZWN0aW9uIChEd2ZsX01vZHVsZSAq ZHdmbG1vZCwgRWJsICplYmwsIEdFbGZfRWhkciAqZWhkciwNCiAJICBzdHJ1Y3QgY2llaW5mbyAq Y2llID0gY2llczsNCiAJICB3aGlsZSAoY2llICE9IE5VTEwpDQogCSAgICBpZiAoaXNfZWhfZnJh bWUNCi0JCT8gc3RhcnQgLSAocHRyZGlmZl90KSBjaWVfaWQgPT0gY2llLT5jaWVfb2Zmc2V0DQot CQk6IChwdHJkaWZmX3QpIGNpZV9pZCA9PSBjaWUtPmNpZV9vZmZzZXQpDQorCQk/ICgoRHdhcmZf T2ZmKSBzdGFydCAtIGNpZV9pZCkgPT0gKER3YXJmX09mZikgY2llLT5jaWVfb2Zmc2V0DQorCQk6 IGNpZV9pZCA9PSAoRHdhcmZfT2ZmKSBjaWUtPmNpZV9vZmZzZXQpDQogCSAgICAgIGJyZWFrOw0K IAkgICAgZWxzZQ0KIAkgICAgICBjaWUgPSBjaWUtPm5leHQ7DQotLSANCjEuOC4zLjENCg0K --===============2610427232520465070==--