Re: [PATCH] config: Use ARFLAGS 'cr'.

Re: [PATCH] config: Use ARFLAGS 'cr'.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Wed, 2015-10-07 at 13:50 +0200, Mark Wielaard wrote:
> By default automake uses ARFLAGS cru. 'u' is an optimization that
> makes sure files are only added to the archive when they are newer
> than the version already in the .a file. This optimization doesn't
> work when ar is deterministic by default because then it doesn't
> record timestamps in the archive. Deterministic ar is the default
> now on various distributions causing multiple warnings like:
> 
>   ar: `u' modifier ignored since `D' is the default (see `U')
> 
> To suppress these warnings drop the 'u' flag.

Pushed to master.

[PATCH] config: Use ARFLAGS 'cr'.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

By default automake uses ARFLAGS cru. 'u' is an optimization that
makes sure files are only added to the archive when they are newer
than the version already in the .a file. This optimization doesn't
work when ar is deterministic by default because then it doesn't
record timestamps in the archive. Deterministic ar is the default
now on various distributions causing multiple warnings like:

  ar: `u' modifier ignored since `D' is the default (see `U')

To suppress these warnings drop the 'u' flag.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 config/ChangeLog | 4 ++++
 config/eu.am     | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/config/ChangeLog b/config/ChangeLog
index ba5cb38..29c55f5 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,7 @@
+2015-10-07  Mark Wielaard  <mjw@redhat.com>
+
+	* eu.am (ARFLAGS): Set to "cr".
+
 2015-10-05  Josh Stone  <jistone@redhat.com>
 
 	* eu.am (%.os): Add AM_V_CC silencers.
diff --git a/config/eu.am b/config/eu.am
index 6ad8f82..5b1bb0b 100644
--- a/config/eu.am
+++ b/config/eu.am
@@ -32,6 +32,10 @@
 DEFS = -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"${localedir}"'
 AM_CPPFLAGS = -I. -I$(srcdir) -I$(top_srcdir)/lib -I..
 
+# Drop the 'u' flag that automake adds by default. It is incompatible
+# with deterministic archives.
+ARFLAGS = cr
+
 # Warn about stack usage of more than 256K = 262144 bytes.
 if ADD_STACK_USAGE_WARNING
 STACK_USAGE_WARNING=-Wstack-usage=262144
-- 
2.4.3