* Re: [PATCH] libdwfl: Don't leak memory in proc_maps_report when ENOEXEC.
@ 2016-02-22 11:15 Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2016-02-22 11:15 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
On Sat, 2016-02-13 at 19:49 +0100, Mark Wielaard wrote:
> We forgot to free last_file on error.
Pushed to master.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] libdwfl: Don't leak memory in proc_maps_report when ENOEXEC.
@ 2016-02-13 18:49 Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2016-02-13 18:49 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]
We forgot to free last_file on error.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
libdwfl/ChangeLog | 4 ++++
libdwfl/linux-proc-maps.c | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 903c0cc..69fd233 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,5 +1,9 @@
2016-02-13 Mark Wielaard <mjw@redhat.com>
+ * linux-proc-maps.c (proc_maps_report): Free last_file when ENOEXEC.
+
+2016-02-13 Mark Wielaard <mjw@redhat.com>
+
* frame_unwind.c (new_unwound): Check and return unwound.
(handle_cfi): Check new_unwound was able to allocate new memory
before use. Return DWFL_E_NOMEM otherwise.
diff --git a/libdwfl/linux-proc-maps.c b/libdwfl/linux-proc-maps.c
index 9e7b2a2..94b26d5 100644
--- a/libdwfl/linux-proc-maps.c
+++ b/libdwfl/linux-proc-maps.c
@@ -1,5 +1,5 @@
/* Standard libdwfl callbacks for debugging a live Linux process.
- Copyright (C) 2005-2010, 2013, 2014 Red Hat, Inc.
+ Copyright (C) 2005-2010, 2013, 2014, 2016 Red Hat, Inc.
This file is part of elfutils.
This file is free software; you can redistribute it and/or modify
@@ -218,6 +218,7 @@ proc_maps_report (Dwfl *dwfl, FILE *f, GElf_Addr sysinfo_ehdr, pid_t pid)
|| nread <= 0)
{
free (line);
+ free (last_file);
return ENOEXEC;
}
--
2.5.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-22 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-22 11:15 [PATCH] libdwfl: Don't leak memory in proc_maps_report when ENOEXEC Mark Wielaard
-- strict thread matches above, loose matches on Subject: below --
2016-02-13 18:49 Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).