Re: [PATCH] elfcompress: -q should not imply --force.

Re: [PATCH] elfcompress: -q should not imply --force.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

On Sat, 2016-02-13 at 19:57 +0100, Mark Wielaard wrote:
> We accidentally set force = true after handling -q and setting verbose--.

Pushed to master.

[PATCH] elfcompress: -q should not imply --force.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

We accidentally set force = true after handling -q and setting verbose--.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 src/ChangeLog     | 4 ++++
 src/elfcompress.c | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/ChangeLog b/src/ChangeLog
index 2978240..debf5a4 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2016-02-13  Mark Wielaard  <mjw@redhat.com>
+
+	* elfcompress.c (parse_opt): Don't fallthrough after processing -q.
+
 2016-02-12  Mark Wielaard  <mjw@redhat.com>
 
 	* strip.c (handle_elf): Correct elf_assert shndxdata check.
diff --git a/src/elfcompress.c b/src/elfcompress.c
index 23939db..d0ca469 100644
--- a/src/elfcompress.c
+++ b/src/elfcompress.c
@@ -1,5 +1,5 @@
 /* Compress or decompress an ELF file.
-   Copyright (C) 2015 Red Hat, Inc.
+   Copyright (C) 2015, 2016 Red Hat, Inc.
    This file is part of elfutils.
 
    This file is free software; you can redistribute it and/or modify
@@ -101,6 +101,7 @@ parse_opt (int key, char *arg __attribute__ ((unused)),
 
     case 'q':
       verbose--;
+      break;
 
     case 'f':
       force = true;
-- 
2.5.0