[PATCH] Add support for DT_PPC_OPT

[PATCH] Add support for DT_PPC_OPT

[Normand]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

From: Andreas Schwab <schwab@suse.de>

Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 backends/ppc_symbol.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/backends/ppc_symbol.c b/backends/ppc_symbol.c
index 37d4918..1273c1d 100644
--- a/backends/ppc_symbol.c
+++ b/backends/ppc_symbol.c
@@ -65,6 +65,8 @@ ppc_dynamic_tag_name (int64_t tag, char *buf __attribute__ ((unused)),
     {
     case DT_PPC_GOT:
       return "PPC_GOT";
+    case DT_PPC_OPT:
+      return "PPC_OPT";
     default:
       break;
     }
@@ -75,7 +77,8 @@ ppc_dynamic_tag_name (int64_t tag, char *buf __attribute__ ((unused)),
 bool
 ppc_dynamic_tag_check (int64_t tag)
 {
-  return tag == DT_PPC_GOT;
+  return (tag == DT_PPC_GOT
+	  || tag == DT_PPC_OPT);
 }
 
 
-- 
1.9.1

Re: [PATCH] Add support for DT_PPC_OPT

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

On Fri, 2016-02-26 at 17:33 +0100, Normand wrote:
> On 26/02/2016 16:53, Mark Wielaard wrote:
> > On Fri, 2016-02-26 at 15:22 +0000, Michel Normand wrote:
> >> Sorry for the duplication of the email in thread, this is the same patch in two cases.
> >> The patch is required for build of package for ppc, still done in openSUSE (1)
> >
> > No worries, the patch looks OK, I'll add a ChangeLog entry and apply it.
> >
> > It would be nice to add a reference to the spec defining DT_PPC_OPT.
> > Do you know where it is officially described?
> 
> The  DT_PPC_OPT is coming from the binutils patch (1)
> that added in in /include/elf/ppc.h
> 
> (1) https://sourceware.org/ml/binutils/2013-10/msg00378.html

Thanks. I put that in the commit message, so there is a record where it
came from.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-support-for-DT_PPC_OPT.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]

From d1d4db68eb441ae67864be209a0679cbc86189c5 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <schwab@suse.de>
Date: Fri, 26 Feb 2016 15:47:21 +0100
Subject: [PATCH] Add support for DT_PPC_OPT

https://sourceware.org/ml/binutils/2013-10/msg00378.html

Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 backends/ChangeLog    | 5 +++++
 backends/ppc_symbol.c | 5 ++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/backends/ChangeLog b/backends/ChangeLog
index d222266..207a888 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,8 @@
+2016-02-26  Andreas Schwab  <schwab@suse.de>
+
+	* ppc_symbol.c (ppc_dynamic_tag_name): Add DT_PPC_OPT.
+	(ppc_dynamic_tag_check): Likewise.
+
 2015-12-28  Mark Wielaard  <mjw@redhat.com>
 
 	* i386_reloc.def: Add GOT32X.
diff --git a/backends/ppc_symbol.c b/backends/ppc_symbol.c
index 37d4918..1273c1d 100644
--- a/backends/ppc_symbol.c
+++ b/backends/ppc_symbol.c
@@ -65,6 +65,8 @@ ppc_dynamic_tag_name (int64_t tag, char *buf __attribute__ ((unused)),
     {
     case DT_PPC_GOT:
       return "PPC_GOT";
+    case DT_PPC_OPT:
+      return "PPC_OPT";
     default:
       break;
     }
@@ -75,7 +77,8 @@ ppc_dynamic_tag_name (int64_t tag, char *buf __attribute__ ((unused)),
 bool
 ppc_dynamic_tag_check (int64_t tag)
 {
-  return tag == DT_PPC_GOT;
+  return (tag == DT_PPC_GOT
+	  || tag == DT_PPC_OPT);
 }
 
 
-- 
1.8.3.1

Re: [PATCH] Add support for DT_PPC_OPT

[Normand]

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]



On 26/02/2016 16:53, Mark Wielaard wrote:
> On Fri, 2016-02-26 at 15:22 +0000, Michel Normand wrote:
>> Sorry for the duplication of the email in thread, this is the same patch in two cases.
>> The patch is required for build of package for ppc, still done in openSUSE (1)
>
> No worries, the patch looks OK, I'll add a ChangeLog entry and apply it.
>
> It would be nice to add a reference to the spec defining DT_PPC_OPT.
> Do you know where it is officially described?

The  DT_PPC_OPT is coming from the binutils patch (1)
that added in in /include/elf/ppc.h

(1) https://sourceware.org/ml/binutils/2013-10/msg00378.html

>
> Thanks,
>
> Mark
>

-- 
Michel Normand

Re: [PATCH] Add support for DT_PPC_OPT

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On Fri, 2016-02-26 at 15:22 +0000, Michel Normand wrote:
> Sorry for the duplication of the email in thread, this is the same patch in two cases.
> The patch is required for build of package for ppc, still done in openSUSE (1)

No worries, the patch looks OK, I'll add a ChangeLog entry and apply it.

It would be nice to add a reference to the spec defining DT_PPC_OPT.
Do you know where it is officially described?

Thanks,

Mark

Re: [PATCH] Add support for DT_PPC_OPT

[Michel Normand]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

Sorry for the duplication of the email in thread, this is the same patch in two cases.
The patch is required for build of package for ppc, still done in openSUSE (1)

(1) https://build.opensuse.org/package/show/Base:System/elfutils

[PATCH] Add support for DT_PPC_OPT

[Michel Normand]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

From: Andreas Schwab <schwab@suse.de>

Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 backends/ppc_symbol.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/backends/ppc_symbol.c b/backends/ppc_symbol.c
index 37d4918..1273c1d 100644
--- a/backends/ppc_symbol.c
+++ b/backends/ppc_symbol.c
@@ -65,6 +65,8 @@ ppc_dynamic_tag_name (int64_t tag, char *buf __attribute__ ((unused)),
     {
     case DT_PPC_GOT:
       return "PPC_GOT";
+    case DT_PPC_OPT:
+      return "PPC_OPT";
     default:
       break;
     }
@@ -75,7 +77,8 @@ ppc_dynamic_tag_name (int64_t tag, char *buf __attribute__ ((unused)),
 bool
 ppc_dynamic_tag_check (int64_t tag)
 {
-  return tag == DT_PPC_GOT;
+  return (tag == DT_PPC_GOT
+	  || tag == DT_PPC_OPT);
 }
 
 
-- 
1.9.1