* Re: [PATCH] sparc: restore 32-bit build.
@ 2016-02-26 19:49 Mark Wielaard
0 siblings, 0 replies; 4+ messages in thread
From: Mark Wielaard @ 2016-02-26 19:49 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Fri, 2016-02-26 at 10:30 -0800, Jose E. Marchesi wrote:
> This patch provides a dummy sparc_set_initial_registers-tid for
> sparc32. This fixes the build in sparcv9-*-* targets.
[...]
> diff --git a/backends/sparc_initreg.c b/backends/sparc_initreg.c
> index c2a9b32..c4b321c 100644
> --- a/backends/sparc_initreg.c
> +++ b/backends/sparc_initreg.c
> @@ -45,7 +45,7 @@ EBLHOOK (set_initial_registers_tid) (pid_t tid __attribute__ ((unused)),
> ebl_tid_registers_t *setfunc __attribute__ ((unused)),
> void *arg __attribute__ ((unused)))
> {
> -#ifndef __sparc__
> +#if !defined(__sparc__) || !defined( __arch64__)
> return false;
> #else /* __sparc__ */
Really __arch64__?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sparc: restore 32-bit build.
@ 2016-02-26 21:17 Jose E. Marchesi
0 siblings, 0 replies; 4+ messages in thread
From: Jose E. Marchesi @ 2016-02-26 21:17 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
> > This patch provides a dummy sparc_set_initial_registers-tid for
> > sparc32. This fixes the build in sparcv9-*-* targets.
> [...]
> > diff --git a/backends/sparc_initreg.c b/backends/sparc_initreg.c
> > index c2a9b32..c4b321c 100644
> > --- a/backends/sparc_initreg.c
> > +++ b/backends/sparc_initreg.c
> > @@ -45,7 +45,7 @@ EBLHOOK (set_initial_registers_tid) (pid_t tid __attribute__ ((unused)),
> > ebl_tid_registers_t *setfunc __attribute__ ((unused)),
> > void *arg __attribute__ ((unused)))
> > {
> > -#ifndef __sparc__
> > +#if !defined(__sparc__) || !defined( __arch64__)
> > return false;
> > #else /* __sparc__ */
>
> Really __arch64__?
O, I see, it says __arch64__, not __aarch64__.
Duh. Slightly confusing. Sorry. Applied.
Thanks! :)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sparc: restore 32-bit build.
@ 2016-02-26 20:06 Mark Wielaard
0 siblings, 0 replies; 4+ messages in thread
From: Mark Wielaard @ 2016-02-26 20:06 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On Fri, 2016-02-26 at 20:49 +0100, Mark Wielaard wrote:
> On Fri, 2016-02-26 at 10:30 -0800, Jose E. Marchesi wrote:
> > This patch provides a dummy sparc_set_initial_registers-tid for
> > sparc32. This fixes the build in sparcv9-*-* targets.
> [...]
> > diff --git a/backends/sparc_initreg.c b/backends/sparc_initreg.c
> > index c2a9b32..c4b321c 100644
> > --- a/backends/sparc_initreg.c
> > +++ b/backends/sparc_initreg.c
> > @@ -45,7 +45,7 @@ EBLHOOK (set_initial_registers_tid) (pid_t tid __attribute__ ((unused)),
> > ebl_tid_registers_t *setfunc __attribute__ ((unused)),
> > void *arg __attribute__ ((unused)))
> > {
> > -#ifndef __sparc__
> > +#if !defined(__sparc__) || !defined( __arch64__)
> > return false;
> > #else /* __sparc__ */
>
> Really __arch64__?
O, I see, it says __arch64__, not __aarch64__.
Duh. Slightly confusing. Sorry. Applied.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sparc: restore 32-bit build.
@ 2016-02-26 18:30 Jose E. Marchesi
0 siblings, 0 replies; 4+ messages in thread
From: Jose E. Marchesi @ 2016-02-26 18:30 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
This patch provides a dummy sparc_set_initial_registers-tid for
sparc32. This fixes the build in sparcv9-*-* targets.
Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
---
backends/ChangeLog | 6 ++++++
backends/sparc_initreg.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/backends/ChangeLog b/backends/ChangeLog
index d222266..d1cd5ea 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,9 @@
+2016-02-26 Jose E. Marchesi <jose.marchesi@oracle.com>
+
+ * sparc_initreg.c (EBLHOOK): Provide a dummy
+ sparc_set_initial_registers_tid for sparc32. This fixes the build
+ in sparcv9-*-* targets.
+
2015-12-28 Mark Wielaard <mjw@redhat.com>
* i386_reloc.def: Add GOT32X.
diff --git a/backends/sparc_initreg.c b/backends/sparc_initreg.c
index c2a9b32..c4b321c 100644
--- a/backends/sparc_initreg.c
+++ b/backends/sparc_initreg.c
@@ -45,7 +45,7 @@ EBLHOOK (set_initial_registers_tid) (pid_t tid __attribute__ ((unused)),
ebl_tid_registers_t *setfunc __attribute__ ((unused)),
void *arg __attribute__ ((unused)))
{
-#ifndef __sparc__
+#if !defined(__sparc__) || !defined( __arch64__)
return false;
#else /* __sparc__ */
--
2.3.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-26 21:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26 19:49 [PATCH] sparc: restore 32-bit build Mark Wielaard
-- strict thread matches above, loose matches on Subject: below --
2016-02-26 21:17 Jose E. Marchesi
2016-02-26 20:06 Mark Wielaard
2016-02-26 18:30 Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).